Simplify and improve chef attribute handling

Set the attributes in a Ruby file under /etc/chef/client.d/ instead of
editing /etc/chef/client.rb
Now uses the new whitelist attribute:
https://docs.chef.io/client/19/cookbooks/attributes/attribute_persistence/

Local chef config also uses the same file. That means there is no longer
a need to use the sanitize script to remove override and default
attributes from nodes.

.chef/config.rb

@@ -8,27 +8,7 @@ data_bag_path             "data_bags"
 encrypted_data_bag_secret "#{current_dir}/encrypted_data_bag_secret"
 local_mode                true # Chef local mode, replacing Solo
 
-# Knife-Zero config, see https://knife-zero.github.io/40_configuration/
-# Prevent attributes from being saved to the node files
-knife[:automatic_attribute_whitelist] = %w[
-  fqdn
-  os
-  os_version
-  hostname
-  ipaddress
-  roles
-  recipes
-  ipaddress
-  platform
-  platform_version
-  cloud
-  cloud_v2
-  chef_packages
-]
-
 # Added to /etc/chef/client.rb on node bootstrap
 # https://docs.chef.io/attribute_persistence/
-# Source of truth: site-cookbooks/kosmos-base/files/default/chef_normal_attributes.yml
+# Source of truth: site-cookbooks/kosmos-base/files/default/chef_attributes.rb
-normal_attrs = YAML.load_file(File.expand_path("../site-cookbooks/kosmos-base/files/default/chef_normal_attributes.yml", __dir__))
+client_d_dir(File.expand_path("../site-cookbooks/kosmos-base/files/default/chef_attributes.rb"))
-knife[:normal_attribute_allowlist] = normal_attrs
-knife[:allowed_normal_attributes] = normal_attrs

site-cookbooks/kosmos-base/files/default/chef_attributes.rb

@@ -0,0 +1,8 @@
+allowed_automatic_attributes ["fqdn", "os", "os_version", "hostname",
+  "ipaddress", "roles", "recipes", "ipaddress",
+  "platform", "platform_version", "cloud",
+  "cloud_v2", "chef_packages", "zerotier"]
+allowed_default_attributes []
+allowed_override_attributes []
+allowed_normal_attributes ["knife_zero", "kosmos_kvm", "kosmos-ejabberd",
+  "openresty", "vm_host"]

site-cookbooks/kosmos-base/files/default/chef_normal_attributes.yml

@@ -1,6 +0,0 @@
----
-- knife_zero
-- kosmos_kvm
-- kosmos-ejabberd
-- openresty
-- vm_host

site-cookbooks/kosmos-base/recipes/default.rb

@@ -2,57 +2,31 @@
 # Cookbook Name:: kosmos-base
 # Recipe:: default
 #
-# The MIT License (MIT)
+
-#
+ruby_block "cleanup client.rb" do
-# Copyright:: 2019, Kosmos Developers
+  block do
-#
+    fe = Chef::Util::FileEdit.new("/etc/chef/client.rb")
-# Permission is hereby granted, free of charge, to any person obtaining a copy
+    # Delete old attributes, replaced by allow_*_attributes
-# of this software and associated documentation files (the "Software"), to deal
+    fe.search_file_delete_line(/^.*_attribute_whitelist.*/)
-# in the Software without restriction, including without limitation the rights
+    fe.write_file
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+  end
-# copies of the Software, and to permit persons to whom the Software is
+end
-# furnished to do so, subject to the following conditions:
+
-#
+cookbook_file "/etc/chef/client.d/attributes.rb" do
-# The above copyright notice and this permission notice shall be included in
+  source "chef_attributes.rb"
-# all copies or substantial portions of the Software.
+  mode "0644"
-#
+  notifies :create, "ruby_block[reload_client_config]", :immediately
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+end
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ruby_block "reload_client_config" do
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+  block do
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+    Chef::Config.from_file("/etc/chef/client.rb")
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+  end
-# THE SOFTWARE.
+  action :nothing
+end
 
 include_recipe "apt"
 
-cookbook_file "/etc/chef/chef_normal_attributes.yml" do
-  source "chef_normal_attributes.yml"
-  owner "root"
-  group "root"
-  mode "0644"
-end
-
-ruby_block "update allowed_normal_attributes in client.rb" do
-  block do
-    whitelist = YAML.load_file("/etc/chef/chef_normal_attributes.yml")
-    fe = Chef::Util::FileEdit.new("/etc/chef/client.rb")
-    fe.search_file_replace_line(
-      /^allowed_normal_attributes.*/,
-      "allowed_normal_attributes #{whitelist.inspect}"
-    )
-    fe.write_file
-
-    Chef::Config[:allowed_normal_attributes] = whitelist
-    Chef::Config[:normal_attribute_allowlist] = whitelist
-  end
-  not_if do
-    whitelist = YAML.load_file("/etc/chef/chef_normal_attributes.yml")
-    client_rb = ::File.read("/etc/chef/client.rb")
-    whitelist.all? { |attr| client_rb.include?(attr) }
-  end
-end
-
 directory "/etc/apt/keyrings" do
   mode "0755"
   action :create