kosmos/chef
kosmos/chef
8
3
Fork 0
Code Issues 28 Pull Requests 4 Projects 2 Activity

Add recipe to set up PostgreSQL replication, rewrite kosmos-postgresql cookbook #163

Manually merged
raucao merged 17 commits from feature/160-postgres_replication into master 2020-05-14 13:10:37 +00:00
Conversation 3 Commits 17 Files Changed 24 +510 -91
greg commented 2020-05-11 16:31:45 +00:00
Owner
Copy Link

See the README in the kosmos-postgresql cookbook (site-cookbooks/kosmos-postgresql/README.md) for docs about the custom resource. For replication, Chef needs to run once on the replica, then once on the primary to set up the access rules, and then a second time on the replica

Also upgrade PostgreSQL from 10 to 12 (10 is the version running on andromeda right now)

Refs #160

See the README in the kosmos-postgresql cookbook (`site-cookbooks/kosmos-postgresql/README.md`) for docs about the custom resource. For replication, Chef needs to run once on the replica, then once on the primary to set up the access rules, and then a second time on the replica Also upgrade PostgreSQL from 10 to 12 (10 is the version running on andromeda right now) Refs #160
raucao reviewed 2020-05-12 09:12:41 +00:00
raucao left a comment
Owner
Copy Link

I glanced over everything and added a few comments to the mentioned README.

I glanced over everything and added a few comments to the mentioned README.
site-cookbooks/kosmos-postgresql/README.md Outdated
@ -3,2 +3,3 @@
TODO: Enter the cookbook description here.
## Custom resources
### `postgresql_custom_server`
raucao commented 2020-05-12 09:07:08 +00:00
Owner
Copy Link

What's "custom" about these servers? If "custom" merely means that it's going to be configured for our use case, then isn't that the case for literally every other server, too?

What's "custom" about these servers? If "custom" merely means that it's going to be configured for our use case, then isn't that the case for literally every other server, too?
greg commented 2020-05-12 13:59:32 +00:00
Author
Owner
Copy Link

They're Chef custom resources (https://docs.chef.io/custom_resources/), the concept that replaces LWRP (https://chef.readthedocs.io/en/latest/lwrps_custom.html)

They're Chef custom resources (https://docs.chef.io/custom_resources/), the concept that replaces LWRP (https://chef.readthedocs.io/en/latest/lwrps_custom.html)
site-cookbooks/kosmos-postgresql/README.md Outdated
@ -5,0 +24,4 @@
```ruby
postgresql_custom_server "12" do
role "primary"
raucao commented 2020-05-12 09:06:24 +00:00
Owner
Copy Link

The replica also needs to have "primary" as role?

The replica also needs to have "primary" as role?
greg commented 2020-05-12 14:07:34 +00:00
Author
Owner
Copy Link

Thanks, I've pushed a fix for the typo

Thanks, I've pushed a fix for the typo
site-cookbooks/kosmos-postgresql/README.md Outdated
@ -5,0 +38,4 @@
[`firewall_rules`](https://github.com/chef-cookbooks/firewall/issues/134) and
[`postgresql_access`](https://github.com/sous-chefs/postgresql/issues/648) need
to be declared in recipes, not resources because of the way custom resources
work currently in Chef
raucao commented 2020-05-12 09:08:32 +00:00
Owner
Copy Link

Which rules are needed? How are they declared? I believe this README would not answer these questions for someone trying to use it.

Which rules are needed? How are they declared? I believe this README would not answer these questions for someone trying to use it.
greg changed title from Add recipe to set up PostgreSQL replication, rewrite kosmos-postgresql cookbook to WIP: Add recipe to set up PostgreSQL replication, rewrite kosmos-postgresql cookbook 2020-05-12 09:52:30 +00:00
greg changed title from WIP: Add recipe to set up PostgreSQL replication, rewrite kosmos-postgresql cookbook to Add recipe to set up PostgreSQL replication, rewrite kosmos-postgresql cookbook 2020-05-14 07:03:02 +00:00
raucao reviewed 2020-05-14 11:02:27 +00:00
raucao left a comment
Owner
Copy Link

Left a couple of comments/questions.

Left a couple of comments/questions.
site-cookbooks/kosmos-postgresql/README.md
@ -5,0 +57,4 @@
the PostgreSQL server.
The root certificate needs to be deployed to clients so they verify the cert
can be trusted.
raucao commented 2020-05-14 10:59:05 +00:00
Owner
Copy Link

I don't see where that's done in this PR?

I don't see where that's done in this PR?
greg commented 2020-05-14 11:11:32 +00:00
Author
Owner
Copy Link

I forgot to remove that part from the README, as we said in #160 that we don't care about verifying the root cert. It would be done in the cookbooks for software that connects to PostgreSQL (together with creating databases) and not in this cookbook

I forgot to remove that part from the README, as we said in #160 that we don't care about verifying the root cert. It would be done in the cookbooks for software that connects to PostgreSQL (together with creating databases) and not in this cookbook
site-cookbooks/kosmos-postgresql/recipes/default.rb
@ -51,1 +73,4 @@
end
# TODO: We need to set up firewall rules and access rules for clients too
# (Mastodon, ejabberd, etc)
raucao commented 2020-05-14 10:57:22 +00:00
Owner
Copy Link

What does this mean? Why would they use a different port to connect to Postgres?

What does this mean? Why would they use a different port to connect to Postgres?
greg commented 2020-05-14 11:13:54 +00:00
Author
Owner
Copy Link

I'm removing that line, this will be done as part of the Mastodon, ejabberd, gitea cookbooks. They wouldn't use a different port, but clients still need access for the specific database, user and IP (https://www.postgresql.org/docs/12/auth-pg-hba-conf.html)

I'm removing that line, this will be done as part of the Mastodon, ejabberd, gitea cookbooks. They wouldn't use a different port, but clients still need access for the specific database, user and IP (https://www.postgresql.org/docs/12/auth-pg-hba-conf.html)
raucao approved these changes 2020-05-14 12:15:03 +00:00
raucao closed this pull request 2020-05-14 13:10:37 +00:00
raucao closed this pull request 2020-05-14 13:10:37 +00:00
raucao deleted branch feature/160-postgres_replication 2020-05-14 13:10:46 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
Labels
Clear labels
service
accounts
Kosmos Accounts
service
discourse
Kosmos Community Forums
service
drone-ci
Kosmos Drone CI
service
email
mail.kosmos.org
service
garage
S3-compatible object storage
service
gitea
Kosmos Gitea
service
ipfs
Kosmos IPFS
service
mastodon
kosmos.social
service
postgres
Database cluster
service
remotestorage
Portable data storage for the Web
service
wiki
Kosmos Wiki
service
xmpp
Kosmos Chat
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/chef#163
No description provided.
Delete Branch "feature/160-postgres_replication"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?