kosmos/chef
8
3
Fork 0
Code Issues 38 Pull Requests Projects 2 Activity

Update Chef to 14.11.21 #27

Merged
greg merged 44 commits from chef_14 into master 2019-04-12 11:31:37 +00:00
Conversation 8 Commits 44 Files Changed 80
+1209 -553
greg commented 2019-04-10 09:27:02 +00:00
Owner
Copy Link
Copy Source

This needed more changes than I thought. The new mediawiki cookbook is running on andromeda. sockethub is also running on andromeda, but the sockethub.kosmos.org DNS entry still points to dev because I had to update it to 3.0.1 for it to run on Node 10 and it is missing a non-minified version of activity streams (https://github.com/sockethub/sockethub/issues/237)

I'm going to commit my changes to the mastodon cookbook next, I'm running it from scratch in a VM again after changes to the postgresql credentials required by the upstream cookbook update

Refs #12

This needed more changes than I thought. The new mediawiki cookbook is running on andromeda. sockethub is also running on andromeda, but the sockethub.kosmos.org DNS entry still points to dev because I had to update it to 3.0.1 for it to run on Node 10 and it is missing a non-minified version of activity streams (https://github.com/sockethub/sockethub/issues/237) I'm going to commit my changes to the mastodon cookbook next, I'm running it from scratch in a VM again after changes to the postgresql credentials required by the upstream cookbook update Refs #12
greg marked the pull request as ready for review 2019-04-10 09:52:09 +00:00
greg commented 2019-04-10 09:53:19 +00:00
Author
Owner
Copy Link
Copy Source

I think this is good to go now

The updated kosmos-mediawiki and sockethub cookbooks are already running on andromeda (updated node in the nodes directory)

I think this is good to go now The updated kosmos-mediawiki and sockethub cookbooks are already running on andromeda (updated node in the `nodes` directory)
raucao commented 2019-04-10 09:54:30 +00:00
Owner
Copy Link
Copy Source

So this branch also works with dev.kosmos.org, yes? (That's where our chat bots are currently deployed.)

So this branch also works with `dev.kosmos.org`, yes? (That's where our chat bots are currently deployed.)
greg commented 2019-04-10 14:21:58 +00:00
Author
Owner
Copy Link
Copy Source

Executed on dev.kosmos.org, can be merged!

Executed on dev.kosmos.org, can be merged!
greg marked the pull request as work in progress 2019-04-10 14:35:55 +00:00
greg commented 2019-04-10 14:36:24 +00:00
Author
Owner
Copy Link
Copy Source

I found one last issue (a variable wasn't set in the mastodon cookbook), on it

I found one last issue (a variable wasn't set in the mastodon cookbook), on it
greg marked the pull request as ready for review 2019-04-10 14:43:23 +00:00
greg commented 2019-04-11 09:40:36 +00:00
Author
Owner
Copy Link
Copy Source

Any objection to merging? I ran it on dev yesterday

Any objection to merging? I ran it on dev yesterday
greg commented 2019-04-11 16:24:53 +00:00
Author
Owner
Copy Link
Copy Source

I have deleted the vendored cookbooks in master and merged master into this branch, now it's not too many changes to review

I have deleted the vendored cookbooks in master and merged master into this branch, now it's not too many changes to review
👍 1
raucao approved these changes 2019-04-12 08:27:10 +00:00
raucao left a comment
Owner
Copy Link
Copy Source

Code looks all good to me. Mostly commented on wrong license.

Code looks all good to me. Mostly commented on wrong license.
site-cookbooks/kosmos-base/recipes/chef_client.rb Outdated
@@ -0,0 +4,4 @@
#
# Copyright 2019, Kosmos
#
# All rights reserved - Do Not Redistribute
raucao commented 2019-04-12 08:05:31 +00:00
Owner
Copy Link
Copy Source

We only release open-source software for everything in the Kosmos org.

We only release open-source software for everything in the Kosmos org.
site-cookbooks/kosmos-mastodon/templates/default/env.production.erb Outdated
@@ -3,3 +3,3 @@
DB_HOST=localhost
DB_USER=postgres
DB_NAME=mastodon
# Remove the condition once we have migrated mastodon to andromeda
raucao commented 2019-04-12 08:22:28 +00:00
Owner
Copy Link
Copy Source

Would be easier to find with TODO prefix.

Would be easier to find with TODO prefix.
site-cookbooks/kosmos-postgresql/CHANGELOG.md
@@ -0,0 +7,4 @@
Initial release.
- change 0
- change 1
raucao commented 2019-04-12 08:25:27 +00:00
Owner
Copy Link
Copy Source

This looks like unchanged template stuff.

This looks like unchanged template stuff.
site-cookbooks/kosmos-postgresql/LICENSE Outdated
@@ -0,0 +1,3 @@
Copyright 2019 Kosmos
All rights reserved, do not redistribute.
raucao commented 2019-04-12 08:25:09 +00:00
Owner
Copy Link
Copy Source

Same as above.

Same as above.
site-cookbooks/kosmos-postgresql/metadata.rb
@@ -0,0 +1,23 @@
name 'kosmos-postgresql'
maintainer 'Kosmos'
maintainer_email 'ops@5apps.com'
license 'All Rights Reserved'
raucao commented 2019-04-12 08:26:00 +00:00
Owner
Copy Link
Copy Source

And another one.

And another one.
site-cookbooks/sockethub/recipes/_firewall.rb
@@ -0,0 +4,4 @@
#
# Copyright 2015-2019, Kosmos
#
# All rights reserved - Do Not Redistribute
raucao commented 2019-04-12 08:26:41 +00:00
Owner
Copy Link
Copy Source

And one more.

And one more.
greg commented 2019-04-12 09:44:49 +00:00
Author
Owner
Copy Link
Copy Source

Addressed in e65374c893, 57d0885d26 and cd00f4c049

Addressed in e65374c893, 57d0885d26 and cd00f4c049
greg closed this pull request 2019-04-12 11:31:37 +00:00
greg deleted branch chef_14 2019-04-12 11:31:51 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
Labels
Clear labels
service
discourse
Kosmos Community Forums
monitoring
Infrastructure metrics, alerts, notifications, etc.
service
accounts
Kosmos Accounts
service
drone-ci
Kosmos Drone CI
service
email
mail.kosmos.org
service
garage
S3-compatible object storage
service
gitea
Kosmos Gitea
service
ipfs
Kosmos IPFS
service
mastodon
kosmos.social
service
nostr
Relays, Blossom server, etc.
service
postgres
Database cluster
service
remotestorage
Portable data storage for the Web
service
wiki
Kosmos Wiki
service
xmpp
Kosmos Chat
bug
Something is not working
 design
Graphic/visual design
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 good first issue
Dive in, and start contributing
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 on hold
Currently not actionable
 ops
Manual IT ops activities
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/chef#27