I had a look at this just now: normal static assets, like CSS files etc. carry expires and last-modified headers to at least cache them for 24 hours (albeit no ETAGs).
Other uploaded custom files, e.g. file attachments, come with a cache-control: public,max-age=86400, which also does what it's supposed to.
However, uploaded avatars specifically, both user/org and repo ones (which live in two different folders on the disk), are missing any and all caching headers.
So I think this should be fixed in Gitea itself. Otherwise we'll have to change permissions on the uploaded avatars, or add the nginx user to the git group, which seems like a bad idea to me.
I missed the obvious choice of using a regex location directive for adding custom caching headers for anything in the avatar folders. See PR.
I had a look at this just now: normal static assets, like CSS files etc. carry `expires` and `last-modified` headers to at least cache them for 24 hours (albeit no ETAGs).
Other uploaded custom files, e.g. file attachments, come with a `cache-control: public,max-age=86400`, which also does what it's supposed to.
However, uploaded avatars specifically, both user/org and repo ones (which live in two different folders on the disk), are missing any and all caching headers.
<strike>So I think this should be fixed in Gitea itself. Otherwise we'll have to change permissions on the uploaded avatars, or add the nginx user to the `git` group, which seems like a bad idea to me.</strike>
I missed the obvious choice of using a regex location directive for adding custom caching headers for anything in the avatar folders. See PR.
raucao
changed title from Gitea's static assets like avatars not cached to Gitea's avatar images are missing caching headers2021-02-26 18:59:36 +00:00
raucao
added the bug label 2021-02-26 18:59:48 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Whenever I load a page on gitea.kosmos.org, it loads all images anew. Seems like the nginx host is missing config for static assets.
I had a look at this just now: normal static assets, like CSS files etc. carry
expiresandlast-modifiedheaders to at least cache them for 24 hours (albeit no ETAGs).Other uploaded custom files, e.g. file attachments, come with a
cache-control: public,max-age=86400, which also does what it's supposed to.However, uploaded avatars specifically, both user/org and repo ones (which live in two different folders on the disk), are missing any and all caching headers.
So I think this should be fixed in Gitea itself. Otherwise we'll have to change permissions on the uploaded avatars, or add the nginx user to thegitgroup, which seems like a bad idea to me.I missed the obvious choice of using a regex location directive for adding custom caching headers for anything in the avatar folders. See PR.
Gitea's static assets like avatars not cachedto Gitea's avatar images are missing caching headers