Gitea's avatar images are missing caching headers #312
Labels
No Label
service
accounts
service
discourse
service
drone-ci
service
email
service
garage
service
gitea
service
ipfs
service
mastodon
service
postgres
service
remotestorage
service
wiki
service
xmpp
bug
design
dev environment
docs
duplicate
enhancement
feature
good first issue
idea
invalid
kredits-1
kredits-2
kredits-3
on hold
ops
question
release
major
release
minor
release
patch
security
ui/ux
wontfix
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: kosmos/chef#312
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Whenever I load a page on gitea.kosmos.org, it loads all images anew. Seems like the nginx host is missing config for static assets.
I had a look at this just now: normal static assets, like CSS files etc. carry
expires
andlast-modified
headers to at least cache them for 24 hours (albeit no ETAGs).Other uploaded custom files, e.g. file attachments, come with a
cache-control: public,max-age=86400
, which also does what it's supposed to.However, uploaded avatars specifically, both user/org and repo ones (which live in two different folders on the disk), are missing any and all caching headers.
So I think this should be fixed in Gitea itself. Otherwise we'll have to change permissions on the uploaded avatars, or add the nginx user to thegit
group, which seems like a bad idea to me.I missed the obvious choice of using a regex location directive for adding custom caching headers for anything in the avatar folders. See PR.
Gitea's static assets like avatars not cachedto Gitea's avatar images are missing caching headers