Use Chef Workstation's ruby with rbenv #324

2021-05-28T12:46:21Z

raucao commented

2021-05-28 12:46:21 +00:00

The proper way to install Chef, knife, etc. these days is with Chef Workstation.

This adds a local rbenv config for using the bundled workstation ruby in the Chef repo by default. There's a rbenv plugin for this: rbenv-chef-workstation

It also removes the strict bundler version requirement in Gemfile.lock, so you can use both newer and older versions of bundler if you want/need.

The proper way to install Chef, knife, etc. these days is with [Chef Workstation](https://docs.chef.io/workstation/). This adds a local rbenv config for using the bundled workstation ruby in the Chef repo by default. There's a rbenv plugin for this: [rbenv-chef-workstation](https://github.com/docwhat/rbenv-chef-workstation) It also removes the strict bundler version requirement in `Gemfile.lock`, so you can use both newer and older versions of bundler if you want/need.

raucao added the enhancement kredits-1 labels 2021-05-28 12:46:21 +00:00

raucao added 2 commits 2021-05-28 12:46:21 +00:00

Don't require old bundler version 6bd76ebec6

Use chef-workstation Ruby with rbenv ec75f1446c

See https://github.com/docwhat/rbenv-chef-workstation for painlessly
using Chef Workstation's Ruby with rbenv.

raucao added 1 commit 2021-05-28 12:51:58 +00:00

Update README bda100313e

Add some info about Chef Workstation and rbenv.

raucao requested review from greg 2021-05-30 17:34:49 +00:00

raucao commented

2021-06-10 13:17:17 +00:00

@greg Want to have a quick look at this?

greg commented

2021-06-10 14:27:17 +00:00

@greg Want to have a quick look at this?

Sure, I will after the call

> @greg Want to have a quick look at this? Sure, I will after the call

greg commented

2021-06-10 16:11:20 +00:00

The changes look good to me but I'm using chruby so I need to find a way to make knife plugins work, with the new setup things like knife-zero don't work when I'm running knife from Chef Workstation. I'll take a closer look tomorrow

The changes look good to me but I'm using [chruby](https://github.com/postmodern/chruby) so I need to find a way to make knife plugins work, with the new setup things like knife-zero don't work when I'm running knife from Chef Workstation. I'll take a closer look tomorrow

greg commented

2021-06-11 08:28:53 +00:00

I think our Gemfile should only contain knife-zero if we use Chef Workstation (everything else is already part of it)

chruby's definitely not playing nice with Chef Workstation, even installing a gem directly with /opt/chef-workstation/embedded/bin/gem install knife-zero ends up with the gem not being installed in the right path. I think I will end up switching to rbenv to work around this issue, because chruby doesn't appear to have a plugin system, and rbenv-chef-workstation's README mentions a bunch of PATH issues that breaks things in subtle ways.

I think our `Gemfile` should only contain `knife-zero` if we use Chef Workstation (everything else is already part of it) chruby's definitely not playing nice with Chef Workstation, even installing a gem directly with `/opt/chef-workstation/embedded/bin/gem install knife-zero` ends up with the gem not being installed in the right path. I think I will end up switching to rbenv to work around this issue, because chruby doesn't appear to have a plugin system, and [rbenv-chef-workstation's README](https://github.com/docwhat/rbenv-chef-workstation) mentions a bunch of PATH issues that breaks things in subtle ways.

👍 1

greg commented

2021-06-11 08:31:47 +00:00

@raucao I forgot to ask, did you check that knife-zero works for you with this setup?

@raucao I forgot to ask, did you check that `knife-zero` works for you with this setup?

raucao commented

2021-06-11 08:36:55 +00:00

@raucao I forgot to ask, did you check that knife-zero works for you with this setup?

Yes, of course.

> @raucao I forgot to ask, did you check that knife-zero works for you with this setup? Yes, of course.

raucao commented

2021-06-14 10:15:02 +00:00

I have a new PR for the RSK cookbook incoming, but it's based on this branch. Would be great if we can merge it soon...

greg added 1 commit 2021-06-15 20:21:44 +00:00

Only keep the knife-zero gem in the Gemfile 9a3565c11f

The rest is already shipped with Chef Workstation

greg approved these changes 2021-06-15 20:26:12 +00:00

greg left a comment

👍

greg merged commit 5bc4266857 into master

2021-06-15 20:26:23 +00:00

greg referenced this issue from a commit

2021-06-15 20:26:23 +00:00

Merge pull request 'Use Chef Workstation's ruby with rbenv' (#324) from chore/remove_bundler_version_lock into master

greg deleted branch chore/remove_bundler_version_lock

2021-06-15 20:26:30 +00:00

raucao commented

2021-06-16 08:23:48 +00:00

@greg Just for future use: when you add commits to a PR, especially when it's a kredits-1, you can add yourself to the assigned-people list, so you also get a full small contrib kredited.

@greg Just for future use: when you add commits to a PR, especially when it's a `kredits-1`, you can add yourself to the assigned-people list, so you also get a full small contrib kredited.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kosmos/chef#324