kosmos/chef
kosmos/chef
8
3
Fork 0
Code Issues 30 Pull Requests 3 Projects 2 Activity

Use Chef Workstation's ruby with rbenv #324

Merged
greg merged 4 commits from chore/remove_bundler_version_lock into master 2021-06-15 20:26:23 +00:00
Conversation 9 Commits 4 Files Changed 4 +189 -183
raucao commented 2021-05-28 12:46:21 +00:00
Owner
Copy Link

The proper way to install Chef, knife, etc. these days is with Chef Workstation.

This adds a local rbenv config for using the bundled workstation ruby in the Chef repo by default. There's a rbenv plugin for this: rbenv-chef-workstation

It also removes the strict bundler version requirement in Gemfile.lock, so you can use both newer and older versions of bundler if you want/need.

The proper way to install Chef, knife, etc. these days is with [Chef Workstation](https://docs.chef.io/workstation/). This adds a local rbenv config for using the bundled workstation ruby in the Chef repo by default. There's a rbenv plugin for this: [rbenv-chef-workstation](https://github.com/docwhat/rbenv-chef-workstation) It also removes the strict bundler version requirement in `Gemfile.lock`, so you can use both newer and older versions of bundler if you want/need.
raucao added the
enhancement
kredits-1
 labels 2021-05-28 12:46:21 +00:00
raucao added 2 commits 2021-05-28 12:46:21 +00:00 
See https://github.com/docwhat/rbenv-chef-workstation for painlessly
using Chef Workstation's Ruby with rbenv.
raucao added 1 commit 2021-05-28 12:51:58 +00:00 
Add some info about Chef Workstation and rbenv.
raucao requested review from greg 2021-05-30 17:34:49 +00:00
raucao commented 2021-06-10 13:17:17 +00:00
Author
Owner
Copy Link

@greg Want to have a quick look at this?

@greg Want to have a quick look at this?
greg commented 2021-06-10 14:27:17 +00:00
Owner
Copy Link

@greg Want to have a quick look at this?

Sure, I will after the call

> @greg Want to have a quick look at this? Sure, I will after the call
greg commented 2021-06-10 16:11:20 +00:00
Owner
Copy Link

The changes look good to me but I'm using chruby so I need to find a way to make knife plugins work, with the new setup things like knife-zero don't work when I'm running knife from Chef Workstation. I'll take a closer look tomorrow

The changes look good to me but I'm using [chruby](https://github.com/postmodern/chruby) so I need to find a way to make knife plugins work, with the new setup things like knife-zero don't work when I'm running knife from Chef Workstation. I'll take a closer look tomorrow
greg commented 2021-06-11 08:28:53 +00:00
Owner
Copy Link

I think our Gemfile should only contain knife-zero if we use Chef Workstation (everything else is already part of it)

chruby's definitely not playing nice with Chef Workstation, even installing a gem directly with /opt/chef-workstation/embedded/bin/gem install knife-zero ends up with the gem not being installed in the right path. I think I will end up switching to rbenv to work around this issue, because chruby doesn't appear to have a plugin system, and rbenv-chef-workstation's README mentions a bunch of PATH issues that breaks things in subtle ways.

I think our `Gemfile` should only contain `knife-zero` if we use Chef Workstation (everything else is already part of it) chruby's definitely not playing nice with Chef Workstation, even installing a gem directly with `/opt/chef-workstation/embedded/bin/gem install knife-zero` ends up with the gem not being installed in the right path. I think I will end up switching to rbenv to work around this issue, because chruby doesn't appear to have a plugin system, and [rbenv-chef-workstation's README](https://github.com/docwhat/rbenv-chef-workstation) mentions a bunch of PATH issues that breaks things in subtle ways.
👍 1
greg commented 2021-06-11 08:31:47 +00:00
Owner
Copy Link

@raucao I forgot to ask, did you check that knife-zero works for you with this setup?

@raucao I forgot to ask, did you check that `knife-zero` works for you with this setup?
raucao commented 2021-06-11 08:36:55 +00:00
Author
Owner
Copy Link

@raucao I forgot to ask, did you check that knife-zero works for you with this setup?

Yes, of course.

> @raucao I forgot to ask, did you check that knife-zero works for you with this setup? Yes, of course.
raucao commented 2021-06-14 10:15:02 +00:00
Author
Owner
Copy Link

I have a new PR for the RSK cookbook incoming, but it's based on this branch. Would be great if we can merge it soon...

I have a new PR for the RSK cookbook incoming, but it's based on this branch. Would be great if we can merge it soon...
greg added 1 commit 2021-06-15 20:21:44 +00:00 
The rest is already shipped with Chef Workstation
greg approved these changes 2021-06-15 20:26:12 +00:00
greg left a comment
Owner
Copy Link

👍

👍
greg merged commit 5bc4266857 into master 2021-06-15 20:26:23 +00:00
greg deleted branch chore/remove_bundler_version_lock 2021-06-15 20:26:30 +00:00
raucao commented 2021-06-16 08:23:48 +00:00
Author
Owner
Copy Link

@greg Just for future use: when you add commits to a PR, especially when it's a kredits-1, you can add yourself to the assigned-people list, so you also get a full small contrib kredited.

@greg Just for future use: when you add commits to a PR, especially when it's a `kredits-1`, you can add yourself to the assigned-people list, so you also get a full small contrib kredited.
Sign in to join this conversation.
Reviewers
No Reviewers
greg
Labels
Clear labels
service
accounts
Kosmos Accounts
service
discourse
Kosmos Community Forums
service
drone-ci
Kosmos Drone CI
service
email
mail.kosmos.org
service
garage
S3-compatible object storage
service
gitea
Kosmos Gitea
service
ipfs
Kosmos IPFS
service
mastodon
kosmos.social
service
postgres
Database cluster
service
remotestorage
Portable data storage for the Web
service
wiki
Kosmos Wiki
service
xmpp
Kosmos Chat
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
enhancement
kredits-1
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/chef#324
No description provided.
Delete Branch "chore/remove_bundler_version_lock"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?