kosmos/chef
kosmos/chef
8
3
Fork 0
Code Issues 28 Pull Requests 4 Projects 2 Activity

Opt-out of dotnet telemetry for btcpay #599

Merged
greg merged 5 commits from feature/441-optout_dotnet_telemetry into master 2025-06-25 10:01:59 +00:00
Conversation 7 Commits 5 Files Changed 1 +4 -1
greg commented 2025-06-24 14:59:42 +00:00
Owner
Copy Link

This is done by setting an environment variable in the systemd unit

Fixes #441

This is done by setting an environment variable in the systemd unit Fixes #441
greg added the
enhancement
kredits-1
 labels 2025-06-24 14:59:42 +00:00
greg added 1 commit 2025-06-24 14:59:43 +00:00 
This is done by setting an environment variable in the systemd unit

Fixes #441
greg requested review from raucao 2025-06-24 14:59:43 +00:00
greg commented 2025-06-24 15:20:12 +00:00
Author
Owner
Copy Link

Is btcpay safe to restart? I haven't done a Chef run yet

Is btcpay safe to restart? I haven't done a Chef run yet
raucao reviewed 2025-06-24 19:01:24 +00:00
site-cookbooks/kosmos-bitcoin/recipes/btcpay.rb Outdated
@ -75,2 +75,4 @@
end
systemd_unit_env = "'DOTNET_CLI_TELEMETRY_OPTOUT=1'"
systemd_unit_env << " 'BTCPAY_EXPLORERPOSTGRES=#{nbxpg_connect}'" if defined?(nbxpg_connect)
raucao commented 2025-06-24 19:01:24 +00:00
Owner
Copy Link

This should fail if it's not defined, since you need the explorer to run the service. (I.e. just remove the if.)

This should fail if it's not defined, since you need the explorer to run the service. (I.e. just remove the `if`.)
greg marked this conversation as resolved
raucao commented 2025-06-24 19:02:20 +00:00
Owner
Copy Link

Yep, safe to restart anytime.

Yep, safe to restart anytime.
greg added 1 commit 2025-06-25 07:53:51 +00:00 
Also move back the environment variable definitions to the hash
greg added 1 commit 2025-06-25 08:14:01 +00:00 
It cannot handle reloads
greg commented 2025-06-25 08:15:24 +00:00
Author
Owner
Copy Link

I ran this on bitcoin-2, this is now ready to review (addressed your comment and fixed the restart of the service/systemd unit) and merge

I ran this on bitcoin-2, this is now ready to review (addressed your comment and fixed the restart of the service/systemd unit) and merge
raucao commented 2025-06-25 08:18:39 +00:00
Owner
Copy Link

Do we also need this for the builds, since those are dotnet CLI operations, too?

Do we also need this for the builds, since those are dotnet CLI operations, too?
greg added 1 commit 2025-06-25 08:19:18 +00:00
greg added 1 commit 2025-06-25 08:35:42 +00:00
greg commented 2025-06-25 08:36:44 +00:00
Author
Owner
Copy Link

Do we also need this for the builds, since those are dotnet CLI operations, too?

Good catch, I've just pushed the addition of the environment variable during the build

> Do we also need this for the builds, since those are dotnet CLI operations, too? Good catch, I've just pushed the addition of the environment variable during the build
raucao approved these changes 2025-06-25 09:59:12 +00:00
raucao left a comment
Owner
Copy Link

Looks good.👍

Looks good.👍
greg merged commit 8052c67d23 into master 2025-06-25 10:01:59 +00:00
greg deleted branch feature/441-optout_dotnet_telemetry 2025-06-25 10:01:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
Labels
Clear labels
service
accounts
Kosmos Accounts
service
discourse
Kosmos Community Forums
service
drone-ci
Kosmos Drone CI
service
email
mail.kosmos.org
service
garage
S3-compatible object storage
service
gitea
Kosmos Gitea
service
ipfs
Kosmos IPFS
service
mastodon
kosmos.social
service
postgres
Database cluster
service
remotestorage
Portable data storage for the Web
service
wiki
Kosmos Wiki
service
xmpp
Kosmos Chat
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
enhancement
kredits-1
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/chef#599
No description provided.
Delete Branch "feature/441-optout_dotnet_telemetry"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?