kosmos/chef
8
3
Fork 0
Code Issues 38 Pull Requests Projects 2 Activity

Make create_vm work on all OS versions in use #653

Merged
raucao merged 2 commits from bugfix/create_vm into master 2026-07-24 17:14:45 +00:00
Conversation 2 Commits 2 Files Changed 2
+37 -1
raucao commented 2026-07-24 13:26:11 +00:00
Owner
Copy Link
Copy Source

Makes it work with the same cloudinit code on Ubuntu 20.04 by mounting it from a custom ISO as CD-ROM.

Tested/running on:

  • draco (20.04)
  • fornax (20.04)
  • her (22.04)
  • leo (24.04)
Makes it work with the same cloudinit code on Ubuntu 20.04 by mounting it from a custom ISO as CD-ROM. Tested/running on: * [x] draco (20.04) * [x] fornax (20.04) * [x] her (22.04) * [x] leo (24.04)
raucao added the enhancementbugkredits-1ops labels 2026-07-24 13:26:11 +00:00
raucao added 1 commit 2026-07-24 13:26:12 +00:00
Make create_vm work on all OS versions in use 7386de86d7 
Makes it work with the same cloudinit code on Ubuntu 20.04 by mounting
it from a custom ISO as CD-ROM
raucao marked the pull request as work in progress 2026-07-24 13:26:21 +00:00
raucao added 1 commit 2026-07-24 13:27:35 +00:00
Merge branch 'master' into bugfix/create_vm 16cb333991
raucao marked the pull request as ready for review 2026-07-24 14:31:30 +00:00
greg requested changes 2026-07-24 16:08:53 +00:00
Dismissed
greg left a comment
Owner
Copy Link
Copy Source

I asked a question about the create_vm template

I asked a question about the create_vm template
site-cookbooks/kosmos_kvm/templates/create_vm.erb
@@ -83,3 +84,30 @@ virt-install \
--autostart \
--import \
--cloud-init root-password-generate=off,disable=on,meta-data=$CIDATA_PATH/meta-data,user-data=$CIDATA_PATH/user-data
<% else -%>
greg commented 2026-07-24 16:08:10 +00:00
Owner
Copy Link
Copy Source

I wonder if it wouldn't be better to avoid duplicating all these arguments, only add --osinfo and --cloud-init on modern Ubuntu and add a conditional cloud-localds command before it for legacy? Other than that looks good to me

I wonder if it wouldn't be better to avoid duplicating all these arguments, only add `--osinfo` and `--cloud-init` on modern Ubuntu and add a conditional `cloud-localds` command before it for legacy? Other than that looks good to me
raucao commented 2026-07-24 16:45:41 +00:00
Author
Owner
Copy Link
Copy Source

I like the clarity of having explicit commands there. Also, they're slightly different arguments.

I like the clarity of having explicit commands there. Also, they're slightly different arguments.
greg marked this conversation as resolved
greg approved these changes 2026-07-24 16:49:44 +00:00
greg left a comment
Owner
Copy Link
Copy Source

👍

👍
raucao merged commit d9a59e064e into master 2026-07-24 17:14:45 +00:00
raucao deleted branch bugfix/create_vm 2026-07-24 17:14:45 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
greg
Labels
Clear labels
service
discourse
Kosmos Community Forums
monitoring
Infrastructure metrics, alerts, notifications, etc.
service
accounts
Kosmos Accounts
service
drone-ci
Kosmos Drone CI
service
email
mail.kosmos.org
service
garage
S3-compatible object storage
service
gitea
Kosmos Gitea
service
ipfs
Kosmos IPFS
service
mastodon
kosmos.social
service
nostr
Relays, Blossom server, etc.
service
postgres
Database cluster
service
remotestorage
Portable data storage for the Web
service
wiki
Kosmos Wiki
service
xmpp
Kosmos Chat
bug
Something is not working
 design
Graphic/visual design
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 good first issue
Dive in, and start contributing
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 on hold
Currently not actionable
 ops
Manual IT ops activities
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label bug enhancement kredits-1 ops
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/chef#653
Delete Branch "bugfix/create_vm"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?