kosmos/chef
kosmos/chef
8
3
Fork 0
Code Issues 30 Pull Requests 3 Projects 2 Activity

Script creating new VMs #252

Merged
raucao merged 16 commits from feature/244-new_vm_script into master 2020-12-09 15:33:08 +00:00
Conversation 4 Commits 16 Files Changed 40 +10 -5
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 94a34e4758 - Show all commits

15
site-cookbooks/kosmos_kvm/files/create_vm
View File

@ -1,12 +1,17 @@
#!/bin/bash #!/bin/bash
set -e set -e
if [[ $# -eq 0 ]] ; then if [[ $# -lt 3 ]] ; then
echo 'USAGE: create_vm VMNAME' cat <<-EOF
USAGE (RAM in megabytes)
raucao commented 2020-12-07 15:12:34 +00:00
Outdated
Review
Copy Link

This doesn't look right to me. It would attempt to download the path as a second file, no? The pathname should come after the -o flag.

However, why not just use a normal file download resource in the KVM host recipe in the first place? Same amount of characters as this extended comment, but then it's automated and handles existing files.

This doesn't look right to me. It would attempt to download the path as a second file, no? The pathname should come after the `-o` flag. However, why not just use a normal file download resource in the KVM host recipe in the first place? Same amount of characters as this extended comment, but then it's automated and handles existing files.
create_vm VMNAME RAM CPUS
EOF
exit 1 exit 1
fi fi
VMNAME=$1 VMNAME=$1
RAM=$2
CPUS=$3
# Directory where image files will be stored # Directory where image files will be stored
IMAGE_DIR=/var/lib/libvirt/images IMAGE_DIR=/var/lib/libvirt/images
@ -67,8 +72,8 @@ fi
# setting --os-variant to ubuntu20.04 and ubuntu18.04 breaks SSH and networking # setting --os-variant to ubuntu20.04 and ubuntu18.04 breaks SSH and networking
virt-install \ virt-install \
--name cloudinit-1 \ --name cloudinit-1 \
--ram 2048 \ --ram "$RAM" \
--vcpus 1\ --vcpus "$CPUS" \
raucao commented 2020-12-07 15:02:49 +00:00
Outdated
Review
Copy Link

We won't want to edit the script on the host all the time, so why not simply:

  --ram $2 \
  --vcpus $3 \
We won't want to edit the script on the host all the time, so why not simply: ```bash --ram $2 \ --vcpus $3 \ ```
--cpu host \ --cpu host \
--arch x86_64 \ --arch x86_64 \
--os-type linux \ --os-type linux \