Merge branch 'master' into boostspin
This commit is contained in:
		
						commit
						4f3264d291
					
				| @ -80,7 +80,7 @@ export function fetchAccount(id) { | ||||
| 
 | ||||
| export function fetchAccountTimeline(id, replace = false) { | ||||
|   return (dispatch, getState) => { | ||||
|     const ids      = getState().getIn(['timelines', 'accounts_timelines', id], Immutable.List()); | ||||
|     const ids      = getState().getIn(['timelines', 'accounts_timelines', id, 'items'], Immutable.List()); | ||||
|     const newestId = ids.size > 0 ? ids.first() : null; | ||||
| 
 | ||||
|     let params = ''; | ||||
| @ -103,11 +103,16 @@ export function fetchAccountTimeline(id, replace = false) { | ||||
| 
 | ||||
| export function expandAccountTimeline(id) { | ||||
|   return (dispatch, getState) => { | ||||
|     const lastId = getState().getIn(['timelines', 'accounts_timelines', id], Immutable.List()).last(); | ||||
|     const lastId = getState().getIn(['timelines', 'accounts_timelines', id, 'items'], Immutable.List()).last(); | ||||
| 
 | ||||
|     dispatch(expandAccountTimelineRequest(id)); | ||||
| 
 | ||||
|     api(getState).get(`/api/v1/accounts/${id}/statuses?max_id=${lastId}`).then(response => { | ||||
|     api(getState).get(`/api/v1/accounts/${id}/statuses`, { | ||||
|       params: { | ||||
|         limit: 10, | ||||
|         max_id: lastId | ||||
|       } | ||||
|     }).then(response => { | ||||
|       dispatch(expandAccountTimelineSuccess(id, response.data)); | ||||
|     }).catch(error => { | ||||
|       dispatch(expandAccountTimelineFail(id, error)); | ||||
|  | ||||
| @ -9,7 +9,7 @@ export function fetchStatusCard(id) { | ||||
|     dispatch(fetchStatusCardRequest(id)); | ||||
| 
 | ||||
|     api(getState).get(`/api/v1/statuses/${id}/card`).then(response => { | ||||
|       if (!response.data.url) { | ||||
|       if (!response.data.url || !response.data.title || !response.data.description) { | ||||
|         return; | ||||
|       } | ||||
| 
 | ||||
|  | ||||
| @ -63,6 +63,10 @@ export function refreshTimelineRequest(timeline, id, skipLoading) { | ||||
| 
 | ||||
| export function refreshTimeline(timeline, id = null) { | ||||
|   return function (dispatch, getState) { | ||||
|     if (getState().getIn(['timelines', timeline, 'isLoading'])) { | ||||
|       return; | ||||
|     } | ||||
| 
 | ||||
|     const ids      = getState().getIn(['timelines', timeline, 'items'], Immutable.List()); | ||||
|     const newestId = ids.size > 0 ? ids.first() : null; | ||||
| 
 | ||||
| @ -102,8 +106,9 @@ export function expandTimeline(timeline, id = null) { | ||||
|   return (dispatch, getState) => { | ||||
|     const lastId = getState().getIn(['timelines', timeline, 'items'], Immutable.List()).last(); | ||||
| 
 | ||||
|     if (!lastId) { | ||||
|     if (!lastId || getState().getIn(['timelines', timeline, 'isLoading'])) { | ||||
|       // If timeline is empty, don't try to load older posts since there are none | ||||
|       // Also if already loading | ||||
|       return; | ||||
|     } | ||||
| 
 | ||||
| @ -115,7 +120,12 @@ export function expandTimeline(timeline, id = null) { | ||||
|       path = `${path}/${id}` | ||||
|     } | ||||
| 
 | ||||
|     api(getState).get(`/api/v1/timelines/${path}?max_id=${lastId}`).then(response => { | ||||
|     api(getState).get(`/api/v1/timelines/${path}`, { | ||||
|       params: { | ||||
|         limit: 10, | ||||
|         max_id: lastId | ||||
|       } | ||||
|     }).then(response => { | ||||
|       dispatch(expandTimelineSuccess(timeline, response.data)); | ||||
|     }).catch(error => { | ||||
|       dispatch(expandTimelineFail(timeline, error)); | ||||
|  | ||||
| @ -11,7 +11,8 @@ const StatusList = React.createClass({ | ||||
|     onScrollToBottom: React.PropTypes.func, | ||||
|     onScrollToTop: React.PropTypes.func, | ||||
|     onScroll: React.PropTypes.func, | ||||
|     trackScroll: React.PropTypes.bool | ||||
|     trackScroll: React.PropTypes.bool, | ||||
|     isLoading: React.PropTypes.bool | ||||
|   }, | ||||
| 
 | ||||
|   getDefaultProps () { | ||||
| @ -24,10 +25,10 @@ const StatusList = React.createClass({ | ||||
| 
 | ||||
|   handleScroll (e) { | ||||
|     const { scrollTop, scrollHeight, clientHeight } = e.target; | ||||
| 
 | ||||
|     const offset = scrollHeight - scrollTop - clientHeight; | ||||
|     this._oldScrollPosition = scrollHeight - scrollTop; | ||||
| 
 | ||||
|     if (scrollTop === scrollHeight - clientHeight && this.props.onScrollToBottom) { | ||||
|     if (250 > offset && this.props.onScrollToBottom && !this.props.isLoading) { | ||||
|       this.props.onScrollToBottom(); | ||||
|     } else if (scrollTop < 100 && this.props.onScrollToTop) { | ||||
|       this.props.onScrollToTop(); | ||||
| @ -36,21 +37,37 @@ const StatusList = React.createClass({ | ||||
|     } | ||||
|   }, | ||||
| 
 | ||||
|   componentDidUpdate (prevProps) { | ||||
|     if (prevProps.statusIds.size < this.props.statusIds.size && prevProps.statusIds.first() !== this.props.statusIds.first() && this._oldScrollPosition) { | ||||
|       const node = ReactDOM.findDOMNode(this); | ||||
|   componentDidMount () { | ||||
|     this.attachScrollListener(); | ||||
|   }, | ||||
| 
 | ||||
|       if (node.scrollTop > 0) { | ||||
|         node.scrollTop = node.scrollHeight - this._oldScrollPosition; | ||||
|       } | ||||
|   componentDidUpdate (prevProps) { | ||||
|     if (this.node.scrollTop > 0 && (prevProps.statusIds.size < this.props.statusIds.size && prevProps.statusIds.first() !== this.props.statusIds.first() && !!this._oldScrollPosition)) { | ||||
|       this.node.scrollTop = this.node.scrollHeight - this._oldScrollPosition; | ||||
|     } | ||||
|   }, | ||||
| 
 | ||||
|   componentWillUnmount () { | ||||
|     this.detachScrollListener(); | ||||
|   }, | ||||
| 
 | ||||
|   attachScrollListener () { | ||||
|     this.node.addEventListener('scroll', this.handleScroll); | ||||
|   }, | ||||
| 
 | ||||
|   detachScrollListener () { | ||||
|     this.node.removeEventListener('scroll', this.handleScroll); | ||||
|   }, | ||||
| 
 | ||||
|   setRef (c) { | ||||
|     this.node = c; | ||||
|   }, | ||||
| 
 | ||||
|   render () { | ||||
|     const { statusIds, onScrollToBottom, trackScroll } = this.props; | ||||
| 
 | ||||
|     const scrollableArea = ( | ||||
|       <div className='scrollable' onScroll={this.handleScroll}> | ||||
|       <div className='scrollable' ref={this.setRef}> | ||||
|         <div> | ||||
|           {statusIds.map((statusId) => { | ||||
|             return <StatusContainer key={statusId} id={statusId} />; | ||||
|  | ||||
| @ -9,7 +9,8 @@ import StatusList from '../../components/status_list'; | ||||
| import LoadingIndicator from '../../components/loading_indicator'; | ||||
| 
 | ||||
| const mapStateToProps = (state, props) => ({ | ||||
|   statusIds: state.getIn(['timelines', 'accounts_timelines', Number(props.params.accountId)]), | ||||
|   statusIds: state.getIn(['timelines', 'accounts_timelines', Number(props.params.accountId), 'items']), | ||||
|   isLoading: state.getIn(['timelines', 'accounts_timelines', Number(props.params.accountId), 'isLoading']), | ||||
|   me: state.getIn(['meta', 'me']) | ||||
| }); | ||||
| 
 | ||||
| @ -19,6 +20,7 @@ const AccountTimeline = React.createClass({ | ||||
|     params: React.PropTypes.object.isRequired, | ||||
|     dispatch: React.PropTypes.func.isRequired, | ||||
|     statusIds: ImmutablePropTypes.list, | ||||
|     isLoading: React.PropTypes.bool, | ||||
|     me: React.PropTypes.number.isRequired | ||||
|   }, | ||||
| 
 | ||||
| @ -39,13 +41,13 @@ const AccountTimeline = React.createClass({ | ||||
|   }, | ||||
| 
 | ||||
|   render () { | ||||
|     const { statusIds, me } = this.props; | ||||
|     const { statusIds, isLoading, me } = this.props; | ||||
| 
 | ||||
|     if (!statusIds) { | ||||
|       return <LoadingIndicator />; | ||||
|     } | ||||
| 
 | ||||
|     return <StatusList statusIds={statusIds} me={me} onScrollToBottom={this.handleScrollToBottom} /> | ||||
|     return <StatusList statusIds={statusIds} isLoading={isLoading} me={me} onScrollToBottom={this.handleScrollToBottom} /> | ||||
|   } | ||||
| 
 | ||||
| }); | ||||
|  | ||||
| @ -62,6 +62,7 @@ const Notifications = React.createClass({ | ||||
|     if (trackScroll) { | ||||
|       return ( | ||||
|         <Column icon='bell' heading={intl.formatMessage(messages.title)}> | ||||
|           <ColumnSettingsContainer /> | ||||
|           <ScrollContainer scrollKey='notifications'> | ||||
|             {scrollableArea} | ||||
|           </ScrollContainer> | ||||
|  | ||||
| @ -33,7 +33,8 @@ const getStatusIds = createSelector([ | ||||
| })); | ||||
| 
 | ||||
| const mapStateToProps = (state, props) => ({ | ||||
|   statusIds: getStatusIds(state, props) | ||||
|   statusIds: getStatusIds(state, props), | ||||
|   isLoading: state.getIn(['timelines', props.type, 'isLoading'], true) | ||||
| }); | ||||
| 
 | ||||
| const mapDispatchToProps = (dispatch, { type, id }) => ({ | ||||
|  | ||||
| @ -1,9 +1,12 @@ | ||||
| import { | ||||
|   TIMELINE_REFRESH_REQUEST, | ||||
|   TIMELINE_REFRESH_SUCCESS, | ||||
|   TIMELINE_REFRESH_FAIL, | ||||
|   TIMELINE_UPDATE, | ||||
|   TIMELINE_DELETE, | ||||
|   TIMELINE_EXPAND_SUCCESS, | ||||
|   TIMELINE_EXPAND_REQUEST, | ||||
|   TIMELINE_EXPAND_FAIL, | ||||
|   TIMELINE_SCROLL_TOP | ||||
| } from '../actions/timelines'; | ||||
| import { | ||||
| @ -13,37 +16,43 @@ import { | ||||
|   UNFAVOURITE_SUCCESS | ||||
| } from '../actions/interactions'; | ||||
| import { | ||||
|   ACCOUNT_FETCH_SUCCESS, | ||||
|   ACCOUNT_TIMELINE_FETCH_REQUEST, | ||||
|   ACCOUNT_TIMELINE_FETCH_SUCCESS, | ||||
|   ACCOUNT_TIMELINE_FETCH_FAIL, | ||||
|   ACCOUNT_TIMELINE_EXPAND_REQUEST, | ||||
|   ACCOUNT_TIMELINE_EXPAND_SUCCESS, | ||||
|   ACCOUNT_TIMELINE_EXPAND_FAIL, | ||||
|   ACCOUNT_BLOCK_SUCCESS | ||||
| } from '../actions/accounts'; | ||||
| import { | ||||
|   STATUS_FETCH_SUCCESS, | ||||
|   CONTEXT_FETCH_SUCCESS | ||||
| } from '../actions/statuses'; | ||||
| import Immutable from 'immutable'; | ||||
| 
 | ||||
| const initialState = Immutable.Map({ | ||||
|   home: Immutable.Map({ | ||||
|     isLoading: false, | ||||
|     loaded: false, | ||||
|     top: true, | ||||
|     items: Immutable.List() | ||||
|   }), | ||||
| 
 | ||||
|   mentions: Immutable.Map({ | ||||
|     isLoading: false, | ||||
|     loaded: false, | ||||
|     top: true, | ||||
|     items: Immutable.List() | ||||
|   }), | ||||
| 
 | ||||
|   public: Immutable.Map({ | ||||
|     isLoading: false, | ||||
|     loaded: false, | ||||
|     top: true, | ||||
|     items: Immutable.List() | ||||
|   }), | ||||
| 
 | ||||
|   tag: Immutable.Map({ | ||||
|     isLoading: false, | ||||
|     id: null, | ||||
|     loaded: false, | ||||
|     top: true, | ||||
| @ -82,6 +91,7 @@ const normalizeTimeline = (state, timeline, statuses, replace = false) => { | ||||
|   }); | ||||
| 
 | ||||
|   state = state.setIn([timeline, 'loaded'], true); | ||||
|   state = state.setIn([timeline, 'isLoading'], false); | ||||
| 
 | ||||
|   return state.updateIn([timeline, 'items'], Immutable.List(), list => (loaded ? list.unshift(...ids) : ids)); | ||||
| }; | ||||
| @ -94,6 +104,8 @@ const appendNormalizedTimeline = (state, timeline, statuses) => { | ||||
|     moreIds = moreIds.set(i, status.get('id')); | ||||
|   }); | ||||
| 
 | ||||
|   state = state.setIn([timeline, 'isLoading'], false); | ||||
| 
 | ||||
|   return state.updateIn([timeline, 'items'], Immutable.List(), list => list.push(...moreIds)); | ||||
| }; | ||||
| 
 | ||||
| @ -105,7 +117,10 @@ const normalizeAccountTimeline = (state, accountId, statuses, replace = false) = | ||||
|     ids   = ids.set(i, status.get('id')); | ||||
|   }); | ||||
| 
 | ||||
|   return state.updateIn(['accounts_timelines', accountId], Immutable.List([]), list => (replace ? ids : list.unshift(...ids))); | ||||
|   return state.updateIn(['accounts_timelines', accountId], Immutable.Map(), map => map | ||||
|     .set('isLoading', false) | ||||
|     .set('loaded', true) | ||||
|     .update('items', Immutable.List(), list => (replace ? ids : list.unshift(...ids)))); | ||||
| }; | ||||
| 
 | ||||
| const appendNormalizedAccountTimeline = (state, accountId, statuses) => { | ||||
| @ -116,7 +131,9 @@ const appendNormalizedAccountTimeline = (state, accountId, statuses) => { | ||||
|     moreIds = moreIds.set(i, status.get('id')); | ||||
|   }); | ||||
| 
 | ||||
|   return state.updateIn(['accounts_timelines', accountId], Immutable.List([]), list => list.push(...moreIds)); | ||||
|   return state.updateIn(['accounts_timelines', accountId], Immutable.Map(), map => map | ||||
|     .set('isLoading', false) | ||||
|     .update('items', list => list.push(...moreIds))); | ||||
| }; | ||||
| 
 | ||||
| const updateTimeline = (state, timeline, status, references) => { | ||||
| @ -157,7 +174,7 @@ const deleteStatus = (state, id, accountId, references, reblogOf) => { | ||||
|   }); | ||||
| 
 | ||||
|   // Remove references from account timelines | ||||
|   state = state.updateIn(['accounts_timelines', accountId], Immutable.List([]), list => list.filterNot(item => item === id)); | ||||
|   state = state.updateIn(['accounts_timelines', accountId, 'items'], Immutable.List([]), list => list.filterNot(item => item === id)); | ||||
| 
 | ||||
|   // Remove references from context | ||||
|   state.getIn(['descendants', id], Immutable.List()).forEach(descendantId => { | ||||
| @ -207,8 +224,11 @@ const resetTimeline = (state, timeline, id) => { | ||||
|   if (timeline === 'tag' && state.getIn([timeline, 'id']) !== id) { | ||||
|     state = state.update(timeline, map => map | ||||
|         .set('id', id) | ||||
|         .set('isLoading', true) | ||||
|         .set('loaded', false) | ||||
|         .update('items', list => list.clear())); | ||||
|   } else { | ||||
|     state = state.setIn([timeline, 'isLoading'], true); | ||||
|   } | ||||
| 
 | ||||
|   return state; | ||||
| @ -216,27 +236,37 @@ const resetTimeline = (state, timeline, id) => { | ||||
| 
 | ||||
| export default function timelines(state = initialState, action) { | ||||
|   switch(action.type) { | ||||
|     case TIMELINE_REFRESH_REQUEST: | ||||
|       return resetTimeline(state, action.timeline, action.id); | ||||
|     case TIMELINE_REFRESH_SUCCESS: | ||||
|       return normalizeTimeline(state, action.timeline, Immutable.fromJS(action.statuses)); | ||||
|     case TIMELINE_EXPAND_SUCCESS: | ||||
|       return appendNormalizedTimeline(state, action.timeline, Immutable.fromJS(action.statuses)); | ||||
|     case TIMELINE_UPDATE: | ||||
|       return updateTimeline(state, action.timeline, Immutable.fromJS(action.status), action.references); | ||||
|     case TIMELINE_DELETE: | ||||
|       return deleteStatus(state, action.id, action.accountId, action.references, action.reblogOf); | ||||
|     case CONTEXT_FETCH_SUCCESS: | ||||
|       return normalizeContext(state, action.id, Immutable.fromJS(action.ancestors), Immutable.fromJS(action.descendants)); | ||||
|     case ACCOUNT_TIMELINE_FETCH_SUCCESS: | ||||
|       return normalizeAccountTimeline(state, action.id, Immutable.fromJS(action.statuses), action.replace); | ||||
|     case ACCOUNT_TIMELINE_EXPAND_SUCCESS: | ||||
|       return appendNormalizedAccountTimeline(state, action.id, Immutable.fromJS(action.statuses)); | ||||
|     case ACCOUNT_BLOCK_SUCCESS: | ||||
|       return filterTimelines(state, action.relationship, action.statuses); | ||||
|     case TIMELINE_SCROLL_TOP: | ||||
|       return state.setIn([action.timeline, 'top'], action.top); | ||||
|     default: | ||||
|       return state; | ||||
|   case TIMELINE_REFRESH_REQUEST: | ||||
|   case TIMELINE_EXPAND_REQUEST: | ||||
|     return resetTimeline(state, action.timeline, action.id); | ||||
|   case TIMELINE_REFRESH_FAIL: | ||||
|   case TIMELINE_EXPAND_FAIL: | ||||
|     return state.setIn([action.timeline, 'isLoading'], false); | ||||
|   case TIMELINE_REFRESH_SUCCESS: | ||||
|     return normalizeTimeline(state, action.timeline, Immutable.fromJS(action.statuses)); | ||||
|   case TIMELINE_EXPAND_SUCCESS: | ||||
|     return appendNormalizedTimeline(state, action.timeline, Immutable.fromJS(action.statuses)); | ||||
|   case TIMELINE_UPDATE: | ||||
|     return updateTimeline(state, action.timeline, Immutable.fromJS(action.status), action.references); | ||||
|   case TIMELINE_DELETE: | ||||
|     return deleteStatus(state, action.id, action.accountId, action.references, action.reblogOf); | ||||
|   case CONTEXT_FETCH_SUCCESS: | ||||
|     return normalizeContext(state, action.id, Immutable.fromJS(action.ancestors), Immutable.fromJS(action.descendants)); | ||||
|   case ACCOUNT_TIMELINE_FETCH_REQUEST: | ||||
|   case ACCOUNT_TIMELINE_EXPAND_REQUEST: | ||||
|     return state.updateIn(['accounts_timelines', action.id], Immutable.Map(), map => map.set('isLoading', true)); | ||||
|   case ACCOUNT_TIMELINE_FETCH_FAIL: | ||||
|   case ACCOUNT_TIMELINE_EXPAND_FAIL: | ||||
|     return state.updateIn(['accounts_timelines', action.id], Immutable.Map(), map => map.set('isLoading', false)); | ||||
|   case ACCOUNT_TIMELINE_FETCH_SUCCESS: | ||||
|     return normalizeAccountTimeline(state, action.id, Immutable.fromJS(action.statuses), action.replace); | ||||
|   case ACCOUNT_TIMELINE_EXPAND_SUCCESS: | ||||
|     return appendNormalizedAccountTimeline(state, action.id, Immutable.fromJS(action.statuses)); | ||||
|   case ACCOUNT_BLOCK_SUCCESS: | ||||
|     return filterTimelines(state, action.relationship, action.statuses); | ||||
|   case TIMELINE_SCROLL_TOP: | ||||
|     return state.setIn([action.timeline, 'top'], action.top); | ||||
|   default: | ||||
|     return state; | ||||
|   } | ||||
| }; | ||||
|  | ||||
| @ -16,13 +16,13 @@ class Api::V1::AccountsController < ApiController | ||||
|   end | ||||
| 
 | ||||
|   def following | ||||
|     results   = Follow.where(account: @account).paginate_by_max_id(DEFAULT_ACCOUNTS_LIMIT, params[:max_id], params[:since_id]) | ||||
|     results   = Follow.where(account: @account).paginate_by_max_id(limit_param(DEFAULT_ACCOUNTS_LIMIT), params[:max_id], params[:since_id]) | ||||
|     accounts  = Account.where(id: results.map(&:target_account_id)).map { |a| [a.id, a] }.to_h | ||||
|     @accounts = results.map { |f| accounts[f.target_account_id] } | ||||
| 
 | ||||
|     set_account_counters_maps(@accounts) | ||||
| 
 | ||||
|     next_path = following_api_v1_account_url(max_id: results.last.id)    if results.size == DEFAULT_ACCOUNTS_LIMIT | ||||
|     next_path = following_api_v1_account_url(max_id: results.last.id)    if results.size == limit_param(DEFAULT_ACCOUNTS_LIMIT) | ||||
|     prev_path = following_api_v1_account_url(since_id: results.first.id) unless results.empty? | ||||
| 
 | ||||
|     set_pagination_headers(next_path, prev_path) | ||||
| @ -31,13 +31,13 @@ class Api::V1::AccountsController < ApiController | ||||
|   end | ||||
| 
 | ||||
|   def followers | ||||
|     results   = Follow.where(target_account: @account).paginate_by_max_id(DEFAULT_ACCOUNTS_LIMIT, params[:max_id], params[:since_id]) | ||||
|     results   = Follow.where(target_account: @account).paginate_by_max_id(limit_param(DEFAULT_ACCOUNTS_LIMIT), params[:max_id], params[:since_id]) | ||||
|     accounts  = Account.where(id: results.map(&:account_id)).map { |a| [a.id, a] }.to_h | ||||
|     @accounts = results.map { |f| accounts[f.account_id] } | ||||
| 
 | ||||
|     set_account_counters_maps(@accounts) | ||||
| 
 | ||||
|     next_path = followers_api_v1_account_url(max_id: results.last.id)    if results.size == DEFAULT_ACCOUNTS_LIMIT | ||||
|     next_path = followers_api_v1_account_url(max_id: results.last.id)    if results.size == limit_param(DEFAULT_ACCOUNTS_LIMIT) | ||||
|     prev_path = followers_api_v1_account_url(since_id: results.first.id) unless results.empty? | ||||
| 
 | ||||
|     set_pagination_headers(next_path, prev_path) | ||||
| @ -46,13 +46,13 @@ class Api::V1::AccountsController < ApiController | ||||
|   end | ||||
| 
 | ||||
|   def statuses | ||||
|     @statuses = @account.statuses.permitted_for(@account, current_account).paginate_by_max_id(DEFAULT_STATUSES_LIMIT, params[:max_id], params[:since_id]) | ||||
|     @statuses = @account.statuses.permitted_for(@account, current_account).paginate_by_max_id(limit_param(DEFAULT_STATUSES_LIMIT), params[:max_id], params[:since_id]) | ||||
|     @statuses = cache_collection(@statuses, Status) | ||||
| 
 | ||||
|     set_maps(@statuses) | ||||
|     set_counters_maps(@statuses) | ||||
| 
 | ||||
|     next_path = statuses_api_v1_account_url(max_id: @statuses.last.id)    if @statuses.size == DEFAULT_STATUSES_LIMIT | ||||
|     next_path = statuses_api_v1_account_url(max_id: @statuses.last.id)    if @statuses.size == limit_param(DEFAULT_STATUSES_LIMIT) | ||||
|     prev_path = statuses_api_v1_account_url(since_id: @statuses.first.id) unless @statuses.empty? | ||||
| 
 | ||||
|     set_pagination_headers(next_path, prev_path) | ||||
| @ -98,8 +98,7 @@ class Api::V1::AccountsController < ApiController | ||||
|   end | ||||
| 
 | ||||
|   def search | ||||
|     limit = params[:limit] ? [DEFAULT_ACCOUNTS_LIMIT, params[:limit].to_i].min : DEFAULT_ACCOUNTS_LIMIT | ||||
|     @accounts = SearchService.new.call(params[:q], limit, params[:resolve] == 'true') | ||||
|     @accounts = SearchService.new.call(params[:q], limit_param(DEFAULT_ACCOUNTS_LIMIT), params[:resolve] == 'true') | ||||
| 
 | ||||
|     set_account_counters_maps(@accounts) unless @accounts.nil? | ||||
| 
 | ||||
|  | ||||
| @ -7,13 +7,13 @@ class Api::V1::BlocksController < ApiController | ||||
|   respond_to :json | ||||
| 
 | ||||
|   def index | ||||
|     results   = Block.where(account: current_account).paginate_by_max_id(DEFAULT_ACCOUNTS_LIMIT, params[:max_id], params[:since_id]) | ||||
|     results   = Block.where(account: current_account).paginate_by_max_id(limit_param(DEFAULT_ACCOUNTS_LIMIT), params[:max_id], params[:since_id]) | ||||
|     accounts  = Account.where(id: results.map(&:target_account_id)).map { |a| [a.id, a] }.to_h | ||||
|     @accounts = results.map { |f| accounts[f.target_account_id] } | ||||
| 
 | ||||
|     set_account_counters_maps(@accounts) | ||||
| 
 | ||||
|     next_path = api_v1_blocks_url(max_id: results.last.id)    if results.size == DEFAULT_ACCOUNTS_LIMIT | ||||
|     next_path = api_v1_blocks_url(max_id: results.last.id)    if results.size == limit_param(DEFAULT_ACCOUNTS_LIMIT) | ||||
|     prev_path = api_v1_blocks_url(since_id: results.first.id) unless results.empty? | ||||
| 
 | ||||
|     set_pagination_headers(next_path, prev_path) | ||||
|  | ||||
| @ -7,13 +7,13 @@ class Api::V1::FavouritesController < ApiController | ||||
|   respond_to :json | ||||
| 
 | ||||
|   def index | ||||
|     results   = Favourite.where(account: current_account).paginate_by_max_id(DEFAULT_STATUSES_LIMIT, params[:max_id], params[:since_id]) | ||||
|     results   = Favourite.where(account: current_account).paginate_by_max_id(limit_param(DEFAULT_STATUSES_LIMIT), params[:max_id], params[:since_id]) | ||||
|     @statuses = cache_collection(Status.where(id: results.map(&:status_id)), Status) | ||||
| 
 | ||||
|     set_maps(@statuses) | ||||
|     set_counters_maps(@statuses) | ||||
| 
 | ||||
|     next_path = api_v1_favourites_url(max_id: results.last.id)    if results.size == DEFAULT_STATUSES_LIMIT | ||||
|     next_path = api_v1_favourites_url(max_id: results.last.id)    if results.size == limit_param(DEFAULT_STATUSES_LIMIT) | ||||
|     prev_path = api_v1_favourites_url(since_id: results.first.id) unless results.empty? | ||||
| 
 | ||||
|     set_pagination_headers(next_path, prev_path) | ||||
|  | ||||
| @ -7,7 +7,7 @@ class Api::V1::NotificationsController < ApiController | ||||
|   respond_to :json | ||||
| 
 | ||||
|   def index | ||||
|     @notifications = Notification.where(account: current_account).browserable.paginate_by_max_id(20, params[:max_id], params[:since_id]) | ||||
|     @notifications = Notification.where(account: current_account).browserable.paginate_by_max_id(limit_param(15), params[:max_id], params[:since_id]) | ||||
|     @notifications = cache_collection(@notifications, Notification) | ||||
|     statuses       = @notifications.select { |n| !n.target_status.nil? }.map(&:target_status) | ||||
| 
 | ||||
| @ -15,7 +15,7 @@ class Api::V1::NotificationsController < ApiController | ||||
|     set_counters_maps(statuses) | ||||
|     set_account_counters_maps(@notifications.map(&:from_account)) | ||||
| 
 | ||||
|     next_path = api_v1_notifications_url(max_id: @notifications.last.id)    if @notifications.size == 20 | ||||
|     next_path = api_v1_notifications_url(max_id: @notifications.last.id)    if @notifications.size == limit_param(15) | ||||
|     prev_path = api_v1_notifications_url(since_id: @notifications.first.id) unless @notifications.empty? | ||||
| 
 | ||||
|     set_pagination_headers(next_path, prev_path) | ||||
|  | ||||
| @ -27,13 +27,13 @@ class Api::V1::StatusesController < ApiController | ||||
|   end | ||||
| 
 | ||||
|   def reblogged_by | ||||
|     results   = @status.reblogs.paginate_by_max_id(DEFAULT_ACCOUNTS_LIMIT, params[:max_id], params[:since_id]) | ||||
|     results   = @status.reblogs.paginate_by_max_id(limit_param(DEFAULT_ACCOUNTS_LIMIT), params[:max_id], params[:since_id]) | ||||
|     accounts  = Account.where(id: results.map(&:account_id)).map { |a| [a.id, a] }.to_h | ||||
|     @accounts = results.map { |r| accounts[r.account_id] } | ||||
| 
 | ||||
|     set_account_counters_maps(@accounts) | ||||
| 
 | ||||
|     next_path = reblogged_by_api_v1_status_url(max_id: results.last.id)    if results.size == DEFAULT_ACCOUNTS_LIMIT | ||||
|     next_path = reblogged_by_api_v1_status_url(max_id: results.last.id)    if results.size == limit_param(DEFAULT_ACCOUNTS_LIMIT) | ||||
|     prev_path = reblogged_by_api_v1_status_url(since_id: results.first.id) unless results.empty? | ||||
| 
 | ||||
|     set_pagination_headers(next_path, prev_path) | ||||
| @ -42,13 +42,13 @@ class Api::V1::StatusesController < ApiController | ||||
|   end | ||||
| 
 | ||||
|   def favourited_by | ||||
|     results   = @status.favourites.paginate_by_max_id(DEFAULT_ACCOUNTS_LIMIT, params[:max_id], params[:since_id]) | ||||
|     results   = @status.favourites.paginate_by_max_id(limit_param(DEFAULT_ACCOUNTS_LIMIT), params[:max_id], params[:since_id]) | ||||
|     accounts  = Account.where(id: results.map(&:account_id)).map { |a| [a.id, a] }.to_h | ||||
|     @accounts = results.map { |f| accounts[f.account_id] } | ||||
| 
 | ||||
|     set_account_counters_maps(@accounts) | ||||
| 
 | ||||
|     next_path = favourited_by_api_v1_status_url(max_id: results.last.id)    if results.size == DEFAULT_ACCOUNTS_LIMIT | ||||
|     next_path = favourited_by_api_v1_status_url(max_id: results.last.id)    if results.size == limit_param(DEFAULT_ACCOUNTS_LIMIT) | ||||
|     prev_path = favourited_by_api_v1_status_url(since_id: results.first.id) unless results.empty? | ||||
| 
 | ||||
|     set_pagination_headers(next_path, prev_path) | ||||
|  | ||||
| @ -7,14 +7,14 @@ class Api::V1::TimelinesController < ApiController | ||||
|   respond_to :json | ||||
| 
 | ||||
|   def home | ||||
|     @statuses = Feed.new(:home, current_account).get(DEFAULT_STATUSES_LIMIT, params[:max_id], params[:since_id]) | ||||
|     @statuses = Feed.new(:home, current_account).get(limit_param(DEFAULT_STATUSES_LIMIT), params[:max_id], params[:since_id]) | ||||
|     @statuses = cache_collection(@statuses) | ||||
| 
 | ||||
|     set_maps(@statuses) | ||||
|     set_counters_maps(@statuses) | ||||
|     set_account_counters_maps(@statuses.flat_map { |s| [s.account, s.reblog? ? s.reblog.account : nil] }.compact.uniq) | ||||
| 
 | ||||
|     next_path = api_v1_home_timeline_url(max_id: @statuses.last.id)    if @statuses.size == DEFAULT_STATUSES_LIMIT | ||||
|     next_path = api_v1_home_timeline_url(max_id: @statuses.last.id)    if @statuses.size == limit_param(DEFAULT_STATUSES_LIMIT) | ||||
|     prev_path = api_v1_home_timeline_url(since_id: @statuses.first.id) unless @statuses.empty? | ||||
| 
 | ||||
|     set_pagination_headers(next_path, prev_path) | ||||
| @ -23,14 +23,14 @@ class Api::V1::TimelinesController < ApiController | ||||
|   end | ||||
| 
 | ||||
|   def mentions | ||||
|     @statuses = Feed.new(:mentions, current_account).get(DEFAULT_STATUSES_LIMIT, params[:max_id], params[:since_id]) | ||||
|     @statuses = Feed.new(:mentions, current_account).get(limit_param(DEFAULT_STATUSES_LIMIT), params[:max_id], params[:since_id]) | ||||
|     @statuses = cache_collection(@statuses) | ||||
| 
 | ||||
|     set_maps(@statuses) | ||||
|     set_counters_maps(@statuses) | ||||
|     set_account_counters_maps(@statuses.flat_map { |s| [s.account, s.reblog? ? s.reblog.account : nil] }.compact.uniq) | ||||
| 
 | ||||
|     next_path = api_v1_mentions_timeline_url(max_id: @statuses.last.id)    if @statuses.size == DEFAULT_STATUSES_LIMIT | ||||
|     next_path = api_v1_mentions_timeline_url(max_id: @statuses.last.id)    if @statuses.size == limit_param(DEFAULT_STATUSES_LIMIT) | ||||
|     prev_path = api_v1_mentions_timeline_url(since_id: @statuses.first.id) unless @statuses.empty? | ||||
| 
 | ||||
|     set_pagination_headers(next_path, prev_path) | ||||
| @ -39,14 +39,14 @@ class Api::V1::TimelinesController < ApiController | ||||
|   end | ||||
| 
 | ||||
|   def public | ||||
|     @statuses = Status.as_public_timeline(current_account).paginate_by_max_id(DEFAULT_STATUSES_LIMIT, params[:max_id], params[:since_id]) | ||||
|     @statuses = Status.as_public_timeline(current_account).paginate_by_max_id(limit_param(DEFAULT_STATUSES_LIMIT), params[:max_id], params[:since_id]) | ||||
|     @statuses = cache_collection(@statuses) | ||||
| 
 | ||||
|     set_maps(@statuses) | ||||
|     set_counters_maps(@statuses) | ||||
|     set_account_counters_maps(@statuses.flat_map { |s| [s.account, s.reblog? ? s.reblog.account : nil] }.compact.uniq) | ||||
| 
 | ||||
|     next_path = api_v1_public_timeline_url(max_id: @statuses.last.id)    if @statuses.size == DEFAULT_STATUSES_LIMIT | ||||
|     next_path = api_v1_public_timeline_url(max_id: @statuses.last.id)    if @statuses.size == limit_param(DEFAULT_STATUSES_LIMIT) | ||||
|     prev_path = api_v1_public_timeline_url(since_id: @statuses.first.id) unless @statuses.empty? | ||||
| 
 | ||||
|     set_pagination_headers(next_path, prev_path) | ||||
| @ -56,14 +56,14 @@ class Api::V1::TimelinesController < ApiController | ||||
| 
 | ||||
|   def tag | ||||
|     @tag      = Tag.find_by(name: params[:id].downcase) | ||||
|     @statuses = @tag.nil? ? [] : Status.as_tag_timeline(@tag, current_account).paginate_by_max_id(DEFAULT_STATUSES_LIMIT, params[:max_id], params[:since_id]) | ||||
|     @statuses = @tag.nil? ? [] : Status.as_tag_timeline(@tag, current_account).paginate_by_max_id(limit_param(DEFAULT_STATUSES_LIMIT), params[:max_id], params[:since_id]) | ||||
|     @statuses = cache_collection(@statuses) | ||||
| 
 | ||||
|     set_maps(@statuses) | ||||
|     set_counters_maps(@statuses) | ||||
|     set_account_counters_maps(@statuses.flat_map { |s| [s.account, s.reblog? ? s.reblog.account : nil] }.compact.uniq) | ||||
| 
 | ||||
|     next_path = api_v1_hashtag_timeline_url(params[:id], max_id: @statuses.last.id)    if @statuses.size == DEFAULT_STATUSES_LIMIT | ||||
|     next_path = api_v1_hashtag_timeline_url(params[:id], max_id: @statuses.last.id)    if @statuses.size == limit_param(DEFAULT_STATUSES_LIMIT) | ||||
|     prev_path = api_v1_hashtag_timeline_url(params[:id], since_id: @statuses.first.id) unless @statuses.empty? | ||||
| 
 | ||||
|     set_pagination_headers(next_path, prev_path) | ||||
|  | ||||
| @ -62,6 +62,11 @@ class ApiController < ApplicationController | ||||
|     response.headers['Link'] = LinkHeader.new(links) | ||||
|   end | ||||
| 
 | ||||
|   def limit_param(default_limit) | ||||
|     return default_limit unless params[:limit] | ||||
|     [params[:limit].to_i.abs, default_limit * 2].min | ||||
|   end | ||||
| 
 | ||||
|   def current_resource_owner | ||||
|     @current_user ||= User.find(doorkeeper_token.resource_owner_id) if doorkeeper_token | ||||
|   end | ||||
|  | ||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user