Fix processing poll Updates (#10333)

ActivityPub::ProcessPollService was checking the JSON-LD context although
it was passed only the `Question` object embedded in the `Update` activity.
master
ThibG 4 years ago committed by Eugen Rochko
parent d66bbdd353
commit 62dd0b7f9c
  1. 1
      app/services/activitypub/fetch_remote_poll_service.rb
  2. 6
      app/services/activitypub/process_poll_service.rb

@ -5,6 +5,7 @@ class ActivityPub::FetchRemotePollService < BaseService
def call(poll, on_behalf_of = nil)
json = fetch_resource(poll.status.uri, true, on_behalf_of)
return unless supported_context?(json)
ActivityPub::ProcessPollService.new.call(poll, json)
end
end

@ -5,7 +5,7 @@ class ActivityPub::ProcessPollService < BaseService
def call(poll, json)
@json = json
return unless supported_context? && expected_type?
return unless expected_type?
previous_expires_at = poll.expires_at
@ -54,10 +54,6 @@ class ActivityPub::ProcessPollService < BaseService
private
def supported_context?
super(@json)
end
def expected_type?
equals_or_includes_any?(@json['type'], %w(Question))
end

Loading…
Cancel
Save