Combine repeated subject in cacheable response shared example (#28945)
				
					
				
			This commit is contained in:
		
							parent
							
								
									d791bca11b
								
							
						
					
					
						commit
						e519f113e8
					
				| @ -1,22 +1,14 @@ | |||||||
| # frozen_string_literal: true | # frozen_string_literal: true | ||||||
| 
 | 
 | ||||||
| shared_examples 'cacheable response' do |expects_vary: false| | shared_examples 'cacheable response' do |expects_vary: false| | ||||||
|   it 'does not set cookies' do |   it 'sets correct cache and vary headers and does not set cookies or session' do | ||||||
|     expect(response.cookies).to be_empty |     expect(response.cookies).to be_empty | ||||||
|     expect(response.headers['Set-Cookies']).to be_nil |     expect(response.headers['Set-Cookies']).to be_nil | ||||||
|   end |  | ||||||
| 
 | 
 | ||||||
|   it 'does not set sessions' do |  | ||||||
|     expect(session).to be_empty |     expect(session).to be_empty | ||||||
|   end |  | ||||||
| 
 | 
 | ||||||
|   if expects_vary |     expect(response.headers['Vary']).to include(expects_vary) if expects_vary | ||||||
|     it 'returns Vary header' do |  | ||||||
|       expect(response.headers['Vary']).to include(expects_vary) |  | ||||||
|     end |  | ||||||
|   end |  | ||||||
| 
 | 
 | ||||||
|   it 'returns public Cache-Control header' do |  | ||||||
|     expect(response.headers['Cache-Control']).to include('public') |     expect(response.headers['Cache-Control']).to include('public') | ||||||
|   end |   end | ||||||
| end | end | ||||||
|  | |||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user