* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
		
			
				
	
	
		
			63 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			63 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| require 'rails_helper'
 | |
| 
 | |
| RSpec.describe Admin::ConfirmationsController, type: :controller do
 | |
|   render_views
 | |
| 
 | |
|   before do
 | |
|     sign_in Fabricate(:user, admin: true), scope: :user
 | |
|   end
 | |
| 
 | |
|   describe 'POST #create' do
 | |
|     it 'confirms the user' do
 | |
|       user = Fabricate(:user, confirmed_at: false)
 | |
|       post :create, params: { account_id: user.account.id }
 | |
| 
 | |
|       expect(response).to redirect_to(admin_accounts_path)
 | |
|       expect(user.reload).to be_confirmed
 | |
|     end
 | |
| 
 | |
|     it 'raises an error when there is no account' do
 | |
|       post :create, params: { account_id: 'fake' }
 | |
| 
 | |
|       expect(response).to have_http_status(404)
 | |
|     end
 | |
| 
 | |
|     it 'raises an error when there is no user' do
 | |
|       account = Fabricate(:account, user: nil)
 | |
|       post :create, params: { account_id: account.id }
 | |
| 
 | |
|       expect(response).to have_http_status(404)
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   describe 'POST #resernd' do
 | |
|     subject { post :resend, params: { account_id: user.account.id } }
 | |
| 
 | |
|     let!(:user) { Fabricate(:user, confirmed_at: confirmed_at) }
 | |
| 
 | |
|     before do
 | |
|       allow(UserMailer).to receive(:confirmation_instructions) { double(:email, deliver_later: nil) }
 | |
|     end
 | |
| 
 | |
|     context 'when email is not confirmed' do
 | |
|       let(:confirmed_at) { nil }
 | |
| 
 | |
|       it 'resends confirmation mail' do
 | |
|         expect(subject).to redirect_to admin_accounts_path
 | |
|         expect(flash[:notice]).to eq I18n.t('admin.accounts.resend_confirmation.success')
 | |
|         expect(UserMailer).to have_received(:confirmation_instructions).once
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     context 'when email is confirmed' do
 | |
|       let(:confirmed_at) { Time.zone.now }
 | |
| 
 | |
|       it 'does not resend confirmation mail' do
 | |
|         expect(subject).to redirect_to admin_accounts_path
 | |
|         expect(flash[:error]).to eq I18n.t('admin.accounts.resend_confirmation.already_confirmed')
 | |
|         expect(UserMailer).not_to have_received(:confirmation_instructions)
 | |
|       end
 | |
|     end
 | |
|   end
 | |
| end
 |