* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
		
			
				
	
	
		
			108 lines
		
	
	
		
			2.7 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			108 lines
		
	
	
		
			2.7 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
require 'rails_helper'
 | 
						|
 | 
						|
describe Settings::DeletesController do
 | 
						|
  render_views
 | 
						|
 | 
						|
  describe 'GET #show' do
 | 
						|
    context 'when signed in' do
 | 
						|
      let(:user) { Fabricate(:user) }
 | 
						|
 | 
						|
      before do
 | 
						|
        sign_in user, scope: :user
 | 
						|
      end
 | 
						|
 | 
						|
      it 'renders confirmation page' do
 | 
						|
        get :show
 | 
						|
        expect(response).to have_http_status(200)
 | 
						|
      end
 | 
						|
 | 
						|
      context 'when suspended' do
 | 
						|
        let(:user) { Fabricate(:user, account_attributes: { suspended_at: Time.now.utc }) }
 | 
						|
 | 
						|
        it 'returns http forbidden' do
 | 
						|
          get :show
 | 
						|
          expect(response).to have_http_status(403)
 | 
						|
        end
 | 
						|
      end
 | 
						|
    end
 | 
						|
 | 
						|
    context 'when not signed in' do
 | 
						|
      it 'redirects' do
 | 
						|
        get :show
 | 
						|
        expect(response).to redirect_to '/auth/sign_in'
 | 
						|
      end
 | 
						|
    end
 | 
						|
  end
 | 
						|
 | 
						|
  describe 'DELETE #destroy' do
 | 
						|
    context 'when signed in' do
 | 
						|
      let(:user) { Fabricate(:user, password: 'petsmoldoggos') }
 | 
						|
 | 
						|
      before do
 | 
						|
        sign_in user, scope: :user
 | 
						|
      end
 | 
						|
 | 
						|
      context 'with correct password' do
 | 
						|
        before do
 | 
						|
          delete :destroy, params: { form_delete_confirmation: { password: 'petsmoldoggos' } }
 | 
						|
        end
 | 
						|
 | 
						|
        it 'redirects to sign in page' do
 | 
						|
          expect(response).to redirect_to '/auth/sign_in'
 | 
						|
        end
 | 
						|
 | 
						|
        it 'removes user record' do
 | 
						|
          expect(User.find_by(id: user.id)).to be_nil
 | 
						|
        end
 | 
						|
 | 
						|
        it 'marks account as suspended' do
 | 
						|
          expect(user.account.reload).to be_suspended
 | 
						|
        end
 | 
						|
 | 
						|
        it 'does not create an email block' do
 | 
						|
          expect(CanonicalEmailBlock.block?(user.email)).to be false
 | 
						|
        end
 | 
						|
 | 
						|
        context 'when suspended' do
 | 
						|
          let(:user) { Fabricate(:user, account_attributes: { suspended_at: Time.now.utc }) }
 | 
						|
 | 
						|
          it 'returns http forbidden' do
 | 
						|
            expect(response).to have_http_status(403)
 | 
						|
          end
 | 
						|
        end
 | 
						|
      end
 | 
						|
 | 
						|
      context 'with incorrect password' do
 | 
						|
        before do
 | 
						|
          delete :destroy, params: { form_delete_confirmation: { password: 'blaze420' } }
 | 
						|
        end
 | 
						|
 | 
						|
        it 'redirects back to confirmation page' do
 | 
						|
          expect(response).to redirect_to settings_delete_path
 | 
						|
        end
 | 
						|
      end
 | 
						|
 | 
						|
      context 'when account deletions are disabled' do
 | 
						|
        around do |example|
 | 
						|
          open_deletion = Setting.open_deletion
 | 
						|
          example.run
 | 
						|
          Setting.open_deletion = open_deletion
 | 
						|
        end
 | 
						|
 | 
						|
        it 'redirects' do
 | 
						|
          Setting.open_deletion = false
 | 
						|
          delete :destroy
 | 
						|
          expect(response).to redirect_to root_path
 | 
						|
        end
 | 
						|
      end
 | 
						|
    end
 | 
						|
 | 
						|
    context 'when not signed in' do
 | 
						|
      it 'redirects' do
 | 
						|
        delete :destroy
 | 
						|
        expect(response).to redirect_to '/auth/sign_in'
 | 
						|
      end
 | 
						|
    end
 | 
						|
  end
 | 
						|
end
 |