* Decouple Status#local? from uri being nil * Replace on-the-fly URI generation with stored URIs - Generate URI in after_save hook for local statuses - Use static value in TagManager when available, fallback to tag format - Make TagManager use ActivityPub::TagManager to understand new format - Adjust tests * Use other heuristic for locality of old statuses, do not perform long query * Exclude tombstone stream entries from Atom feed * Prevent nil statuses from landing in Pubsubhubbub::DistributionWorker * Fix URI not being saved (#4818) * Add more specs for Status * Save generated uri immediately and also fix method order to minimize diff. * Fix alternate HTML URL in Atom * Fix tests * Remove not-null constraint from statuses migration to speed it up
		
			
				
	
	
		
			108 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			108 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
require 'rails_helper'
 | 
						|
 | 
						|
RSpec.describe ActivityPub::Activity::Undo do
 | 
						|
  let(:sender) { Fabricate(:account, domain: 'example.com') }
 | 
						|
 | 
						|
  let(:json) do
 | 
						|
    {
 | 
						|
      '@context': 'https://www.w3.org/ns/activitystreams',
 | 
						|
      id: 'foo',
 | 
						|
      type: 'Undo',
 | 
						|
      actor: ActivityPub::TagManager.instance.uri_for(sender),
 | 
						|
      object: object_json,
 | 
						|
    }.with_indifferent_access
 | 
						|
  end
 | 
						|
 | 
						|
  subject { described_class.new(json, sender) }
 | 
						|
 | 
						|
  describe '#perform' do
 | 
						|
    context 'with Announce' do
 | 
						|
      let(:status) { Fabricate(:status) }
 | 
						|
 | 
						|
      let(:object_json) do
 | 
						|
        {
 | 
						|
          id: 'bar',
 | 
						|
          type: 'Announce',
 | 
						|
          actor: ActivityPub::TagManager.instance.uri_for(sender),
 | 
						|
          object: ActivityPub::TagManager.instance.uri_for(status),
 | 
						|
        }
 | 
						|
      end
 | 
						|
 | 
						|
      before do
 | 
						|
        Fabricate(:status, reblog: status, account: sender, uri: 'bar')
 | 
						|
      end
 | 
						|
 | 
						|
      it 'deletes the reblog' do
 | 
						|
        subject.perform
 | 
						|
        expect(sender.reblogged?(status)).to be false
 | 
						|
      end
 | 
						|
    end
 | 
						|
 | 
						|
    context 'with Block' do
 | 
						|
      let(:recipient) { Fabricate(:account) }
 | 
						|
 | 
						|
      let(:object_json) do
 | 
						|
        {
 | 
						|
          id: 'bar',
 | 
						|
          type: 'Block',
 | 
						|
          actor: ActivityPub::TagManager.instance.uri_for(sender),
 | 
						|
          object: ActivityPub::TagManager.instance.uri_for(recipient),
 | 
						|
        }
 | 
						|
      end
 | 
						|
 | 
						|
      before do
 | 
						|
        sender.block!(recipient)
 | 
						|
      end
 | 
						|
 | 
						|
      it 'deletes block from sender to recipient' do
 | 
						|
        subject.perform
 | 
						|
        expect(sender.blocking?(recipient)).to be false
 | 
						|
      end
 | 
						|
    end
 | 
						|
 | 
						|
    context 'with Follow' do
 | 
						|
      let(:recipient) { Fabricate(:account) }
 | 
						|
 | 
						|
      let(:object_json) do
 | 
						|
        {
 | 
						|
          id: 'bar',
 | 
						|
          type: 'Follow',
 | 
						|
          actor: ActivityPub::TagManager.instance.uri_for(sender),
 | 
						|
          object: ActivityPub::TagManager.instance.uri_for(recipient),
 | 
						|
        }
 | 
						|
      end
 | 
						|
 | 
						|
      before do
 | 
						|
        sender.follow!(recipient)
 | 
						|
      end
 | 
						|
 | 
						|
      it 'deletes follow from sender to recipient' do
 | 
						|
        subject.perform
 | 
						|
        expect(sender.following?(recipient)).to be false
 | 
						|
      end
 | 
						|
    end
 | 
						|
 | 
						|
    context 'with Like' do
 | 
						|
      let(:status) { Fabricate(:status) }
 | 
						|
 | 
						|
      let(:object_json) do
 | 
						|
        {
 | 
						|
          id: 'bar',
 | 
						|
          type: 'Like',
 | 
						|
          actor: ActivityPub::TagManager.instance.uri_for(sender),
 | 
						|
          object: ActivityPub::TagManager.instance.uri_for(status),
 | 
						|
        }
 | 
						|
      end
 | 
						|
 | 
						|
      before do
 | 
						|
        Fabricate(:favourite, account: sender, status: status)
 | 
						|
      end
 | 
						|
 | 
						|
      it 'deletes favourite from sender to status' do
 | 
						|
        subject.perform
 | 
						|
        expect(sender.favourited?(status)).to be false
 | 
						|
      end
 | 
						|
    end
 | 
						|
  end
 | 
						|
end
 |