kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Improve totalKreditsEarned

Browse Source 
* Use a more reasonable size of integer
* Use better variable names (count != amount, balance != count)
This commit is contained in:
Basti
2019-04-27 21:01:51 +01:00
parent 3568d3c141
commit 555cb53c78
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apps/contribution/contracts/Contribution.sol
View File

@@ -127,13 +127,13 @@ contract Contribution is AragonApp {
}
}
function totalKreditsEarnedByContributor(uint32 contributorId, bool confirmedOnly) public view returns (uint256 count) {
uint256 tokenBalance = ownedContributions[contributorId].length;
for (uint256 i = 0; i < tokenBalance; i++) {
function totalKreditsEarnedByContributor(uint32 contributorId, bool confirmedOnly) public view returns (uint32 amount) {
uint256 tokenCount = ownedContributions[contributorId].length;
for (uint256 i = 0; i < tokenCount; i++) {
uint32 cId = ownedContributions[contributorId][i];
ContributionData memory c = contributions[cId];
if (block.number >= c.confirmedAtBlock || !confirmedOnly) {
count += c.amount; // should use safemath
amount += c.amount; // should use safemath
}
}
}