kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Only count not-vetoed contributions for total balances

Browse Source
This commit is contained in:
bumi 2019-06-08 17:49:24 +02:00
parent 555cb53c78
commit 6a64842415
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
apps/contribution/contracts/Contribution.sol
View File

@ -118,11 +118,11 @@ contract Contribution is AragonApp {
// Custom functions // Custom functions
// //
function totalKreditsEarned(bool confirmedOnly) public view returns (uint256 count) { function totalKreditsEarned(bool confirmedOnly) public view returns (uint256 amount) {
for (uint32 i = 1; i <= contributionsCount; i++) { for (uint32 i = 1; i <= contributionsCount; i++) {
ContributionData memory c = contributions[i]; ContributionData memory c = contributions[i];
if (block.number >= c.confirmedAtBlock || !confirmedOnly) { if (!c.vetoed && (block.number >= c.confirmedAtBlock || !confirmedOnly)) {
count += c.amount; // should use safemath amount += c.amount; // should use safemath
} }
} }
} }
@ -132,7 +132,7 @@ contract Contribution is AragonApp {
for (uint256 i = 0; i < tokenCount; i++) { for (uint256 i = 0; i < tokenCount; i++) {
uint32 cId = ownedContributions[contributorId][i]; uint32 cId = ownedContributions[contributorId][i];
ContributionData memory c = contributions[cId]; ContributionData memory c = contributions[cId];
if (block.number >= c.confirmedAtBlock || !confirmedOnly) { if (!c.vetoed && (block.number >= c.confirmedAtBlock || !confirmedOnly)) {
amount += c.amount; // should use safemath amount += c.amount; // should use safemath
} }
} }