Deprecate old add* methods #118

2019-04-24T19:53:25Z

fsmanuel commented

2019-04-24 19:53:25 +00:00

(Migrated from github.com)

As we no longer have the operator contract we can deprecate the redundant add methods.
Now it should be clear what is added from the contract name.

I think it's good to deprecate early. The deprecate function could be extended so we can add a version number for the removal.

As we no longer have the operator contract we can deprecate the redundant add methods. Now it should be clear what is added from the contract name. I think it's good to deprecate early. The deprecate function could be extended so we can add a version number for the removal.

bumi (Migrated from github.com) approved these changes 2019-04-24 19:57:51 +00:00

bumi commented

2019-04-24 20:08:17 +00:00

(Migrated from github.com)

utACK

raucao (Migrated from github.com) reviewed 2019-04-25 10:14:57 +00:00

raucao (Migrated from github.com) left a comment

Good idea!

Just have suggestions regarding the output/text.

Good idea! Just have suggestions regarding the output/text.

lib/contracts/contribution.js

raucao (Migrated from github.com) commented

2019-04-25 10:13:26 +00:00

    deprecate('The function `addContribution()` is deprecated and will be removed in the next major version. Use `add()` instead');

```suggestion deprecate('The function `addContribution()` is deprecated and will be removed in the next major version. Use `add()` instead'); ```

lib/contracts/proposal.js

raucao (Migrated from github.com) commented

2019-04-25 10:14:17 +00:00

    deprecate('The function `addProposal()` is deprecated and will be removed in the next major version. Use `add()` instead');

```suggestion deprecate('The function `addProposal()` is deprecated and will be removed in the next major version. Use `add()` instead'); ```

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/contracts#118