kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Update aragon CLI to latest version #139

Closed
bumi wants to merge 3 commits from chore/update-dependencies into master
pull from: chore/update-dependencies
merge into: :master
Conversation 5 Commits 3 Files Changed 12
+100222 -44564
bumi commented 2019-06-13 15:57:41 +00:00 (Migrated from github.com)
Copy Link
Copy Source

updated aragon-cli everywhere and ran a fresh npm install everywhere.
(removed node_modules and package-lock.json before installing)

updated aragon-cli everywhere and ran a fresh npm install everywhere. (removed node_modules and package-lock.json before installing)
raucao commented 2019-06-13 16:36:00 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Unfortunately, the build is still red. :/

Unfortunately, the build is still red. :/
raucao commented 2019-06-13 16:39:34 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Update: I get exactly the same error when npm installing from this branch with empty node_modules.

(Using npm 6.8.0)

Update: I get exactly the same error when `npm install`ing from this branch with empty `node_modules`. (Using npm 6.8.0)
raucao commented 2019-06-13 16:44:47 +00:00 (Migrated from github.com)
Copy Link
Copy Source

There seems to be some kind of chicken-and-egg problem. It only works when deleting the package lockfile beforehand. But a bootstrapped install then takes forever, due to the gazillion deps including native extensions.

There seems to be some kind of chicken-and-egg problem. It only works when deleting the package lockfile beforehand. But a bootstrapped install then takes forever, due to the gazillion deps including native extensions.
bumi commented 2019-06-13 20:53:07 +00:00 (Migrated from github.com)
Copy Link
Copy Source

It seems to me that a postinstall script defined in the package.json of the aragon-cli is doing something: https://github.com/aragon/aragon-cli/blob/master/packages/aragon-cli/scripts/fix-lockfile

fund also this related:
https://github.com/aragon/aragon-cli/blob/master/docs-internal/Dependencies.md#regenerate-the-lockfiles

It seems to me that a `postinstall` script defined in the package.json of the aragon-cli is doing something: https://github.com/aragon/aragon-cli/blob/master/packages/aragon-cli/scripts/fix-lockfile fund also this related: https://github.com/aragon/aragon-cli/blob/master/docs-internal/Dependencies.md#regenerate-the-lockfiles
bumi commented 2019-06-18 22:57:19 +00:00 (Migrated from github.com)
Copy Link
Copy Source

closing in favor of #140 and #142

closing in favor of #140 and #142

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
good first issue
Good for newcomers
 ipfs
rsk
scaling
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#139