kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Test token app #157

Merged
haythem96 merged 6 commits from tests/contracts-token into master 2019-07-31 15:17:38 +00:00
Conversation 5 Commits 6 Files Changed 4 +141 -5
haythem96 commented 2019-07-29 12:28:00 +00:00 (Migrated from github.com)
Copy Link

This PR add unit tests for the Token smart contracts. #103

This PR add unit tests for the Token smart contracts. #103
haythem96 commented 2019-07-31 13:00:41 +00:00 (Migrated from github.com)
Copy Link

can we merge this one @bumi ?

can we merge this one @bumi ?
bumi (Migrated from github.com) approved these changes 2019-07-31 14:02:35 +00:00
bumi (Migrated from github.com) left a comment
Copy Link

looks good to me. :shipit:
see that one comment, then we can merge it.

looks good to me. :shipit: see that one comment, then we can merge it.
apps/token/contracts/Token.sol
bumi (Migrated from github.com) commented 2019-07-31 14:00:46 +00:00
Copy Link

I think so far I always used keys like INVALID_AMOUNT instead of full messages.
This should make the code smaller and is enough to identify the error and potentially also map it to a full message

I think so far I always used keys like `INVALID_AMOUNT` instead of full messages. This should make the code smaller and is enough to identify the error and potentially also map it to a full message
haythem96 (Migrated from github.com) reviewed 2019-07-31 14:46:56 +00:00
apps/token/contracts/Token.sol
@ -24,2 +24,4 @@
require(amount > 0, "INVALID_AMOUNT");
uint256 amountInWei = amount.mul(1 ether);
_mint(contributorAccount, amountInWei);
haythem96 (Migrated from github.com) commented 2019-07-31 14:46:56 +00:00
Copy Link

@bumi is that cool ?

@bumi is that cool ?
bumi (Migrated from github.com) reviewed 2019-07-31 15:01:46 +00:00
apps/token/contracts/Token.sol
@ -24,2 +24,4 @@
require(amount > 0, "INVALID_AMOUNT");
uint256 amountInWei = amount.mul(1 ether);
_mint(contributorAccount, amountInWei);
bumi (Migrated from github.com) commented 2019-07-31 15:01:46 +00:00
Copy Link

just saw that I haven't done it everywhere. I thought about something like this: https://github.com/67P/kredits-contracts/blob/master/apps/contribution/contracts/Contribution.sol#L181

as that full string increases the contract and thus the deployment costs, afaik? so I thought it is better to use small strings.

just saw that I haven't done it everywhere. I thought about something like this: https://github.com/67P/kredits-contracts/blob/master/apps/contribution/contracts/Contribution.sol#L181 as that full string increases the contract and thus the deployment costs, afaik? so I thought it is better to use small strings.
haythem96 (Migrated from github.com) reviewed 2019-07-31 15:03:30 +00:00
apps/token/contracts/Token.sol
@ -24,2 +24,4 @@
require(amount > 0, "INVALID_AMOUNT");
uint256 amountInWei = amount.mul(1 ether);
_mint(contributorAccount, amountInWei);
haythem96 (Migrated from github.com) commented 2019-07-31 15:03:30 +00:00
Copy Link

ahh okaay (y)

ahh okaay (y)
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
Labels
Clear labels
good first issue
Good for newcomers
ipfs
rsk
scaling
bug
Something is not working
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg haythem hueso raucao slvrbckt
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#157
No description provided.
Delete Branch "tests/contracts-token"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?