kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Contributor update/serialization failing #168

New Issue
Closed
opened 2019-08-14 13:28:22 +00:00 by raucao · 4 comments
raucao commented 2019-08-14 13:28:22 +00:00 (Migrated from github.com)
Copy Link
Copy Source

No idea where it's turning the UID into a string, but at the point where kredits-web is calling the update function it's still a number:

Screenshot from 2019-08-14 15-25-55

I think this is a regression, because it worked before, and we changed some things about serialization not long ago.

No idea where it's turning the UID into a string, but at the point where `kredits-web` is calling the update function it's still a number: ![Screenshot from 2019-08-14 15-25-55](https://user-images.githubusercontent.com/842/63024711-0fc71800-bea8-11e9-88c2-9c8b6ea14dd8.png) I think this is a regression, because it worked before, and we changed some things about serialization not long ago.
raucao commented 2019-08-14 16:51:15 +00:00 (Migrated from github.com)
Copy Link
Copy Source

LOL, I just tried it locally, and instead of updating the existing accounts, it added two new sets for the updated accounts at once:

Screenshot from 2019-08-14 18-48-26

LOL, I just tried it locally, and instead of updating the existing accounts, it added *two* new sets for the updated accounts at once: ![Screenshot from 2019-08-14 18-48-26](https://user-images.githubusercontent.com/842/63039827-722e1180-bec4-11e9-876e-089a0d29c7ff.png)
raucao commented 2019-08-14 16:56:05 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Interestingly, there's no string vs. integer validation issue locally, but a different number error after updating the contributor. It looks like the update event is returning a larger number type than a normal contributor GET. No idea yet what's happening exactly.

Interestingly, there's no string vs. integer validation issue locally, but a different number error *after* updating the contributor. <del>It looks like the update event is returning a larger number type than a normal contributor GET</del>. No idea yet what's happening exactly.
raucao commented 2019-09-04 11:05:03 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Note from call: we'll try to revert the change that broke it, and re-submit it in the future, after more testing.

Note from call: we'll try to revert the change that broke it, and re-submit it in the future, after more testing.
raucao commented 2019-09-16 11:38:19 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@bumi What about reverting that commit? It's been almost a week again...

@bumi What about reverting that commit? It's been almost a week again...
raucao added the bug label 2022-07-16 15:18:49 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
good first issue
Good for newcomers
 ipfs
rsk
scaling
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#168