WIP: Install aragon vault app into Kredits kit #173

2019-08-27T13:32:33Z

haythem96 commented

2019-08-27 13:32:33 +00:00

(Migrated from github.com)

for Kredits DAO to accept funds (ETH or ERC20 token) it need a vault app to manage(receive & hold) those funds. And aragon apps packages have a Vault app that do the same functionalities that we need, so in this code it just import that app from the @aragon/vault-app package and install it into Kredits kit.

Vault app doc: https://wiki.aragon.org/dev/apps/vault/

Related to #169

for Kredits DAO to accept funds (ETH or ERC20 token) it need a vault app to manage(receive & hold) those funds. And aragon apps packages have a Vault app that do the same functionalities that we need, so in this code it just import that app from the @aragon/vault-app package and install it into Kredits kit. Vault app doc: https://wiki.aragon.org/dev/apps/vault/ Related to #169

bumi commented

2019-08-28 17:44:33 +00:00

(Migrated from github.com)

This looks actually pretty cool. 👍
The main question will be who will have the transfer role. To test we could add a CLI script to transfer from the vault.
Also we should add a JS wrapper class for the vault to be able to easily interact with it from JS.

This looks actually pretty cool. :+1: The main question will be who will have the transfer role. To test we could add a CLI script to transfer from the vault. Also we should add a JS wrapper class for the vault to be able to easily interact with it from JS.

👍 1

haythem96 commented

2019-08-29 08:28:21 +00:00

(Migrated from github.com)

This looks actually pretty cool.
The main question will be who will have the transfer role. To test we could add a CLI script to transfer from the vault.
Also we should add a JS wrapper class for the vault to be able to easily interact with it from JS.

For the transfer role, I think the Reward app (when it is ready) should have it

> This looks actually pretty cool. > The main question will be who will have the transfer role. To test we could add a CLI script to transfer from the vault. > Also we should add a JS wrapper class for the vault to be able to easily interact with it from JS. For the transfer role, I think the Reward app (when it is ready) should have it

raucao commented

2019-08-29 10:51:31 +00:00

(Migrated from github.com)

Could you explain a bit what this does and how it works? The PR description is basically empty. Thanks!

haythem96 commented

2019-08-29 11:39:04 +00:00

(Migrated from github.com)

Could you explain a bit what this does and how it works? The PR description is basically empty. Thanks!

Yeah sorry about that... need to better write PR description

So basically for Kredits DAO to accept funds (ETH or ERC20 token) it need a vault app to manage(receive & hold) those funds. And aragon apps packages have a Vault app that do the same functionalities that we need, so in this code it just import that app from the @aragon/vault-app package and install it into Kredits kit.

> Could you explain a bit what this does and how it works? The PR description is basically empty. Thanks! Yeah sorry about that... need to better write PR description So basically for Kredits DAO to accept funds (ETH or ERC20 token) it need a vault app to manage(receive & hold) those funds. And aragon apps packages have a `Vault` app that do the same functionalities that we need, so in this code it just import that app from the `@aragon/vault-app` package and install it into Kredits kit.

raucao commented

2019-08-29 11:42:57 +00:00

(Migrated from github.com)

Maybe you could link the documentation of the Vault app?

👍 1

haythem96 commented

2019-09-12 09:29:31 +00:00

(Migrated from github.com)

Should we add the rewarding app before so that we can assign to it the Transfer role of the vault app ?

Should we add the rewarding app before so that we can assign to it the `Transfer` role of the vault app ?

raucao commented

2021-11-14 22:46:24 +00:00