kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Chore/dependency updates #196

Merged
bumi merged 4 commits from chore/dependency-updates into master 2020-05-27 14:22:41 +00:00
Conversation 4 Commits 4 Files Changed 10 +16366 -3973
bumi commented 2020-05-27 08:57:43 +00:00 (Migrated from github.com)
Copy Link

Updated the npm dependencies to the latest versions

missing:

  • ipfs-http-client - which has some breaking changes. I think it is not a problem for us but needs to be tested
  • solhint - wich also has a breaking change and now needs pretier for codestyle linting. I did not want that additional dependency now. Also we probably needs to improve the linting of the solidity files
Updated the npm dependencies to the latest versions missing: - [ ] ipfs-http-client - which has some breaking changes. I think it is not a problem for us but needs to be tested - [ ] solhint - wich also has a breaking change and now needs pretier for codestyle linting. I did not want that additional dependency now. Also we probably needs to improve the linting of the solidity files
raucao (Migrated from github.com) approved these changes 2020-05-27 09:06:17 +00:00
raucao (Migrated from github.com) left a comment
Copy Link

LGTM (didn't test locally)

LGTM (didn't test locally)
bumi commented 2020-05-27 12:05:18 +00:00 (Migrated from github.com)
Copy Link

the new IPFS package now returns a Object [AsyncGenerator] {} and no longer just a promise.
we should update that package in an separate pull request. same for the solhint package.

I've tested all the scripts (bootstrap, etc.) and seems to work fine.

the new IPFS package now returns a `Object [AsyncGenerator] {} ` and no longer just a promise. we should update that package in an separate pull request. same for the solhint package. I've tested all the scripts (bootstrap, etc.) and seems to work fine.
👍 1
bumi commented 2020-05-27 12:09:23 +00:00 (Migrated from github.com)
Copy Link

those warnings: https://github.com/67P/kredits-contracts/network/alerts should be fine now, too.
they are all from within the app/ package-lock.json

those warnings: https://github.com/67P/kredits-contracts/network/alerts should be fine now, too. they are all from within the app/ package-lock.json
raucao commented 2020-05-27 12:53:10 +00:00 (Migrated from github.com)
Copy Link

utACK

utACK
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
Labels
Clear labels
good first issue
Good for newcomers
ipfs
rsk
scaling
bug
Something is not working
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg haythem hueso raucao slvrbckt
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#196
No description provided.
Delete Branch "chore/dependency-updates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?