Hardhat #213
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "hardhat"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
byebye aragon apps
refactoring the contracts for usage with hardhat
https://community.kosmos.org/t/the-road-to-mainnet/115
ToDos:
@bumi wow! What a diff. I'm jealous. Looks like all the hacks are gone...
Can someone look at the permissions? @raucao
I am a bit 🧠 💀 today
new wallet if needed:
~ » hardhat create-wallet
start a dev node:
~ » hardhat node --network hardhat
deploy a new DAO:
~ » hardhat run scripts/create-proxy.js --network localhost
run seeds:
~ » hardhat run scripts/seeds.js --network localhost
scripts:
~ » hardhat run scripts/list-reimbursements.js --network localhost
when deploying to RSK:
setting a
DEPLOY_KEY
is possible:https://github.com/67P/kredits-contracts/pull/213/files#diff-cf4ef7c51dc9f81cad1d504da0d1c3a3437ac7b7d1374ee7127886cf1d1a5092R72
~ » DEPLOY_KEY=0x0... hardhat run scripts/seeds.js --network rsk
Tested with node 12 and the fixed command for deploying the proxy. Almost works!
However, some of the seeds raised exceptions. Adding contributions failed with "Must have Kredits", and adding reimbursements failed with "Core only". These seem like actual logical bugs with the working contracts to me.
yeah, seems like. maybe we should a check that this is only the case if there are less than X kredits ?
Hmm, the
isCore
check in the contract still uses IDs, not kredits. So I wonder which validation is failing there.@bumi Seeds are all successful now! 👏
Kredits Web wasn't able to find the contracts with any of the addresses in
lib/addresses
though. The DAO address seems to not have been updated in that file.hmm. but when you run the
create-proxy.js
script the addresses file changes?do you have that linked to kredits-web?
The contract addresses do, but the DAO and KreditsKit don't.
what is the exact error there? because we don't have any kit/DAO anymore.
kredits.Contributor will directly load the contract address from the JSON now.
kredits.setup()
results in:@bumi Could you perhaps remove all scripts currently remaining in
package.json
that are not relevant anymore? I'm trying to compile the contracts, but those commands are also failing. I think they're just outdated.Edit: and ideally the bootstrap command could be updated to include all current/new steps to compile, deploy, and seed from scratch. (I'm updating the Kredits Web README on the side while testing this branch.)
This line makes the script exit in node 14 and 16 (but not 12), but unfortunately without throwing an error. I wasn't able to find out why yet.
@bumi Please check the kredits chat room for my reporting of a problem with Reimbursement contract.
All function calls other than
add()
seem to be failing consistently. Everything else seems to work great, incl. on node.js 14 and 16, now (since53fafc1c78
).@bumi Were you able to confirm that the
Reimbursement
functions either work or fail on your (new) machine?@bumi Which of the todo items in the PR description are actually still open? Also, what do you think about my proposal on chat?
I finished up all the work on the Kredits Web side last Tuesday, including the final touches to the current reimbursement code as well as switching everything from ETH/WBTC to RSK/BTC and showing the balance of the multisig wallet in the budget section. Would be useful if someone could review my work, so we can merge and continue with the rest:
I tested everything locally again and added an example on how to upgrade a contract.
Let's merge this and run it on RSK testnet again.
Deployment and upgrading works fine on rinkeby (I did not try permissions, though).
but I fail to do it on RSK.
Error:
When I look at the deploy and upgrade transactions on rinkeby those look different to the ones on RSK
Somewhat it seems some transactions are missing on RSK?!
one deploy and upgrade run on rinkeby:

one deploy and upgrade run on rsk (?!):

(the last transaction is probably from another upgrade run)
Let's merge!