kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Add linting and contract builds to CI #222

Merged
raucao merged 5 commits from feature/183-ci_linting into master 2022-08-10 16:31:31 +00:00
Conversation 1 Commits 5 Files Changed 1 +27 -1
raucao commented 2022-08-09 15:33:44 +00:00
Owner
Copy Link

Now fails CI on contract linting and cancels the last step after the first failed step.

Probably a good idea to solve #183 as a PR against this one?

I have commented the contract linting step for now, so it can be used for #183, but done separately from other work. So this is good to merge, pending an approval or change request.

refs #183

Now fails CI on contract linting and cancels the last step after the first failed step. ~~Probably a good idea to solve #183 as a PR against this one?~~ I have commented the contract linting step for now, so it can be used for #183, but done separately from other work. So this is good to merge, pending an approval or change request. refs #183
raucao added the
kredits-1
 label 2022-08-09 15:33:44 +00:00
raucao added 4 commits 2022-08-09 15:33:45 +00:00
CI: Split setup and test steps
All checks were successful
continuous-integration/drone/push Build is passing
Details
51e50e7c46
Nicer step names
Some checks failed
continuous-integration/drone/push Build is failing
Details
fd93993a1b
Build contracts in CI
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
98348dc544
raucao requested review from bumi 2022-08-09 15:35:55 +00:00
raucao requested review from hueso 2022-08-09 15:35:55 +00:00
raucao added 1 commit 2022-08-10 10:19:12 +00:00
Disable contract linting for now
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
46b1bbfbf2 
So we can continue with actual tests, and fix the linter warnings
separately from other ongoing work.
hueso approved these changes 2022-08-10 15:56:39 +00:00
raucao merged commit 2b05be1897 into master 2022-08-10 16:31:31 +00:00
raucao deleted branch feature/183-ci_linting 2022-08-10 16:31:32 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
hueso
Labels
Clear labels
good first issue
Good for newcomers
ipfs
rsk
scaling
bug
Something is not working
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
kredits-1
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg haythem hueso raucao slvrbckt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#222
No description provided.
Delete Branch "feature/183-ci_linting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?