Constructor configuration options #40
正在加载...
x
在新工单中引用
屏蔽一个用户
没有提供说明。
删除分支 feature/constructor-options
删除分支是永久的。虽然已删除的分支在实际被删除前有可能会短时间存在，但这在大多数情况下无法撤销。是否继续？
删除分支是永久的。虽然已删除的分支在实际被删除前有可能会短时间存在，但这在大多数情况下无法撤销。是否继续？
This changes the function signature of the constructor but allows us to
pass any options.
Mainly this is now used for the ipfs configs.
Ref #37
this is a breaking change but kredits-web is currently not setting the IPFS config and hubot-kredits is using the setup function... so should be good to merge and then we can update the 'clients'
Only a little suggestion.
Do we need to track the update of hubot-kredits in the open issue?
What about a destructuring of the options to make it more easy to see the used options?
You sneaked that one in but I ❤️ it,
👍
@ -7,3 +7,3 @@if (!config) {config = {host: 'localhost', port: '5001', protocol: 'http'};config = { host: 'localhost', port: '5001', protocol: 'http' };}👍
Typo. :)
iPad...
something like this:
let { address, abis, ipfsConfig } = optionsis that correct?
what do you mean with " track the update of hubot-kredits in the open issue"?
Jup
I meant in the code. Someone coding on an iPad? :D
@bumi I don't know why I wrote it... I'll merge.
Ah you mean the
chaiID😆 ? Not yet coding on an iPad...It was a bad idea to come back to Hamburg. Volley outside...
🌞