kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Constructor configuration options #40

Merged
bumi merged 2 commits from feature/constructor-options into master 2018-04-26 10:32:13 +00:00
Conversation 11 Commits 2 Files Changed 2
+8 -11
bumi commented 2018-04-23 09:13:23 +00:00 (Migrated from github.com)
Copy Link
Copy Source

This changes the function signature of the constructor but allows us to
pass any options.
Mainly this is now used for the ipfs configs.

Ref #37

This changes the function signature of the constructor but allows us to pass any options. Mainly this is now used for the ipfs configs. Ref #37
bumi commented 2018-04-23 09:17:29 +00:00 (Migrated from github.com)
Copy Link
Copy Source

this is a breaking change but kredits-web is currently not setting the IPFS config and hubot-kredits is using the setup function... so should be good to merge and then we can update the 'clients'

this is a breaking change but kredits-web is currently not setting the IPFS config and hubot-kredits is using the setup function... so should be good to merge and then we can update the 'clients'
fsmanuel (Migrated from github.com) approved these changes 2018-04-25 21:11:44 +00:00
fsmanuel (Migrated from github.com) left a comment
Copy Link
Copy Source

Only a little suggestion.
Do we need to track the update of hubot-kredits in the open issue?

Only a little suggestion. Do we need to track the update of hubot-kredits in the open issue?
lib/kredits.js
fsmanuel (Migrated from github.com) commented 2018-04-25 21:03:30 +00:00
Copy Link
Copy Source

What about a destructuring of the options to make it more easy to see the used options?

What about a destructuring of the options to make it more easy to see the used options?
fsmanuel (Migrated from github.com) commented 2018-04-25 21:09:37 +00:00
Copy Link
Copy Source

You sneaked that one in but I ❤️ it,

You sneaked that one in but I ❤️ it,
lib/kredits.js
fsmanuel (Migrated from github.com) commented 2018-04-25 21:07:26 +00:00
Copy Link
Copy Source

👍

👍
lib/utils/ipfs.js
@@ -7,3 +7,3 @@
if (!config) {
config = {host: 'localhost', port: '5001', protocol: 'http'};
config = { host: 'localhost', port: '5001', protocol: 'http' };
}
fsmanuel (Migrated from github.com) commented 2018-04-25 21:05:30 +00:00
Copy Link
Copy Source

👍

👍
raucao (Migrated from github.com) reviewed 2018-04-25 21:14:08 +00:00
lib/kredits.js
raucao (Migrated from github.com) commented 2018-04-25 21:14:08 +00:00
Copy Link
Copy Source

Typo. :)

Typo. :)
fsmanuel (Migrated from github.com) reviewed 2018-04-25 21:43:56 +00:00
lib/kredits.js
fsmanuel (Migrated from github.com) commented 2018-04-25 21:43:56 +00:00
Copy Link
Copy Source

iPad...

iPad...
bumi (Migrated from github.com) reviewed 2018-04-26 00:47:10 +00:00
lib/kredits.js
bumi (Migrated from github.com) commented 2018-04-26 00:47:10 +00:00
Copy Link
Copy Source

something like this:
let { address, abis, ipfsConfig } = options
is that correct?

something like this: ` let { address, abis, ipfsConfig } = options ` is that correct?
bumi commented 2018-04-26 00:49:44 +00:00 (Migrated from github.com)
Copy Link
Copy Source

what do you mean with " track the update of hubot-kredits in the open issue"?

what do you mean with " track the update of hubot-kredits in the open issue"?
fsmanuel (Migrated from github.com) reviewed 2018-04-26 08:08:46 +00:00
lib/kredits.js
fsmanuel (Migrated from github.com) commented 2018-04-26 08:08:45 +00:00
Copy Link
Copy Source

Jup

Jup
raucao (Migrated from github.com) reviewed 2018-04-26 10:29:43 +00:00
lib/kredits.js
raucao (Migrated from github.com) commented 2018-04-26 10:29:43 +00:00
Copy Link
Copy Source

I meant in the code. Someone coding on an iPad? :D

I meant in the code. Someone coding on an iPad? :D
fsmanuel commented 2018-04-26 10:32:07 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@bumi I don't know why I wrote it... I'll merge.

@bumi I don't know why I wrote it... I'll merge.
fsmanuel (Migrated from github.com) reviewed 2018-04-26 10:52:33 +00:00
lib/kredits.js
fsmanuel (Migrated from github.com) commented 2018-04-26 10:52:33 +00:00
Copy Link
Copy Source

Ah you mean the chaiID 😆 ? Not yet coding on an iPad...
It was a bad idea to come back to Hamburg. Volley outside...

Ah you mean the `chaiID` 😆 ? Not yet coding on an iPad... It was a bad idea to come back to Hamburg. Volley outside...
bumi (Migrated from github.com) reviewed 2018-04-26 11:50:58 +00:00
lib/kredits.js
bumi (Migrated from github.com) commented 2018-04-26 11:50:58 +00:00
Copy Link
Copy Source

🌞

:sun_with_face:
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
fsmanuel
bumi
Labels
Clear labels
good first issue
Good for newcomers
 ipfs
rsk
scaling
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#40