Let (unregistered) contributors claim Contributions/Tokens #54
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Right now every contributor requires an Ethereum wallet and needs to be added as a contributor before tokens can be issued. This is a bit of an overhead and all contributors need to be convinced using kredits before proposals can be made.
To make this easier we should think of a concept to claim contributions AFTER the voting. So proposals can be created and executed for any contribution even if the contributor is not yet in the system.
I was thinking about this just now, and here's a thought: how about we handle this entirely off-chain for now, and simply queue those contributions in hubot-kredits, with the site and account that it gets the hook from?
We could then listen to contributor creation and update events from the contract and match those to the queued contributions. Meaning when someone's details are added, no matter if for the first time or updating with a new site account later on, the bot can go and create those contributions using the date and time it recorded them at.
This solves a few problems at once, most notably that there's no complex logic on the blockchain that needs to use oracles or other means of identifying contributors. From the blockchain perspective, it's basically a no-code solution. And from the application/user/UX perspective it's much easier than other complex processes. At least as a viable first solution.
WDYT?
YES, let's do this off-chain for now.
and we should do any of such blockers off-chain for now until we have enough time to get it working on-chain.
Forgot to add a note here, since we changed the architecture to not require accounts/addresses per se, but the
addContributor
function still does.So, as a temporary workaround, we just generated throwaway accounts and ditched the private keys without looking at them, when creating a new profile for someone else.