kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Unify hashDigest #75

New Issue
Closed
opened 2019-04-05 16:41:14 +00:00 by fsmanuel · 2 comments
fsmanuel commented 2019-04-05 16:41:14 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Can we address this issue as well:

https://github.com/67P/kredits-contracts/blob/93e0b30b357e69a892b0c3187a813b95f0a1d619/lib/contracts/contributor.js#L24-L25

I have 17 9 ipfsHash matches in https://github.com/67P/kredits-contracts/blob/master/apps/contributor/contracts/Contributor.sol

Update:
I think we don't use this function at all:
https://github.com/67P/kredits-contracts/blob/93e0b30b357e69a892b0c3187a813b95f0a1d619/apps/contributor/contracts/Contributor.sol#L72-L80

Can we address this issue as well: https://github.com/67P/kredits-contracts/blob/93e0b30b357e69a892b0c3187a813b95f0a1d619/lib/contracts/contributor.js#L24-L25 I have ~17~ 9 `ipfsHash` matches in https://github.com/67P/kredits-contracts/blob/master/apps/contributor/contracts/Contributor.sol Update: I think we don't use this function at all: https://github.com/67P/kredits-contracts/blob/93e0b30b357e69a892b0c3187a813b95f0a1d619/apps/contributor/contracts/Contributor.sol#L72-L80
👍 1
raucao commented 2019-04-05 18:25:26 +00:00 (Migrated from github.com)
Copy Link
Copy Source

PRs welcome!

PRs welcome!
bumi commented 2019-04-05 23:16:21 +00:00 (Migrated from github.com)
Copy Link
Copy Source

actually I have this code that I just commited: https://github.com/67P/kredits-contracts/pull/79
but this needs testing...

actually I have this code that I just commited: https://github.com/67P/kredits-contracts/pull/79 but this needs testing...
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
good first issue
Good for newcomers
 ipfs
rsk
scaling
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#75
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?