Add pagination for .all methods #96
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "feature/pagination"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I removed rsvp as a dependency as we only use Promise.all
Since the setup only works for me with yarn it would be great if someone can run
npm installand push the package-lock.json into this branch.looks great!
awesome that those for loops are gone.
@ -0,0 +34,4 @@return Array.from({ length: size }, mapFunction);}module.exports = function paged(recordCount, options = {}) {the call would be somthing like:
page(100, { order: 'desc', page: { size: 10, number: 1} })?was wondering if that is less verbose?
page(100, { order: 'desc', per_page: 10, page: 1 })- but that's probably my ruby will_paginate head :D@ -0,0 +34,4 @@return Array.from({ length: size }, mapFunction);}module.exports = function paged(recordCount, options = {}) {Yeah, I'm not sure which one is better. I took it from JSON:API spec but I don't care how we do it.
@skddc what is your preference?
One thing I noticed is that we don't return any information on how many records/pages we have. This is not a problem if we use infinite scrolling as the code always checks that the results are in range. But if we want to have a pagination with pages in the frontend that might be a problem. We can always use
functions.*Countbut would duplicate logic...To make it easier I'll add a
countproperty on the contract and we can iterate from there.Updated the code. Not sure if
Recordis the best name...Very cool stuff. I'll work on using the contracts in production before getting to this, so that the kredits on these PRs can actually be recorded. ;)
@ -0,0 +34,4 @@return Array.from({ length: size }, mapFunction);}module.exports = function paged(recordCount, options = {}) {ah ok, then I guess JSON:API spec is better!
I think we can optimize if we run in that problem, so a
countfunction should be enough now.so let's make this the first recorded github contribution on or rinkeby production org.
I will merge this once hubot is deployed and configured...(and I hope it then works :D)
@bumi What do you need for my contributor profile? Can we take my old one?
see contributor schema.
ethereum address, name, github user+id, maybe wiki username