kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Add kredits-formatter and additionally format balance #108

Merged
bumi merged 5 commits from feature/kredits-formatter into master 2019-04-24 13:20:45 +00:00
Conversation 9 Commits 5 Files Changed 3 +15 -3
3 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/contracts/contributor.js
View File

@ -1,5 +1,6 @@
raucao commented 2019-04-19 10:04:15 +00:00 (Migrated from github.com)
Review
Copy Link

As this is not a class, but just one formatting function, I'd call the file format_kredits and import it as formatKredits().

As this is not a class, but just one formatting function, I'd call the file `format_kredits` and import it as `formatKredits()`.
raucao commented 2019-04-19 10:04:15 +00:00 (Migrated from github.com)
Review
Copy Link

As this is not a class, but just one formatting function, I'd call the file format_kredits and import it as formatKredits().

As this is not a class, but just one formatting function, I'd call the file `format_kredits` and import it as `formatKredits()`.
fsmanuel commented 2019-04-19 10:18:25 +00:00 (Migrated from github.com)
Review
Copy Link

I think the convention is a dash for filenames in JS.
👍 formatKredits()

I think the convention is a dash for filenames in JS. 👍 `formatKredits()`
fsmanuel commented 2019-04-19 10:18:25 +00:00 (Migrated from github.com)
Review
Copy Link

I think the convention is a dash for filenames in JS.
👍 formatKredits()

I think the convention is a dash for filenames in JS. 👍 `formatKredits()`
const Record = require('./record'); const Record = require('./record');
const ContributorSerializer = require('../serializers/contributor'); const ContributorSerializer = require('../serializers/contributor');
const formatKredits = require('../utils/format-kredits');
raucao commented 2019-04-19 10:04:15 +00:00 (Migrated from github.com)
Review
Copy Link

As this is not a class, but just one formatting function, I'd call the file format_kredits and import it as formatKredits().

As this is not a class, but just one formatting function, I'd call the file `format_kredits` and import it as `formatKredits()`.
fsmanuel commented 2019-04-19 10:18:25 +00:00 (Migrated from github.com)
Review
Copy Link

I think the convention is a dash for filenames in JS.
👍 formatKredits()

I think the convention is a dash for filenames in JS. 👍 `formatKredits()`
class Contributor extends Record { class Contributor extends Record {
get count () { get count () {
@ -8,9 +9,10 @@ class Contributor extends Record {
raucao commented 2019-04-19 10:04:15 +00:00 (Migrated from github.com)
Review
Copy Link

As this is not a class, but just one formatting function, I'd call the file format_kredits and import it as formatKredits().

As this is not a class, but just one formatting function, I'd call the file `format_kredits` and import it as `formatKredits()`.
raucao commented 2019-04-19 10:04:15 +00:00 (Migrated from github.com)
Review
Copy Link

As this is not a class, but just one formatting function, I'd call the file format_kredits and import it as formatKredits().

As this is not a class, but just one formatting function, I'd call the file `format_kredits` and import it as `formatKredits()`.
fsmanuel commented 2019-04-19 10:18:25 +00:00 (Migrated from github.com)
Review
Copy Link

I think the convention is a dash for filenames in JS.
👍 formatKredits()

I think the convention is a dash for filenames in JS. 👍 `formatKredits()`
fsmanuel commented 2019-04-19 10:18:25 +00:00 (Migrated from github.com)
Review
Copy Link

I think the convention is a dash for filenames in JS.
👍 formatKredits()

I think the convention is a dash for filenames in JS. 👍 `formatKredits()`
getById(id) { getById(id) {
return this.functions.getContributorById(id) return this.functions.getContributorById(id)
.then((data) => { .then(data => {
raucao commented 2019-04-19 10:04:15 +00:00 (Migrated from github.com)
Review
Copy Link

As this is not a class, but just one formatting function, I'd call the file format_kredits and import it as formatKredits().

As this is not a class, but just one formatting function, I'd call the file `format_kredits` and import it as `formatKredits()`.
fsmanuel commented 2019-04-19 10:18:25 +00:00 (Migrated from github.com)
Review
Copy Link

I think the convention is a dash for filenames in JS.
👍 formatKredits()

I think the convention is a dash for filenames in JS. 👍 `formatKredits()`
raucao commented 2019-04-19 10:04:15 +00:00 (Migrated from github.com)
Review
Copy Link

As this is not a class, but just one formatting function, I'd call the file format_kredits and import it as formatKredits().

As this is not a class, but just one formatting function, I'd call the file `format_kredits` and import it as `formatKredits()`.
fsmanuel commented 2019-04-19 10:18:25 +00:00 (Migrated from github.com)
Review
Copy Link

I think the convention is a dash for filenames in JS.
👍 formatKredits()

I think the convention is a dash for filenames in JS. 👍 `formatKredits()`
data.balanceInt = formatKredits(data.balance);
raucao commented 2019-04-19 10:04:15 +00:00 (Migrated from github.com)
Review
Copy Link

As this is not a class, but just one formatting function, I'd call the file format_kredits and import it as formatKredits().

As this is not a class, but just one formatting function, I'd call the file `format_kredits` and import it as `formatKredits()`.
fsmanuel commented 2019-04-19 10:18:25 +00:00 (Migrated from github.com)
Review
Copy Link

I think the convention is a dash for filenames in JS.
👍 formatKredits()

I think the convention is a dash for filenames in JS. 👍 `formatKredits()`
return this.ipfs.catAndMerge(data, ContributorSerializer.deserialize); return this.ipfs.catAndMerge(data, ContributorSerializer.deserialize);
}); })
raucao commented 2019-04-19 10:04:15 +00:00 (Migrated from github.com)
Review
Copy Link

As this is not a class, but just one formatting function, I'd call the file format_kredits and import it as formatKredits().

As this is not a class, but just one formatting function, I'd call the file `format_kredits` and import it as `formatKredits()`.
fsmanuel commented 2019-04-19 10:18:25 +00:00 (Migrated from github.com)
Review
Copy Link

I think the convention is a dash for filenames in JS.
👍 formatKredits()

I think the convention is a dash for filenames in JS. 👍 `formatKredits()`
raucao commented 2019-04-19 10:04:15 +00:00 (Migrated from github.com)
Review
Copy Link

As this is not a class, but just one formatting function, I'd call the file format_kredits and import it as formatKredits().

As this is not a class, but just one formatting function, I'd call the file `format_kredits` and import it as `formatKredits()`.
fsmanuel commented 2019-04-19 10:18:25 +00:00 (Migrated from github.com)
Review
Copy Link

I think the convention is a dash for filenames in JS.
👍 formatKredits()

I think the convention is a dash for filenames in JS. 👍 `formatKredits()`
} }
filterByAccount(search) { filterByAccount(search) {

raucao commented 2019-04-19 10:04:15 +00:00 (Migrated from github.com)
Review
Copy Link

As this is not a class, but just one formatting function, I'd call the file format_kredits and import it as formatKredits().

As this is not a class, but just one formatting function, I'd call the file `format_kredits` and import it as `formatKredits()`.
raucao commented 2019-04-19 10:04:15 +00:00 (Migrated from github.com)
Review
Copy Link

As this is not a class, but just one formatting function, I'd call the file format_kredits and import it as formatKredits().

As this is not a class, but just one formatting function, I'd call the file `format_kredits` and import it as `formatKredits()`.
fsmanuel commented 2019-04-19 10:18:25 +00:00 (Migrated from github.com)
Review
Copy Link

I think the convention is a dash for filenames in JS.
👍 formatKredits()

I think the convention is a dash for filenames in JS. 👍 `formatKredits()`
fsmanuel commented 2019-04-19 10:18:25 +00:00 (Migrated from github.com)
Review
Copy Link

I think the convention is a dash for filenames in JS.
👍 formatKredits()

I think the convention is a dash for filenames in JS. 👍 `formatKredits()`

10
lib/utils/format-kredits.js Normal file
View File

@ -0,0 +1,10 @@
const ethersUtils = require('ethers').utils;
module.exports = function (value, options = {}) {
let etherValue = ethersUtils.formatEther(value);
if (options.asFloat) {
return parseFloat(etherValue);
} else {
return parseInt(etherValue);
}
}

2
scripts/list-contributors.js
View File

@ -28,7 +28,7 @@ module.exports = async function(callback) {
c.account, c.account,
`${c.name}`, `${c.name}`,
c.isCore, c.isCore,
ethers.utils.formatEther(c.balance), c.balanceInt.toString(),
c.totalKreditsEarned.toString(), c.totalKreditsEarned.toString(),
c.contributionsCount.toString(), c.contributionsCount.toString(),
c.ipfsHash c.ipfsHash