Contributor app tests #143

Merged
haythem96 merged 26 commits from tests/contracts-contributor into master 2019-07-22 06:55:23 +00:00
2 changed files with 149 additions and 148 deletions
Showing only changes of commit 42d4752d58 - Show all commits

View File

@ -28,5 +28,6 @@ module.exports = {
named: 'always',
asyncArrow: 'always',
}],
'indent': ['error', 2]
}
}

View File

@ -10,161 +10,161 @@ const { assertRevert } = require('@aragon/test-helpers/assertThrow');
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
const ZERO_ADDR = '0x0000000000000000000000000000000000000000';
contract('Contributor app', (accounts) => {
let kernelBase, aclBase, daoFactory, r, dao, acl, contributor;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
const root = accounts[0];
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
const member1 = accounts[1];
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let kernelBase, aclBase, daoFactory, r, dao, acl, contributor;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
const root = accounts[0];
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
const member1 = accounts[1];
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
// eslint-disable-next-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
before(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
kernelBase = await getContract('Kernel').new(true); // petrify immediately
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
aclBase = await getContract('ACL').new();
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
daoFactory = await getContract('DAOFactory').new(kernelBase.address, aclBase.address, ZERO_ADDR);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
r = await daoFactory.newDAO(root);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
dao = getContract('Kernel').at(r.logs.filter(l => l.event == 'DeployDAO')[0].args.dao);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
acl = getContract('ACL').at(await dao.acl());
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
//create dao mamnager permission for coin owner
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await acl.createPermission(
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
root,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
dao.address,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await dao.APP_MANAGER_ROLE(),
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
root,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
{ from: root }
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
//get new app instance from DAO
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
const receipt = await dao.newAppInstance(
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
'0x1234',
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
(await Contributor.new()).address,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
0x0,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
false,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
{ from: root }
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
contributor = Contributor.at(
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
receipt.logs.filter(l => l.event == 'NewAppProxy')[0].args.proxy
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
//apps id
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let appsId = [];
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
appsId[0] = namehash("kredits-contribution");
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
appsId[1] = namehash("kredits-contributor");
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
appsId[2] = namehash("kredits-proposal");
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
appsId[3] = namehash("kredits-token");
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
//init contributor (app)
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.initialize(root, appsId);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
//create manage contributors role
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await acl.createPermission(
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
root,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
contributor.address,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.MANAGE_CONTRIBUTORS_ROLE(),
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
root,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
{ from: root }
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
describe("Owner default space permissions", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it('check owner is token issuer', async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let manageContributorPermission = await acl.hasPermission(root, contributor.address, await contributor.MANAGE_CONTRIBUTORS_ROLE());
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
// eslint-disable-next-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
assert.equal(manageContributorPermission, true);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
describe("Add contributor", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let account = root;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let hashDigest = '0x0';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let hashFunction = 0;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let hashSize = 0;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it("should revert when add contributor from an address that does not have permission", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
return assertRevert(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.addContributor(account, hashDigest, hashFunction, hashSize, { from: member1});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
'sender does not have permission';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it('add contributor', async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let contributorCount = await contributor.coreContributorsCount();
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.addContributor(account, hashDigest, hashFunction, hashSize);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
// eslint-disable-next-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
assert.equal(await contributor.addressExists(account), true);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let contributorCountAfter = await contributor.coreContributorsCount();
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
// eslint-disable-next-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
assert.equal(await contributorCountAfter.toNumber(), parseInt(contributorCount)+1);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it("should revert when add contributor with an address that already exist", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
return assertRevert(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.addContributor(account, hashDigest, hashFunction, hashSize, { from: member1});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
'address already exist';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
describe("Update contributor", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let id;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let oldAccount;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let newAccount;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let hashDigest;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let hashFunction;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let hashSize;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
// eslint-disable-next-line no-undef
before(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
kernelBase = await getContract('Kernel').new(true); // petrify immediately
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
aclBase = await getContract('ACL').new();
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
daoFactory = await getContract('DAOFactory').new(kernelBase.address, aclBase.address, ZERO_ADDR);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
r = await daoFactory.newDAO(root);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
dao = getContract('Kernel').at(r.logs.filter(l => l.event == 'DeployDAO')[0].args.dao);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
acl = getContract('ACL').at(await dao.acl());
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
//create dao mamnager permission for coin owner
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await acl.createPermission(
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
root,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
dao.address,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await dao.APP_MANAGER_ROLE(),
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
root,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
{ from: root }
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
//get new app instance from DAO
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
const receipt = await dao.newAppInstance(
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
'0x1234',
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
(await Contributor.new()).address,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
0x0,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
false,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
{ from: root }
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
contributor = Contributor.at(
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
receipt.logs.filter(l => l.event == 'NewAppProxy')[0].args.proxy
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
//apps id
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let appsId = [];
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
appsId[0] = namehash("kredits-contribution");
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
appsId[1] = namehash("kredits-contributor");
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
appsId[2] = namehash("kredits-proposal");
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
appsId[3] = namehash("kredits-token");
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
//init contributor (app)
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.initialize(root, appsId);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
//create manage contributors role
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await acl.createPermission(
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
root,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
contributor.address,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.MANAGE_CONTRIBUTORS_ROLE(),
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
root,
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
{ from: root }
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
before(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
id = await contributor.coreContributorsCount();
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
oldAccount = root;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
newAccount = member1;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
hashDigest = '0x1000000000000000000000000000000000000000000000000000000000000000';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
hashFunction = 1;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
hashSize = 1;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
describe("Owner default space permissions", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it('check owner is token issuer', async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let manageContributorPermission = await acl.hasPermission(root, contributor.address, await contributor.MANAGE_CONTRIBUTORS_ROLE());
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
// eslint-disable-next-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
assert.equal(manageContributorPermission, true);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it('update contributor account', async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.updateContributorAccount(id.toNumber(), oldAccount, newAccount);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let contributorId = await contributor.getContributorIdByAddress(oldAccount);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
// eslint-disable-next-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
assert.equal(contributorId.toNumber(), 0);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
describe("Add contributor", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let account = root;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let hashDigest = '0x0';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let hashFunction = 0;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let hashSize = 0;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it("should revert when add contributor from an address that does not have permission", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
return assertRevert(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.addContributor(account, hashDigest, hashFunction, hashSize, { from: member1});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
'sender does not have permission';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it('add contributor', async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let contributorCount = await contributor.coreContributorsCount();
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.addContributor(account, hashDigest, hashFunction, hashSize);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
// eslint-disable-next-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
assert.equal(await contributor.addressExists(account), true);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let contributorCountAfter = await contributor.coreContributorsCount();
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
// eslint-disable-next-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
assert.equal(await contributorCountAfter.toNumber(), parseInt(contributorCount)+1);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it("should revert when add contributor with an address that already exist", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
return assertRevert(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.addContributor(account, hashDigest, hashFunction, hashSize, { from: member1});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
'address already exist';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it("should revert when update contributor account from address that does not have permission", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
return assertRevert(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.updateContributorAccount(id.toNumber(), oldAccount, newAccount, {from: member1});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
'sender does not have permission';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
describe("Update contributor", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let id;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let oldAccount;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let newAccount;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let hashDigest;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let hashFunction;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let hashSize;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
// eslint-disable-next-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
before(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
id = await contributor.coreContributorsCount();
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
oldAccount = root;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
newAccount = member1;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
hashDigest = '0x1000000000000000000000000000000000000000000000000000000000000000';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
hashFunction = 1;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
hashSize = 1;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it('update contributor account', async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.updateContributorAccount(id.toNumber(), oldAccount, newAccount);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let contributorId = await contributor.getContributorIdByAddress(oldAccount);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
// eslint-disable-next-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
assert.equal(contributorId.toNumber(), 0);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it("should revert when update contributor account from address that does not have permission", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
return assertRevert(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.updateContributorAccount(id.toNumber(), oldAccount, newAccount, {from: member1});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
'sender does not have permission';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it("should revert when update contributor account that does not exist", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
return assertRevert(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.updateContributorAccount(id.toNumber(), accounts[3], newAccount);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
'contributor does not exist';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it("should revert when update contributor account with address(0)", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
return assertRevert(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.updateContributorAccount(id.toNumber(), oldAccount, ZERO_ADDR);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
'contributor does not exist';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it('update contributor profile hash', async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.updateContributorProfileHash(id.toNumber(), hashDigest, hashFunction, hashSize);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let contributorProfile = await contributor.contributors(id.toNumber());
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
assert.equal(hashDigest, contributorProfile[1]); // eslint-disable-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
assert.equal(hashFunction, contributorProfile[2].toNumber()); // eslint-disable-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
assert.equal(hashSize, contributorProfile[3].toNumber()); // eslint-disable-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it("should revert when update contributor profile hash from address that does not have permission", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
return assertRevert(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.updateContributorProfileHash(id.toNumber(), hashDigest, hashFunction, hashSize, {from: member1});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
'sender does not have permission';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it("should revert when update contributor account that does not exist", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
return assertRevert(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.updateContributorAccount(id.toNumber(), accounts[3], newAccount);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
'contributor does not exist';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it("should revert when update contributor account with address(0)", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
return assertRevert(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.updateContributorAccount(id.toNumber(), oldAccount, ZERO_ADDR);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
'contributor does not exist';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it('update contributor profile hash', async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.updateContributorProfileHash(id.toNumber(), hashDigest, hashFunction, hashSize);
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
let contributorProfile = await contributor.contributors(id.toNumber());
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
assert.equal(hashDigest, contributorProfile[1]); // eslint-disable-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
assert.equal(hashFunction, contributorProfile[2].toNumber()); // eslint-disable-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
assert.equal(hashSize, contributorProfile[3].toNumber()); // eslint-disable-line no-undef
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
it("should revert when update contributor profile hash from address that does not have permission", async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
return assertRevert(async () => {
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
await contributor.updateContributorProfileHash(id.toNumber(), hashDigest, hashFunction, hashSize, {from: member1});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
'sender does not have permission';
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
});

bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...