kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Contributor app tests #143

Merged
haythem96 merged 26 commits from tests/contracts-contributor into master 2019-07-22 06:55:23 +00:00
Conversation 39 Commits 26 Files Changed 17 +1 -3
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 476609843d - Show all commits

2
apps/contributor/package.json
View File

@ -7,8 +7,6 @@
"@aragon/cli": "^5.9.6" "@aragon/cli": "^5.9.6"
}, },
"devDependencies": { "devDependencies": {
"@aragon/test-helpers": "^1.1.0",
"eth-ens-namehash": "^2.0.8",
"eth-gas-reporter": "^0.2.0", "eth-gas-reporter": "^0.2.0",
"ganache-cli": "^6.4.3", "ganache-cli": "^6.4.3",
"solidity-coverage": "^0.5.11" "solidity-coverage": "^0.5.11"

2
apps/contributor/test/contributor.js
View File

@ -1,4 +1,4 @@
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review
Copy Link

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review
Copy Link

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review
Copy Link

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review
Copy Link

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review
Copy Link

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review
Copy Link

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
const namehash = require('eth-ens-namehash').hash; const namehash = require('ethers').utils.namehash;
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review
Copy Link

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review
Copy Link

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review
Copy Link

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review
Copy Link

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review
Copy Link

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review
Copy Link

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
// eslint-disable-next-line no-undef // eslint-disable-next-line no-undef
const Contributor = artifacts.require("Contributor.sol"); const Contributor = artifacts.require("Contributor.sol");

bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review
Copy Link

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
bumi commented 2019-07-06 15:22:31 +00:00 (Migrated from github.com)
Review
Copy Link

we should be able to use the namehash from ethers:
const namehash = require('ethers').utils.namehash;
as ethers.js is already a dependency we do not need to add another dependency

we should be able to use the namehash from ethers: `const namehash = require('ethers').utils.namehash;` as ethers.js is already a dependency we do not need to add another dependency
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review
Copy Link

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:07:41 +00:00 (Migrated from github.com)
Review
Copy Link

cool will change that

cool will change that
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review
Copy Link

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...
haythem96 commented 2019-07-06 16:10:49 +00:00 (Migrated from github.com)
Review
Copy Link

for the ganache script, it is basically the same aragon one, but I changed

run_tests() {
  echo "Running tests..."
  npx truffle test --network rpc "$@"
}

to

run_tests() {
  echo "Running tests..."
  npx aragon contracts test --network rpc "$@"
}

Because npx truffle test --network rpc "$@" didn't work for me for no reason...

for the ganache script, it is basically the same aragon one, but I changed ``` run_tests() { echo "Running tests..." npx truffle test --network rpc "$@" } ``` to ``` run_tests() { echo "Running tests..." npx aragon contracts test --network rpc "$@" } ``` Because `npx truffle test --network rpc "$@"` didn't work for me for no reason...