WIP: Contribution contracts tests #159

Closed
haythem96 wants to merge 20 commits from tests/contracts-contribution into master
12 changed files with 14583 additions and 2493 deletions

View File

@ -15,19 +15,26 @@ cache:
- apps/token/node_modules
- apps/vault/node_modules
env:
- TASK=lint:wrapper
- TASK=lint:contract-tests
- TASK=test:token
- TASK=test:contributor
- TASK=test:contribution
- TASK=test:proposal
raucao commented 2019-09-21 07:37:44 +00:00 (Migrated from github.com)
Review

This should be the same as the test script itself, because && is supposed to exit with 1, if any of the commands on the way exit with 1.

This should be the same as the test script itself, because `&&` is supposed to exit with 1, if any of the commands on the way exit with 1.
haythem96 commented 2019-09-21 12:35:10 +00:00 (Migrated from github.com)
Review

yeah true, I changed that also to

env:
  - TASK=lint:wrapper
  - TASK=lint:contract-tests
  - TASK=test:token
  - TASK=test:contributor
  - TASK=test:contribution
  - TASK=test:proposal

before_script:
  - npm run devchain > /dev/null &
  - sleep 5

script:
  - travis_wait 60 npm run $TASK

It is the same also, but > /dev/null & to not show the output and using TASK for better visualization I think...
But the thing is there is an error in Contribution tests, but it doesn't exit with 1!

yeah true, I changed that also to ``` env: - TASK=lint:wrapper - TASK=lint:contract-tests - TASK=test:token - TASK=test:contributor - TASK=test:contribution - TASK=test:proposal before_script: - npm run devchain > /dev/null & - sleep 5 script: - travis_wait 60 npm run $TASK ``` It is the same also, but `> /dev/null &` to not show the output and using `TASK` for better visualization I think... But the thing is there is an error in Contribution tests, but it doesn't exit with 1!
raucao commented 2019-09-22 08:46:26 +00:00 (Migrated from github.com)
Review

I don't see how the env vars make it clearer. I think it's actually less understandable that way. In fact, I wouldn't even know off the top of my head what happens when you assign the same env variable twice.

But the thing is there is an error in Contribution tests, but it doesn't exit with 1!

Yes, that's the thing that needs to be fixed I think. Not how the tests are run. The test task should just be npm test and nothing else, in my opinion.

I don't see how the env vars make it clearer. I think it's actually less understandable that way. In fact, I wouldn't even know off the top of my head what happens when you assign the same env variable twice. > But the thing is there is an error in Contribution tests, but it doesn't exit with 1! Yes, that's the thing that needs to be fixed I think. Not how the tests are run. The test task should just be `npm test` and nothing else, in my opinion.
haythem96 commented 2019-09-23 00:24:50 +00:00 (Migrated from github.com)
Review

What I meant by the env vars make it clearer, in Travis u don't need to look at the whole log in case a test fail...
1

What I meant by the env vars make it clearer, in Travis u don't need to look at the whole log in case a test fail... ![1](https://user-images.githubusercontent.com/17862704/65396697-eb146900-dda0-11e9-9186-2184cbf79106.png)
raucao commented 2019-09-23 10:01:00 +00:00 (Migrated from github.com)
Review

Oh, I see. The feature you're looking for is the build matrix:

https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices

Oh, I see. The feature you're looking for is the build matrix: https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices
install:
- npm install -g @aragon/cli
- npm install -g truffle
- npm install
before_script:
- npm run devchain &
- npm run devchain > /dev/null &
- sleep 5
script:
- npm run lint:wrapper
- npm run lint:contract-tests
- npm run test
- travis_wait 60 npm run $TASK
branches:
only:
- master
- master

View File

@ -152,6 +152,8 @@ contract Contribution is AragonApp {
function add(uint32 amount, uint32 contributorId, bytes32 hashDigest, uint8 hashFunction, uint8 hashSize) public isInitialized auth(ADD_CONTRIBUTION_ROLE) {
//require(canPerform(msg.sender, ADD_CONTRIBUTION_ROLE, new uint32[](0)), 'nope');
require(amount > 0, "INVALID_AMOUNT");
uint32 contributionId = contributionsCount + 1;
ContributionData storage c = contributions[contributionId];
c.exists = true;

View File

@ -0,0 +1,18 @@
pragma solidity ^0.4.24;
import "@aragon/os/contracts/acl/ACL.sol";
import "@aragon/os/contracts/kernel/Kernel.sol";
import "@aragon/os/contracts/factory/DAOFactory.sol";
import "../../../contributor/contracts/Contributor.sol";
import "../../../token/contracts/Token.sol";
// You might think this file is a bit odd, but let me explain.
// We only use for now those imported contracts in our tests, which
// means Truffle will not compile them for us, because they are from
// an external dependency.
// solium-disable-next-line no-empty-blocks
contract Spoof {
// ...
}

File diff suppressed because it is too large Load Diff

View File

@ -1,5 +0,0 @@
// const Contribution = artifacts.require('Contribution.sol');
contract('Contribution', (_accounts) => {
it('should be tested');
});

View File

@ -0,0 +1,332 @@
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const namehash = require('ethers').utils.namehash;
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const Contribution = artifacts.require("Contribution.sol");
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const Contributor = artifacts.require("Contributor.sol");
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const Token = artifacts.require("Token.sol");
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const getContract = name => artifacts.require(name);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const { assertRevert } = require('@aragon/test-helpers/assertThrow');
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const ZERO_ADDR = '0x0000000000000000000000000000000000000000';
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const timeTravel = function(time){
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
return new Promise((resolve, reject) => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
web3.currentProvider.sendAsync({
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
jsonrpc: "2.0",
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
method: "evm_increaseTime",
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
params: [time], //86400 is num seconds in day
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
id: new Date().getSeconds(),
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
}, (err, result) => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
if(err) {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
return reject(err);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
}
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
return resolve(result);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
};
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const mineBlock = function() {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
return new Promise((resolve, reject) => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
web3.currentProvider.sendAsync({
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
jsonrpc: "2.0",
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
method: "evm_mine",
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
params: [],
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
id: new Date().getSeconds(),
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
}, (err, result) => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
if(err){ return reject(err); }
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
return resolve(result);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
};
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const getBlockNumber = function() {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
return new Promise((resolve, reject) => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
web3.eth.getBlockNumber(async (err, res) => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
if (err || !res) return reject(err);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
resolve(res);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
};
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
contract('Contribution app', (accounts) => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let kernelBase, aclBase, daoFactory, r, dao, acl, contribution, token, contributor;
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const root = accounts[0];
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const member1 = accounts[1];
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const blocksToWait = 40320;
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
before(async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
kernelBase = await getContract('Kernel').new(true); // petrify immediately
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
aclBase = await getContract('ACL').new();
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
daoFactory = await getContract('DAOFactory').new(kernelBase.address, aclBase.address, ZERO_ADDR);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
r = await daoFactory.newDAO(root);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
dao = getContract('Kernel').at(r.logs.filter(l => l.event == 'DeployDAO')[0].args.dao);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
acl = getContract('ACL').at(await dao.acl());
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
//create dao mamnager permission for coin owner
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await acl.createPermission(
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
root,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
dao.address,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await dao.APP_MANAGER_ROLE(),
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
root,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
{ from: root }
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
//apps id
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let appsId = [];
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
appsId[0] = namehash("kredits-contribution");
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
appsId[1] = namehash("kredits-contributor");
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
appsId[2] = namehash("kredits-proposal");
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
appsId[3] = namehash("kredits-token");
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
//get new app instance from DAO
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let receipt = await dao.newAppInstance(
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-08-10 10:51:38 +00:00 (Migrated from github.com)
Review

getBlockNumber should actually return a promise as well, so this entire function is superfluous. We're using it with a promise e.g. here: https://github.com/67P/kredits-web/blob/master/app/services/kredits.js#L150

`getBlockNumber` should actually return a promise as well, so this entire function is superfluous. We're using it with a promise e.g. here: https://github.com/67P/kredits-web/blob/master/app/services/kredits.js#L150
haythem96 commented 2019-08-10 13:40:39 +00:00 (Migrated from github.com)
Review

it return also there a promise, no ?

it return also there a promise, no ?
raucao commented 2019-08-10 13:50:41 +00:00 (Migrated from github.com)
Review

The function you added is just wrapping the normal callback in a promise. Wherever it's called you can just use the original function with a promise.

The function you added is just wrapping the normal callback in a promise. Wherever it's called you can just use the original function with a promise.
haythem96 commented 2019-08-10 14:36:36 +00:00 (Migrated from github.com)
Review

I updated it, the thing is blocks get mined instantly so veto period end...

I updated it, the thing is blocks get mined instantly so veto period end...
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
appsId[0],
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
(await Contribution.new()).address,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
0x0,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
false,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
{ from: root }
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
contribution = Contribution.at(
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
receipt.logs.filter(l => l.event == 'NewAppProxy')[0].args.proxy
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
receipt = await dao.newAppInstance(
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
appsId[3],
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
(await Token.new()).address,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
0x0,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
false,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
{ from: root }
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
token = Token.at(
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
receipt.logs.filter(l => l.event == 'NewAppProxy')[0].args.proxy
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
receipt = await dao.newAppInstance(
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
appsId[1],
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
(await Contributor.new()).address,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
0x0,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
false,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
{ from: root }
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
contributor = Contributor.at(
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
receipt.logs.filter(l => l.event == 'NewAppProxy')[0].args.proxy
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
//init app
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contribution.initialize(appsId);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await acl.createPermission(
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
root,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
contribution.address,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contribution.ADD_CONTRIBUTION_ROLE(),
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
root,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
{ from: root }
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await acl.createPermission(
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
root,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
contribution.address,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contribution.VETO_CONTRIBUTION_ROLE(),
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
root,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
{ from: root }
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
//init token (app)
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await token.initialize(appsId);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
//create token mint permission for coin owner
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await acl.createPermission(
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
contribution.address,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
token.address,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await token.MINT_TOKEN_ROLE(),
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
root,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
{ from: root }
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
//init contributor app
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contributor.initialize(root, appsId);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await acl.createPermission(
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
root,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
contributor.address,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contributor.MANAGE_CONTRIBUTORS_ROLE(),
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
root,
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
{ from: root }
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
describe("Owner default space permissions", async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
it('check owner can add contribution', async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let addContributionPermission = await acl.hasPermission(root, contribution.address, await contribution.ADD_CONTRIBUTION_ROLE());
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
assert.equal(addContributionPermission, true);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
it('check owner can veto contribution', async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let vetoContributionPermission = await acl.hasPermission(root, contribution.address, await contribution.VETO_CONTRIBUTION_ROLE());
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
assert.equal(vetoContributionPermission, true);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
it('check contribution app can mint token', async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let mintTokenPermission = await acl.hasPermission(contribution.address, token.address, await token.MINT_TOKEN_ROLE());
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
assert.equal(mintTokenPermission, true);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
describe("Add contribution", async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// contributor detials
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let account, contributorHashDigest, contributorHashFunction, contributorHashSize;
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// contribution details
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let amount, contributorId, hashDigest, hashFunction, hashSize;
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
before(async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// Add contributor from Contributor app
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
account = root;
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
contributorHashDigest = '0x0000000000000000000000000000000000000000000000000000000000000000';
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
contributorHashFunction = 0;
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
contributorHashSize = 0;
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contributor.addContributor(account, contributorHashDigest, contributorHashFunction, contributorHashSize);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
assert.equal(await contributor.addressExists(account), true);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
amount = 100;
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
contributorId = await contributor.getContributorIdByAddress(root);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
hashDigest = '0x0000000000000000000000000000000000000000000000000000000000000000';
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
hashFunction = 1;
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
hashSize = 1;
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
it("should revert when add contribution from address that does not have permission", async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
return assertRevert(async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contribution.add(amount, contributorId, hashDigest, hashFunction, hashSize, {from: member1});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
'sender does not have permission';
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
it("should revert when add contribution with amount equal to zero", async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
return assertRevert(async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contribution.add(0, contributorId, hashDigest, hashFunction, hashSize, {from: root});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
'amount equal to zero';
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
it("should add contribution", async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let contributionCountBefore = await contribution.contributionsCount();
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contribution.add(amount, contributorId, hashDigest, hashFunction, hashSize, {from: root});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let contributionCountAfter = await contribution.contributionsCount();
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
assert.equal(contributionCountAfter.toNumber()-contributionCountBefore.toNumber(), 1, "contributions counter incremented");
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let contributionObject = await contribution.getContribution(contributionCountAfter.toNumber());
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
assert.equal(contributionObject[1].toNumber(), contributorId.toNumber(), "contribution added belong to contributor id");
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let isExist = await contribution.exists(contributionCountAfter.toNumber());
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
assert.equal(isExist, true, "contribution exist");
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
describe("Veto contribution", async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
it("should revert when veto from address that does not have permission", async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const contributionId = await contribution.contributionsCount();
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
return assertRevert(async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contribution.veto(contributionId.toNumber(), {from: member1});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
'sender does not have permission to veto';
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
it("should revert when veto contribution that does not exist", async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const contributionId = await contribution.contributionsCount();
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
return assertRevert(async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contribution.veto(contributionId.toNumber()+1, {from: root});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
'contribution not found';
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
it("veto contribution", async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
const contributionId = await contribution.contributionsCount();
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
if(contributionId < 10) {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
return assertRevert(async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contribution.veto(contributionId.toNumber(), {from: root});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
'can not veto first 10 contribution';
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
}
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
else {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contribution.veto(contributionId.toNumber(), {from: root});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let contributionObject = await contribution.getContribution(contributionId.toNumber());
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
assert(contributionObject[9], true);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
}
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
describe("Claim contribution", async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let contributionId;
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
before(async () =>{
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
//add contribution
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let amount = 200;
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let contributorId = await contributor.getContributorIdByAddress(root);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let contributionHashDigest = '0x0000000000000000000000000000000000000000000000000000000000000000';
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let contributionHashFunction = 1;
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let contributionHashSize = 1;
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contribution.add(amount, contributorId.toNumber(), contributionHashDigest, contributionHashFunction, contributionHashSize, {from: root});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
contributionId = await contribution.contributionsCount();
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
it("should revert when claim contribution that does not exist", async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
return assertRevert(async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contribution.claim(contributionId.toNumber()+1, {from: root});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
'contribution not found';
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
it("should revert when claim contribution before confirmation block", async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
if(contributionId > 10) {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
return assertRevert(async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contribution.claim(contributionId.toNumber(), {from: root});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
'contribution not confirmed yet';
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
}
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
it("claim contribution", async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let contributionObject = await contribution.getContribution(contributionId.toNumber());
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let confirmationBlock = contributionObject[7];
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let chainBlockNumberBefore = await getBlockNumber();
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
if(contributionId > 10) {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await timeTravel(blocksToWait);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await mineBlock();
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
let chainBlockNumberAfter = await getBlockNumber();
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
assert.equal(chainBlockNumberAfter.toNumber()-chainBlockNumberBefore.toNumber(), confirmationBlock.toNumber());
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
}
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
//Claim contribution
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contribution.claim(contributionId, {from: root});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
contributionObject = await contribution.getContribution(contributionId.toNumber());
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
// eslint-disable-next-line no-undef
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
assert(contributionObject[3], true);
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
it("should revert when claim already claimed contribution", async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
return assertRevert(async () => {
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
await contribution.claim(contributionId.toNumber(), {from: root});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
'contribution already claimed';
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.
});
haythem96 commented 2019-08-02 16:29:19 +00:00 (Migrated from github.com)
Review

this one revert for some reasons

this one revert for some reasons
raucao commented 2019-08-02 16:39:17 +00:00 (Migrated from github.com)
Review

Looks like the expectation wasn't described here (it("does x")). It also looks like there are 3 different expectations in one block here.

Looks like the expectation wasn't described here (`it("does x")`). It also looks like there are 3 different expectations in one block here.
raucao commented 2019-08-02 16:40:09 +00:00 (Migrated from github.com)
Review

I think you can also add expectation descriptions as the last argument to assert(), in case you really want to assert multiple things in one it block.

I think you can also add expectation descriptions as the last argument to `assert()`, in case you really want to assert multiple things in one `it` block.
raucao commented 2019-08-02 16:40:45 +00:00 (Migrated from github.com)
Review

Reverts unexpectedly? And in which context/scenario?

Reverts unexpectedly? And in which context/scenario?
haythem96 commented 2019-08-03 11:24:35 +00:00 (Migrated from github.com)
Review

in the scenario of claiming an added contribution

in the scenario of claiming an added contribution
haythem96 commented 2019-08-03 11:37:47 +00:00 (Migrated from github.com)
Review

most of those multiple assert check for the same thing, that the contribution is added.. XD

most of those multiple assert check for the same thing, that the contribution is added.. XD
raucao commented 2019-08-03 11:58:16 +00:00 (Migrated from github.com)
Review

How would that work? You can only claim confirmed contributions.

How would that work? You can only claim confirmed contributions.
raucao commented 2019-08-03 11:59:37 +00:00 (Migrated from github.com)
Review

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.

They very line I commented on asserts that the contributorId is correct, not that the contribution itself was added.
haythem96 commented 2019-08-03 14:40:57 +00:00 (Migrated from github.com)
Review

ahhhh yup okay, missed this require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); thanks!

ahhhh yup okay, missed this ` require(block.number >= c.confirmedAtBlock, 'NOT_CLAIMABLE'); ` thanks!
haythem96 commented 2019-08-03 14:42:56 +00:00 (Migrated from github.com)
Review

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage

yeah true, honestly don't know if that all those asserts are necessary... maybe just for more code coverage
raucao commented 2019-08-03 14:46:37 +00:00 (Migrated from github.com)
Review

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.

In this case it's only important that you describe what you mean to test exactly. Currently, there's no description of what is being tested in this block.
haythem96 commented 2019-08-06 10:37:30 +00:00 (Migrated from github.com)
Review

this should fix the claim tests, no @skddc @bumi ?

this should fix the claim tests, no @skddc @bumi ?
haythem96 commented 2019-08-09 22:54:48 +00:00 (Migrated from github.com)
Review

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi

idk if this test is really necessary as if a contribution is claimed, so theoretically it is impossible to veto because of block number @bumi
haythem96 commented 2019-08-09 22:55:23 +00:00 (Migrated from github.com)
Review

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc

can't figure out why this one is not working, idk what I'm missing there! @bumi @skddc
haythem96 commented 2019-08-09 22:56:07 +00:00 (Migrated from github.com)
Review

blocks get minted and the veto period end right away... @bumi @skddc

blocks get minted and the veto period end right away... @bumi @skddc
raucao commented 2019-09-19 09:19:32 +00:00 (Migrated from github.com)
Review

Yes, the first 10 are confirmed immediately iirc.

Yes, the first 10 are confirmed immediately iirc.

File diff suppressed because it is too large Load Diff

File diff suppressed because it is too large Load Diff

File diff suppressed because it is too large Load Diff

View File

@ -34,7 +34,9 @@
"environments": {
"development": {
"network": "development",
"apm": "open.aragonpm.eth",
"apm": {
"open.aragonpm.eth"
},
"registry": "0x5f6f7e8cc7346a11ca2def8f827b7a0b612c56a1",
"appName": "dummy.open.aragonpm.eth"
},
@ -44,7 +46,9 @@
"wsRPC": "wss://rinkeby.eth.aragon.network/ws",
"daoFactory": "0x2298d27a9b847c681d2b2c2828ab9d79013f5f1d",
"appName": "dummy.open.aragonpm.eth",
"apm": "open.aragonpm.eth"
"apm": {
"open.aragonpm.eth"
}
},
"kovan": {
"network": "kovan",
@ -53,7 +57,9 @@
"default": {
"network": "development",
"appName": "dummy.aragonpm.eth",
"apm": "open.aragonpm.eth"
"apm": {
"open.aragonpm.eth"
}
}
},
"path": "contracts/misc/DummyApp.sol"

893
package-lock.json generated

File diff suppressed because it is too large Load Diff

View File

@ -44,6 +44,7 @@
"devDependencies": {
"@aragon/kits-base": "^1.0.0",
"@aragon/os": "^4.2.0",
"@aragon/test-helpers": "^2.0.0",
"async-each-series": "^1.1.0",
haythem96 commented 2019-09-23 00:29:17 +00:00 (Migrated from github.com)
Review

Adding the test-helpers package fixed #163

Adding the test-helpers package fixed #163
"cli-table": "^0.3.1",
"eslint": "^5.16.0",