kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Refactor kredits address initialization #35

Merged
bumi merged 2 commits from refactor/kredits-init into master 2018-04-21 08:32:58 +00:00
Conversation 2 Commits 2 Files Changed 3 +1 -4
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 92f3963c5a - Show all commits

5
lib/kredits.js
View File

@ -19,9 +19,6 @@ function capitalize(word) {
} }
fsmanuel commented 2018-04-20 10:22:06 +00:00 (Migrated from github.com)
Review
Copy Link

We can use Object.keys(ABIS) and remove static get contractNames().

We can use `Object.keys(ABIS)` and remove `static get contractNames()`.
class Kredits { class Kredits {
static get contractNames() {
return Object.keys(ABIS);
}
constructor(provider, signer, addresses) { constructor(provider, signer, addresses) {
this.provider = provider; this.provider = provider;
@ -36,7 +33,7 @@ class Kredits {
} }
init(names) { init(names) {
let contractsToLoad = names || Kredits.contractNames; let contractsToLoad = names || Object.keys(ABIS);
let addressPromises = contractsToLoad.map((contractName) => { let addressPromises = contractsToLoad.map((contractName) => {
return this.Registry.functions.getProxyFor(contractName).then((address) => { return this.Registry.functions.getProxyFor(contractName).then((address) => {
this.addresses[contractName] = address; this.addresses[contractName] = address;