kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Build on aragonOS #62

Merged
bumi merged 51 commits from aragonos into master 2019-04-02 19:36:36 +00:00
Conversation 39 Commits 51 Files Changed 121 -1
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 91135dbc82 - Show all commits

1
scripts/deploy-kit.js
View File

@@ -48,7 +48,6 @@ module.exports = async function(callback) {
fsmanuel commented 2019-03-24 22:23:01 +00:00 (Migrated from github.com)
Review
Copy Link

What about:

const KreditsKit = artifacts.require('KreditsKit')
const kreditsKitFile = 'KreditsKit.json'
// ...
let addresseFile = path.join(addressesPath, kreditsKitFile);
What about: ```js const KreditsKit = artifacts.require('KreditsKit') const kreditsKitFile = 'KreditsKit.json' // ... let addresseFile = path.join(addressesPath, kreditsKitFile); ```
fsmanuel commented 2019-03-24 22:23:01 +00:00 (Migrated from github.com)
Review
Copy Link

What about:

const KreditsKit = artifacts.require('KreditsKit')
const kreditsKitFile = 'KreditsKit.json'
// ...
let addresseFile = path.join(addressesPath, kreditsKitFile);
What about: ```js const KreditsKit = artifacts.require('KreditsKit') const kreditsKitFile = 'KreditsKit.json' // ... let addresseFile = path.join(addressesPath, kreditsKitFile); ```
fsmanuel commented 2019-03-27 11:38:31 +00:00 (Migrated from github.com)
Review
Copy Link

const networkId = await getNetworkId(web3);

`const networkId = await getNetworkId(web3);`
fsmanuel commented 2019-03-27 11:38:31 +00:00 (Migrated from github.com)
Review
Copy Link

const networkId = await getNetworkId(web3);

`const networkId = await getNetworkId(web3);`
raucao commented 2019-03-27 11:39:55 +00:00 (Migrated from github.com)
Review
Copy Link

Have you tried the new suggestion feature in these comments? It's pretty useful! (And you'll be credited in the commit.)

Have you tried the new suggestion feature in these comments? It's pretty useful! (And you'll be credited in the commit.)
raucao commented 2019-03-27 11:39:55 +00:00 (Migrated from github.com)
Review
Copy Link

Have you tried the new suggestion feature in these comments? It's pretty useful! (And you'll be credited in the commit.)

Have you tried the new suggestion feature in these comments? It's pretty useful! (And you'll be credited in the commit.)
console.log(`Deployed KreditsKit at: ${kreditsKit.address}`);
fileInject(path.join(__dirname, '..', 'lib/addresses/KreditsKit.json'), networkId, kreditsKit.address);
fileInject(path.join(__dirname, '..', 'lib/app_ids.json'), networkId, appIds);
fsmanuel commented 2019-03-24 22:23:01 +00:00 (Migrated from github.com)
Review
Copy Link

What about:

const KreditsKit = artifacts.require('KreditsKit')
const kreditsKitFile = 'KreditsKit.json'
// ...
let addresseFile = path.join(addressesPath, kreditsKitFile);
What about: ```js const KreditsKit = artifacts.require('KreditsKit') const kreditsKitFile = 'KreditsKit.json' // ... let addresseFile = path.join(addressesPath, kreditsKitFile); ```
fsmanuel commented 2019-03-27 11:38:31 +00:00 (Migrated from github.com)
Review
Copy Link

const networkId = await getNetworkId(web3);

`const networkId = await getNetworkId(web3);`
raucao commented 2019-03-27 11:39:55 +00:00 (Migrated from github.com)
Review
Copy Link

Have you tried the new suggestion feature in these comments? It's pretty useful! (And you'll be credited in the commit.)

Have you tried the new suggestion feature in these comments? It's pretty useful! (And you'll be credited in the commit.)
callback();
}).catch((e) => {
fsmanuel commented 2019-03-24 22:23:01 +00:00 (Migrated from github.com)
Review
Copy Link

What about:

const KreditsKit = artifacts.require('KreditsKit')
const kreditsKitFile = 'KreditsKit.json'
// ...
let addresseFile = path.join(addressesPath, kreditsKitFile);
What about: ```js const KreditsKit = artifacts.require('KreditsKit') const kreditsKitFile = 'KreditsKit.json' // ... let addresseFile = path.join(addressesPath, kreditsKitFile); ```
fsmanuel commented 2019-03-24 22:23:01 +00:00 (Migrated from github.com)
Review
Copy Link

What about:

const KreditsKit = artifacts.require('KreditsKit')
const kreditsKitFile = 'KreditsKit.json'
// ...
let addresseFile = path.join(addressesPath, kreditsKitFile);
What about: ```js const KreditsKit = artifacts.require('KreditsKit') const kreditsKitFile = 'KreditsKit.json' // ... let addresseFile = path.join(addressesPath, kreditsKitFile); ```
fsmanuel commented 2019-03-27 11:38:31 +00:00 (Migrated from github.com)
Review
Copy Link

const networkId = await getNetworkId(web3);

`const networkId = await getNetworkId(web3);`
fsmanuel commented 2019-03-27 11:38:31 +00:00 (Migrated from github.com)
Review
Copy Link

const networkId = await getNetworkId(web3);

`const networkId = await getNetworkId(web3);`
raucao commented 2019-03-27 11:39:55 +00:00 (Migrated from github.com)
Review
Copy Link

Have you tried the new suggestion feature in these comments? It's pretty useful! (And you'll be credited in the commit.)

Have you tried the new suggestion feature in these comments? It's pretty useful! (And you'll be credited in the commit.)
raucao commented 2019-03-27 11:39:55 +00:00 (Migrated from github.com)
Review
Copy Link

Have you tried the new suggestion feature in these comments? It's pretty useful! (And you'll be credited in the commit.)

Have you tried the new suggestion feature in these comments? It's pretty useful! (And you'll be credited in the commit.)