kredits/hubot-kredits
9
0
Fork 0
Code Issues 8 Pull Requests Releases 9 Activity

Ignore meetings that have less than 3 unique participants

Browse Source 
zoom's participants_count is not unique and the same person can be counted
multiple times.
We need to check for unique names.
This commit is contained in:
bumi 2020-04-16 18:07:17 +02:00
parent e823797ee2
commit e10dd4abc3
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
integrations/zoom.js
View File

@ -69,14 +69,13 @@ module.exports = async function(robot, kredits) {
async function handleZoomMeetingEnded(data) { async function handleZoomMeetingEnded(data) {
const meetingDetails = await getMeetingDetails(data.uuid); const meetingDetails = await getMeetingDetails(data.uuid);
const participants = await getMeetingParticipants(data.uuid); const participants = await getMeetingParticipants(data.uuid);
const names = Array.from(new Set(participants.map(p => p.name)));
if (meetingDetails.duration < 15 || meetingDetails.participants_count < 3) { if (meetingDetails.duration < 15 || names.length < 3) {
robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
return; return;
} }
const names = Array.from(new Set(participants.map(p => p.name)));
for (const displayName of names) { for (const displayName of names) {
await createContributionFor(displayName, meetingDetails); await createContributionFor(displayName, meetingDetails);
}; };