kredits/hubot-kredits
9
0
Fork 0
Code Issues 8 Pull Requests Releases 9 Activity

Propose Kredits for code reviews #49

New Issue
Closed
opened 2019-11-22 16:44:41 +00:00 by raucao · 6 comments
raucao commented 2019-11-22 16:44:41 +00:00 (Migrated from github.com)
Copy Link
Copy Source

On GitHub and Gitea, the reviewers should also get kredits (at least for medium/large contributions).

On GitHub and Gitea, the reviewers should also get kredits (at least for medium/large contributions).
raucao commented 2020-01-22 16:09:25 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Documenting ideas we discussed so far:

  • Collect reviews over a period of time, e.g. one week, then create a single contribution for all reviews on merged PRs from that period
  • When one of the reviewers is also assigned to the PR, it means they have done more work on it over time, so they should earn either the full amount, or something between full and review amount.
Documenting ideas we discussed so far: * Collect reviews over a period of time, e.g. one week, then create a single contribution for all reviews on merged PRs from that period * When one of the reviewers is also assigned to the PR, it means they have done more work on it over time, so they should earn either the full amount, or something between full and review amount.
raucao commented 2020-01-22 16:10:31 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@67P/core @67P/collaborators What do you think would be a good default kredits amount as percentage of the overall amount? (Keep in mind that one should be able to switch from giving review kredits to assigning a co-author.)

@67P/core @67P/collaborators What do you think would be a good default kredits amount as percentage of the overall amount? (Keep in mind that one should be able to switch from giving review kredits to assigning a co-author.)
galfert commented 2020-01-23 12:51:54 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I think something like 20% might be a good number to start with.

I think something like 20% might be a good number to start with.
👍 1
raucao commented 2020-01-23 15:58:29 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Note from weekly call: @bumi, @gregkare, @skddc agree that it's a good number to start with.

Note from weekly call: @bumi, @gregkare, @skddc agree that it's a good number to start with.
👍 1
galfert commented 2020-12-31 10:10:35 +00:00 (Migrated from github.com)
Copy Link
Copy Source

So far I'm able to accumulate all reviews and the corresponding kredits for a given timeframe.

What should we put in the details of the contribution entry? Just the list of the pull request URLs or all of the payload data for every review?

So far I'm able to accumulate all reviews and the corresponding kredits for a given timeframe. What should we put in the details of the contribution entry? Just the list of the pull request URLs or all of the payload data for every review?
raucao commented 2020-12-31 15:04:22 +00:00 (Migrated from github.com)
Copy Link
Copy Source

List of URLs seems enough to me. Ideally we can turn it into separate contribution objects in IPFS later, once the kredits API wrapper supports that.

List of URLs seems enough to me. Ideally we can turn it into separate contribution objects in IPFS later, once the kredits API wrapper supports that.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/hubot-kredits#49