Use/store IPFS metadata for people and proposals #5

2017-06-08T19:12:54Z

raucao commented

2017-06-08 19:12:54 +00:00

(Migrated from github.com)

closes #3
closes #4
connected to #3
connected to #4

closes #3 closes #4 connected to #3 connected to #4

bumi (Migrated from github.com) reviewed 2017-06-08 21:24:39 +00:00

index.js

						
				@@ -78,0 +114,4 @@

				          let accounts = profile.accounts;

				          let github   = accounts.find(a => a.site === 'github.com');

				          let wiki     = accounts.find(a => a.site === 'wiki.kosmos.org');

bumi (Migrated from github.com) commented

2017-06-08 21:24:39 +00:00

maybe it would be nice to have defaults here? for example for the protocol to be https if not explicitly specified

bumi (Migrated from github.com) reviewed 2017-06-08 21:32:24 +00:00

index.js

bumi (Migrated from github.com) commented

2017-06-08 21:32:24 +00:00

maybe we could move the messageRoom call outside of the createProposal call. Thus createProposal only does create the IPFS document and the proposal and resolve or reject and could be used somewhere else.

bumi commented

2017-06-08 21:36:28 +00:00

(Migrated from github.com)

whoot, whooot! awesome. looks good to me, I did not test it here but 👍 for merging!

whoot, whooot! awesome. looks good to me, I did not test it here but :+1: for merging!

❤️ 1

raucao added the kredits-2 label 2025-01-23 21:25:58 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/hubot-kredits#5