MediaWiki integration & integration architecture improvements . #16

Merged
raucao merged 19 commits from feature/6-mediawiki_integration into master 2018-04-21 09:31:30 +00:00
Showing only changes of commit 22b480ae92 - Show all commits

View File

@ -87,15 +87,15 @@ module.exports = async function(robot, kredits) {
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
let repoName = issue.repository_url.match(/.*\/(.+\/.+)$/)[1];
let description = `${repoName}: ${issue.title}`;
let proposalPromisses = [];
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
let proposalPromises = [];
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
recipients.forEach(recipient => {
proposalPromisses.push(
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
proposalPromises.push(
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
createProposal(recipient, amount, description, web_url, issue)
.catch(err => robot.logger.error(err))
);
});
return Promise.all(proposalPromisses);
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
return Promise.all(proposalPromises);
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
}
function handleGitHubPullRequestClosed(data) {
@ -127,16 +127,16 @@ module.exports = async function(robot, kredits) {
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
let repoName = pull_request.base.repo.full_name;
let description = `${repoName}: ${pull_request.title}`;
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
let proposalPromisses = [];
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
let proposalPromises = [];
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
recipients.forEach(recipient => {
console.debug(`[hubot-kredits] Creating proposal for ${recipient}...`);
proposalPromisses.push(
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
proposalPromises.push(
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
createProposal(recipient, amount, description, web_url, pull_request)
.catch(err => robot.logger.error(err))
);
});
return Promise.all(proposalPromisses);
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
return Promise.all(proposalPromises);
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
});
}

bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
bumi commented 2018-04-19 11:38:20 +00:00 (Migrated from github.com)
Review

do we need a const util = require('util'); in this file?

do we need a `const util = require('util');` in this file?
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.
raucao commented 2018-04-19 11:40:25 +00:00 (Migrated from github.com)
Review

Please ignore the code until I have pushed all of my changes. Thanks.

Please ignore the code until I have pushed all of my changes. Thanks.