kredits/hubot-kredits
9
0
Fork 0
Code Issues 8 Pull Requests Releases 9 Activity

Zoom integration #53

Merged
bumi merged 11 commits from feature/zoom into master 2020-04-16 15:34:39 +00:00
Conversation 11 Commits 11 Files Changed 2 +3 -1
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 110c4384e0 - Show all commits

2
index.js
View File

@@ -152,6 +152,8 @@ module.exports = async function(robot) {
require('./integrations/github')(robot, kredits);
require('./integrations/gitea')(robot, kredits);
require('./integrations/zoom')(robot, kredits);
if (typeof process.env.KREDITS_MEDIAWIKI_URL !== 'undefined') {
require('./integrations/mediawiki')(robot, kredits);
}

2
integrations/zoom.js
View File

@@ -72,7 +72,7 @@ module.exports = async function(robot, kredits) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
});
}
robot.router.post('/incoming/kredits/zoom'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 15:13:31 +00:00 (Migrated from github.com)
Review
Copy Link

What's the case of tx being falsey (maybe makes sense to explain that in a comment)? Btw, I think we can replace the then with saving the result in a variable from the await, like so:

const tx = await createContributionFor(displayName, meetingDetails);
if (tx) log(foo);
What's the case of tx being falsey (maybe makes sense to explain that in a comment)? Btw, I think we can replace the `then` with saving the result in a variable from the `await`, like so: ```js const tx = await createContributionFor(displayName, meetingDetails); if (tx) log(foo); ```
bumi commented 2020-04-16 15:15:30 +00:00 (Migrated from github.com)
Review
Copy Link

not sure how to best handle this one: https://github.com/67P/hubot-kredits/pull/53/files#diff-74e18db4da1da4461c9ccb134c582a3eR26

if the contributor is not found then there is no tx.

not sure how to best handle this one: https://github.com/67P/hubot-kredits/pull/53/files#diff-74e18db4da1da4461c9ccb134c582a3eR26 if the contributor is not found then there is no tx.
raucao commented 2020-04-16 15:17:05 +00:00 (Migrated from github.com)
Review
Copy Link

Wait, if the contributor is not found, then the promise wouldn't resolve, would it? In that case it should reject.

Wait, if the contributor is not found, then the promise wouldn't resolve, would it? In that case it should reject.
let data = req.body;
const eventName = data.event;
const payload = data.payload;
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```