Zoom integration #53

Merged
bumi merged 11 commits from feature/zoom into master 2020-04-16 15:34:39 +00:00
Showing only changes of commit 5cc0116163 - Show all commits

49
integrations/zoom.js Normal file
View File

@ -0,0 +1,49 @@
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const fetch = require('node-fetch');
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
module.exports = async function(robot, kredits) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
function createContributionFor (participant, meeting) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
// TODO
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
}
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
function getContributorByZoomUserId(userId) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
return Contributor.findByAccount({ zoomId: userId });
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
}
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
function getMeetingParticipants(meetingUUID) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
fetch(`https://api.zoom.us/v2/past_meetings/${meetingUUID}/participants`)
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
.then(response => response.json())
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
.then(json => json.participants)
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
}
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
function handleZoomMeetingEnded(data) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 15:11:07 +00:00 (Migrated from github.com)
Review

I think we should not do this. It will be a normal thing in a public call that not everyone is a contributor with a profile.

I think we should not do this. It will be a normal thing in a public call that not everyone is a contributor with a profile.
const meetingUUID = data.uuid;
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const topic = data.topic;
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const duration = data.duration;
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const meeting = {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
// TODO
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
}
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
if (duration < 15) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
robot.logger.info('[hubot-kredits] ignoring short calls');
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
return;
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
}
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const participants = await getMeetingParticipants(meetingUUID);
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
participants.forEach(p => {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
createContributionFor(p, meeting);
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
});
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
}
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
robot.router.post('/incoming/kredits/zoom'+process.env.KREDITS_WEBHOOK_TOKEN), (req, res) => {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
let data = req.body;
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const eventName = data.event;
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const payload = data.payload;
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
if (eventName === 'meeting.ended') {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
handleZoomMeetingEnded(payload);
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
}
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
res.sendStatus(200);
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
})
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
}
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```