Zoom integration #53
@@ -74,12 +74,11 @@ module.exports = async function(robot, kredits) {
|
||||
|
|
||||
}
|
||||
const names = Array.from(new Set(participants.map(p => p.name)));
|
||||
What's the case of tx being falsey (maybe makes sense to explain that in a comment)? Btw, I think we can replace the What's the case of tx being falsey (maybe makes sense to explain that in a comment)? Btw, I think we can replace the `then` with saving the result in a variable from the `await`, like so:
```js
const tx = await createContributionFor(displayName, meetingDetails);
if (tx) log(foo);
```
not sure how to best handle this one: https://github.com/67P/hubot-kredits/pull/53/files#diff-74e18db4da1da4461c9ccb134c582a3eR26 if the contributor is not found then there is no tx. not sure how to best handle this one: https://github.com/67P/hubot-kredits/pull/53/files#diff-74e18db4da1da4461c9ccb134c582a3eR26
if the contributor is not found then there is no tx.
Wait, if the contributor is not found, then the promise wouldn't resolve, would it? In that case it should reject. Wait, if the contributor is not found, then the promise wouldn't resolve, would it? In that case it should reject.
|
||||
for(const displayName of names) {
|
||||
await createContributionFor(displayName, meetingDetails)
|
||||
```suggestion
const { Contributor, Contribution } = kredits;
```
```suggestion
const contribution = {
```
This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call". This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
```suggestion
robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```
```suggestion
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```
```suggestion
robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```
|
||||
.then(tx => {
|
||||
```suggestion
const { Contributor, Contribution } = kredits;
```
```suggestion
const contribution = {
```
This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call". This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
```suggestion
robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```
```suggestion
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```
```suggestion
robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```
|
||||
if (tx) {
|
||||
```suggestion
const { Contributor, Contribution } = kredits;
```
```suggestion
const contribution = {
```
This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call". This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
```suggestion
robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```
```suggestion
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```
```suggestion
robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```
|
||||
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
|
||||
```suggestion
const { Contributor, Contribution } = kredits;
```
```suggestion
const contribution = {
```
This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call". This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
```suggestion
robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```
```suggestion
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```
```suggestion
robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```
|
||||
}
|
||||
```suggestion
const { Contributor, Contribution } = kredits;
```
```suggestion
const contribution = {
```
This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call". This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
```suggestion
robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```
```suggestion
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```
```suggestion
robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```
|
||||
});
|
||||
```suggestion
const { Contributor, Contribution } = kredits;
```
```suggestion
const contribution = {
```
This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call". This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
```suggestion
robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```
```suggestion
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```
```suggestion
robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```
|
||||
const tx = createContributionFor(displayName, meetingDetails)
|
||||
```suggestion
const { Contributor, Contribution } = kredits;
```
```suggestion
const contribution = {
```
This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call". This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
```suggestion
robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```
```suggestion
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```
```suggestion
robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```
|
||||
// if the contributor is not found we do not get a transaction object here
|
||||
```suggestion
const { Contributor, Contribution } = kredits;
```
```suggestion
const contribution = {
```
This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call". This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
```suggestion
robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```
```suggestion
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```
```suggestion
robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```
|
||||
if (tx) {
|
||||
```suggestion
const { Contributor, Contribution } = kredits;
```
```suggestion
const contribution = {
```
This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call". This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
```suggestion
robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```
```suggestion
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```
```suggestion
robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```
|
||||
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
|
||||
```suggestion
const { Contributor, Contribution } = kredits;
```
```suggestion
const contribution = {
```
This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call". This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
```suggestion
robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```
```suggestion
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```
```suggestion
robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```
|
||||
}
|
||||
```suggestion
const { Contributor, Contribution } = kredits;
```
```suggestion
const contribution = {
```
This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call". This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
```suggestion
robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```
```suggestion
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```
```suggestion
robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```
|
||||
};
|
||||
}
|
||||
|
||||
|
||||
```suggestion
const { Contributor, Contribution } = kredits;
```
```suggestion
const { Contributor, Contribution } = kredits;
```
```suggestion
const contribution = {
```
```suggestion
const contribution = {
```
This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call". This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call". This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
```suggestion
robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```
```suggestion
robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```
```suggestion
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```
```suggestion
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```
```suggestion
robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```
```suggestion
robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```
|
||||
Reference in New Issue
Block a user
This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".