kredits/hubot-kredits
9
0
Fork 0
Code Issues 8 Pull Requests Releases 9 Activity

Zoom integration #53

Merged
bumi merged 11 commits from feature/zoom into master 2020-04-16 15:34:39 +00:00
Conversation 11 Commits 11 Files Changed 2 +2 -3
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8f961bb102 - Show all commits

5
integrations/zoom.js
View File

@ -1,8 +1,7 @@
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const fetch = require('node-fetch');
module.exports = async function(robot, kredits) {
const Contributor = kredits.Contributor;
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const Contribution = kredits.Contribution;
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const { Contributor, Contribution } = kredits;
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const kreditsContributionAmount = 500;
const kreditsContributionKind = 'community';
@ -17,7 +16,7 @@ module.exports = async function(robot, kredits) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
return getContributorByZoomDisplayName(displayName)
.then(contributor => {
let contribution = {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const contribution = {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 15:11:07 +00:00 (Migrated from github.com)
Review
Copy Link

I think we should not do this. It will be a normal thing in a public call that not everyone is a contributor with a profile.

I think we should not do this. It will be a normal thing in a public call that not everyone is a contributor with a profile.
contributorId: contributor.id,
contributorIpfsHash: contributor.ipfsHash,
amount: kreditsContributionAmount,

raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
Copy Link
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
Copy Link
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review
Copy Link

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
Copy Link
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
Copy Link
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
Copy Link
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```