Zoom integration #53

Merged
bumi merged 11 commits from feature/zoom into master 2020-04-16 15:34:39 +00:00
Showing only changes of commit 960dcb55de - Show all commits

View File

@ -16,30 +16,32 @@ module.exports = async function(robot, kredits) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const walletTransactionCount = await kredits.provider.getTransactionCount(kredits.signer.address);
let nonce = walletTransactionCount;
function createContributionFor(displayName, meeting) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
async function createContributionFor (displayName, meeting) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 15:11:07 +00:00 (Migrated from github.com)
Review

I think we should not do this. It will be a normal thing in a public call that not everyone is a contributor with a profile.

I think we should not do this. It will be a normal thing in a public call that not everyone is a contributor with a profile.
const contributor = await getContributorByZoomDisplayName(displayName);
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
return getContributorByZoomDisplayName(displayName)
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
.then(contributor => {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
if (!contributor) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
robot.logger.error(`[hubot-kredits] Contributor not found: Zoom display name: ${displayName}`);
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
messageRoom(`I tried to add a contribution for zoom user ${displayName}, but did not find a matching contributor profile.`);
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
return;
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
}
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const contribution = {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
contributorId: contributor.id,
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
contributorIpfsHash: contributor.ipfsHash,
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
amount: kreditsContributionAmount,
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
kind: kreditsContributionKind,
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
description: 'Team/Community Call',
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
date: meeting.end_time.split('T')[0],
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
time: meeting.end_time.split('T')[1]
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
}
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
if (!contributor) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
robot.logger.info(`[hubot-kredits] Contributor not found: Zoom display name: ${displayName}`);
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
messageRoom(`I tried to add a contribution for zoom user ${displayName}, but did not find a matching contributor profile.`);
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
return Promise.resolve();
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
}
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
return Contribution.add(contribution, { nonce: nonce++ })
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
.catch(error => {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
robot.logger.error(`[hubot-kredits] Adding contribution failed:`, error);
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
});
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const contribution = {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
contributorId: contributor.id,
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
contributorIpfsHash: contributor.ipfsHash,
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
amount: kreditsContributionAmount,
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
kind: kreditsContributionKind,
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
description: 'Team/Community Call',
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
date: meeting.end_time.split('T')[0],
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
time: meeting.end_time.split('T')[1]
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
}
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
return Contribution.add(contribution, { nonce: nonce++ })
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
.then(tx => {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
})
.catch(error => {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
robot.logger.error(`[hubot-kredits] Adding contribution for Zoom call failed:`, error);
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
});
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
}
function getContributorByZoomDisplayName(displayName) {
@ -72,13 +74,11 @@ module.exports = async function(robot, kredits) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
return;
raucao commented 2020-04-16 15:13:31 +00:00 (Migrated from github.com)
Review

What's the case of tx being falsey (maybe makes sense to explain that in a comment)? Btw, I think we can replace the then with saving the result in a variable from the await, like so:

const tx = await createContributionFor(displayName, meetingDetails);
if (tx) log(foo);
What's the case of tx being falsey (maybe makes sense to explain that in a comment)? Btw, I think we can replace the `then` with saving the result in a variable from the `await`, like so: ```js const tx = await createContributionFor(displayName, meetingDetails); if (tx) log(foo); ```
bumi commented 2020-04-16 15:15:30 +00:00 (Migrated from github.com)
Review

not sure how to best handle this one: https://github.com/67P/hubot-kredits/pull/53/files#diff-74e18db4da1da4461c9ccb134c582a3eR26

if the contributor is not found then there is no tx.

not sure how to best handle this one: https://github.com/67P/hubot-kredits/pull/53/files#diff-74e18db4da1da4461c9ccb134c582a3eR26 if the contributor is not found then there is no tx.
raucao commented 2020-04-16 15:17:05 +00:00 (Migrated from github.com)
Review

Wait, if the contributor is not found, then the promise wouldn't resolve, would it? In that case it should reject.

Wait, if the contributor is not found, then the promise wouldn't resolve, would it? In that case it should reject.
}
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const names = Array.from(new Set(participants.map(p => p.name)));
for(const displayName of names) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
const tx = createContributionFor(displayName, meetingDetails)
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
// if the contributor is not found we do not get a transaction object here
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
if (tx) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
}
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
for (const displayName of names) {
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
await createContributionFor(displayName, meetingDetails);
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
};
}

raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:21:06 +00:00 (Migrated from github.com)
Review
  const { Contributor, Contribution } = kredits;
```suggestion const { Contributor, Contribution } = kredits; ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:23:48 +00:00 (Migrated from github.com)
Review
        const contribution = {
```suggestion const contribution = { ```
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:26:43 +00:00 (Migrated from github.com)
Review

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".

This is a bit of an issue, because we sometimes use the Weekly Call room for other meetings. Not sure what the best solution is. Maybe just something generic like "Team/Community Call".
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:37:06 +00:00 (Migrated from github.com)
Review
      robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`);
```suggestion robot.logger.info(`[hubot-kredits] Ignoring zoom call ${data.uuid} (duration: ${meetingDetails.duration}, participants_count: ${meetingDetails.participants_count})`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:38:17 +00:00 (Migrated from github.com)
Review
          robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`);
```suggestion robot.logger.info(`[hubot-kredits] Contribution created: ${tx.hash}`); ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```
raucao commented 2020-04-16 09:39:58 +00:00 (Migrated from github.com)
Review
  robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => {
```suggestion robot.router.post('/incoming/kredits/zoom/'+process.env.KREDITS_WEBHOOK_TOKEN, (req, res) => { ```