Merge pull request #202 from 67P/chore/fix_js_linting

Fix ESLint setup

.eslintrc.js

@@ -2,13 +2,21 @@
 
 module.exports = {
   root: true,
-  parser: 'babel-eslint',
+  parser: '@babel/eslint-parser',
   parserOptions: {
-    ecmaVersion: 2018,
+    requireConfigFile: false,
+    ecmaVersion: 2020,
     sourceType: 'module',
     ecmaFeatures: {
       legacyDecorators: true
-    }
+    },
+    babelOptions: {
+      babelrc: false,
+      configFile: false,
+      plugins: [
+        ['@babel/plugin-proposal-decorators', { legacy: true }],
+      ],
+    },
   },
   globals: {
     console: true
@@ -28,7 +36,13 @@ module.exports = {
     'no-console': 'off',
     'ember/no-jquery': 'error',
     'ember/require-computed-property-dependencies': 'warn',
-    'ember/no-observers': 'warn'
+    'ember/no-computed-properties-in-native-classes': 'warn',
+    'ember/no-observers': 'warn',
+    'ember/no-classic-classes': 'warn',
+    'ember/no-classic-components': 'warn',
+    'ember/no-controller-access-in-routes': 'warn',
+    'ember/no-actions-hash': 'warn',
+    'ember/require-tagless-components': 'warn'
   },
   overrides: [
     // node files

app/components/add-contribution/component.js

@@ -1,6 +1,6 @@
 import Component from '@ember/component';
 import { computed } from '@ember/object';
-import { alias, and, notEmpty } from '@ember/object/computed';
+import { and, notEmpty } from '@ember/object/computed';
 import { assign } from '@ember/polyfills';
 import moment from 'moment';
 import { inject as service } from '@ember/service';

app/utils/group-by.js

@@ -2,7 +2,6 @@
 // Code from https://github.com/HeroicEric/ember-group-by (MIT licensed)
 //
 import { A } from '@ember/array';
-import { get } from '@ember/object';
 import { isPresent } from '@ember/utils';
 
 export default function groupBy (collection, property) {
@@ -11,11 +10,11 @@ export default function groupBy (collection, property) {
 
   if (items) {
     items.forEach(function(item) {
-      let value = get(item, property);
+      let value = item[property];
       let group = groups.findBy('value', value);
 
       if (isPresent(group)) {
-        get(group, 'items').push(item);
+        group.items.push(item);
       } else {
         group = { property: property, value: value, items: [item] };
         groups.push(group);

package.json

@@ -26,10 +26,11 @@
     "deploy": "git push 5apps master"
   },
   "devDependencies": {
+    "@babel/eslint-parser": "^7.19.1",
+    "@babel/plugin-proposal-decorators": "^7.19.3",
     "@ember/optional-features": "^1.3.0",
     "@glimmer/component": "^1.0.0",
     "@glimmer/tracking": "^1.0.0",
-    "babel-eslint": "^10.1.0",
     "babel-preset-es2015": "^6.22.0",
     "broccoli-asset-rev": "^3.0.0",
     "ember-auto-import": "^1.12.1",
@@ -61,7 +62,7 @@
     "ember-template-lint": "^2.8.0",
     "ember-truth-helpers": "^3.0.0",
     "eslint": "^8.14.0",
-    "eslint-plugin-ember": "^10.6.0",
+    "eslint-plugin-ember": "^11.0.6",
     "eslint-plugin-node": "^11.1.0",
     "ethers": "^5.4.7",
     "fetch-mock": "^9.10.7",

tests/integration/components/contribution-list/component-test.js

@@ -19,8 +19,6 @@ module('Integration | Component | contribution-list', function(hooks) {
     let kredits = this.owner.lookup('service:kredits');
     kredits.set('contributors', contributors);
 
-    debugger;
-
     this.set('fixtures', contributions);
     await render(hbs`{{contribution-list contributions=fixtures showQuickFilter=true}}`);