Merge pull request #50 from 67P/refactor/naming-conventions

Refactor/naming conventions

app/components/add-proposal/component.js

@@ -8,7 +8,7 @@ export default Component.extend({
 
   // Default attributes used by reset
   attributes: {
-    recipientId: null,
+    contributorId: null,
     kind: 'community',
     amount: null,
     description: null,
@@ -22,7 +22,7 @@ export default Component.extend({
 
   contributors: [],
 
-  isValidRecipient: isPresent('recipientId'),
+  isValidRecipient: isPresent('contributorId'),
   isValidAmount: computed('amount', function() {
     return parseInt(this.get('amount'), 10) > 0;
   }),

app/components/add-proposal/template.hbs

@@ -1,9 +1,9 @@
 <form {{action "submit" on="submit"}}>
   <p>
-    <select required onchange={{action (mut recipientId) value="target.value"}}>
+    <select required onchange={{action (mut contributorId) value="target.value"}}>
       <option value="" selected disabled hidden>Contributor</option>
       {{#each contributors as |contributor|}}
-        <option value={{contributor.id}} selected={{eq recipientId contributor.id}}>{{contributor.github_username}}</option>
+        <option value={{contributor.id}} selected={{eq contributorId contributor.id}}>{{contributor.github_username}}</option>
       {{/each}}
     </select>
   </p>

app/controllers/index.js

@@ -26,7 +26,7 @@ export default Controller.extend({
     return this.get('model.proposals')
                .map((proposal) => {
                  let contributor = this.get('contributors')
-                                       .findBy('id', proposal.get('recipientId'));
+                                       .findBy('id', proposal.get('contributorId'));
 
                  proposal.set('contributor', contributor);
 
@@ -52,10 +52,9 @@ export default Controller.extend({
     this.get('proposals').pushObject(proposal);
   },
 
-  _handleProposalExecuted(proposalId, recipientId, amount) {
+  _handleProposalExecuted(proposalId, contributorId, amount) {
-    // TODO: check if proposalId is already a string
     let proposal = this.get('proposals')
-                       .findBy('id', proposalId.toString());
+                       .findBy('id', proposalId);
 
     if (proposal.get('isExecuted')) {
       Ember.Logger.debug('[index] proposal already executed, not adding from event');
@@ -67,13 +66,13 @@ export default Controller.extend({
     });
 
     this.get('contributors')
-        .findBy('id', recipientId.toString())
+        .findBy('id', contributorId)
         .incrementProperty('balance', amount);
   },
 
   _handleProposalVoted(proposalId, voter, totalVotes) {
     this.get('proposals')
-        .findBy('id', proposalId.toString())
+        .findBy('id', proposalId)
         .setProperties({ 'votesCount': totalVotes });
   },
 

app/controllers/proposals/new.js

@@ -11,7 +11,7 @@ export default Controller.extend({
   actions: {
     save(proposal) {
       // contributorIpfsHash is needed for the proposal ipfs data. I'm not happy to do this here but I think to load all the contributors in addProposal again is a bit too much. I hope we can refactor it later.
-      let contributor = this.get('contributors').findBy('id', proposal.recipientId);
+      let contributor = this.get('contributors').findBy('id', proposal.contributorId);
       proposal.contributorIpfsHash = contributor.get('ipfsHash');
 
       return this.get('kredits').addProposal(proposal)

app/lib/kredits/contracts/operator.js

@@ -47,7 +47,7 @@ export default class Operator extends Base {
       .add(json)
       .then((ipfsHashAttr) => {
         let proposal = [
-          proposalAttr.recipientId,
+          proposalAttr.contributorId,
           proposalAttr.amount,
           ipfsHashAttr.ipfsHash,
           ipfsHashAttr.hashFunction,

app/models/proposal.js

@@ -5,8 +5,8 @@ import bignumber from 'kredits-web/utils/cps/bignumber';
 export default EmberObject.extend({
   // Contract
   id: bignumber('idRaw', 'toString'),
-  creatorAddress: null,
+  creatorAccount: null,
-  recipientId: bignumber('recipientIdRaw', 'toString'),
+  contributorId: bignumber('contributorIdRaw', 'toString'),
   amount: bignumber('amountRaw', 'toNumber'),
   votesCount: bignumber('votesCountRaw', 'toNumber'),
   votesNeeded: bignumber('votesNeededRaw', 'toNumber'),

app/utils/cps/bignumber.js

@@ -1,4 +1,5 @@
 import computed from 'ember-computed';
+import ethers from 'npm:ethers';
 
 export default function(dependentKey, converterMethod) {
   return computed(dependentKey, {
@@ -6,6 +7,7 @@ export default function(dependentKey, converterMethod) {
       return this.get(dependentKey)[converterMethod]();
     },
     set (key, value) {
+      value = ethers.utils.bigNumberify(value);
       this.set(dependentKey, value);
       return value[converterMethod]();
     }

tests/unit/controllers/index-test.js

@@ -23,9 +23,6 @@ let addFixtures = function(controller) {
     { github_username: "trinity", github_uid: "123", balance: 5000 },
     { github_username: "mouse", github_uid: "696", balance: 0 }
   ].forEach(fixture => {
-    // we expect a bignumer but I don't want to add the bignumber dependency here... so this is some hack to return an object that looks good enough for the test
-    let fakeBignumber = function(balance) { return { toNumber: function() { return balance; } }; };
-    fixture.balance = fakeBignumber(fixture.balance);
     controller.get('model.contributors').push(Contributor.create(fixture));
   });
 };