From 642015700eab0b3b8a5ff6c70857f9452b04c990 Mon Sep 17 00:00:00 2001 From: Garret Alfert Date: Wed, 3 May 2017 11:53:21 +0200 Subject: [PATCH] Don't resolve promises after rejecting them --- app/services/kredits.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/services/kredits.js b/app/services/kredits.js index cf876ff..0100572 100644 --- a/app/services/kredits.js +++ b/app/services/kredits.js @@ -54,7 +54,7 @@ export default Ember.Service.extend({ getValueFromContract(contractMethod, ...args) { return new Ember.RSVP.Promise((resolve, reject) => { this.get('kreditsContract')[contractMethod](...args, (err, data) => { - if (err) { reject(err); } + if (err) { reject(err); return; } resolve(data); }); }); @@ -132,7 +132,7 @@ export default Ember.Service.extend({ Ember.Logger.debug('[kredits] vote for', proposalId); return new Ember.RSVP.Promise((resolve, reject) => { this.get('kreditsContract').vote(proposalId, (err, data) => { - if (err) { reject(err); } + if (err) { reject(err); return; } Ember.Logger.debug('[kredits] vote response', data); resolve(data); }); @@ -156,7 +156,7 @@ export default Ember.Service.extend({ contributor.set('ipfsHash', ipfsHash); console.debug('ADD', address, name, ipfsHash, isCore, id); this.get('kreditsContract').addContributor(address, name, ipfsHash, isCore, id, (err, data) => { - if (err) { reject(err); } + if (err) { reject(err); return; } Ember.Logger.debug('[kredits] add contributor response', data); resolve(contributor); });