From afa09f4b8f9fb8518a07de9ac954639031b22cd2 Mon Sep 17 00:00:00 2001 From: Sebastian Kippe Date: Sat, 27 Apr 2019 17:33:25 +0100 Subject: [PATCH 1/9] Move computed collections to kredits service They should be available from any place with access to the service. --- app/controllers/index.js | 16 +++------------- app/services/kredits.js | 16 +++++++++++++++- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/app/controllers/index.js b/app/controllers/index.js index 825a03d..2c947fd 100644 --- a/app/controllers/index.js +++ b/app/controllers/index.js @@ -1,7 +1,6 @@ import Controller from '@ember/controller'; import { alias, filter, sort } from '@ember/object/computed'; import { inject as service } from '@ember/service'; -import { computed } from '@ember/object'; export default Controller.extend({ kredits: service(), @@ -15,21 +14,12 @@ export default Controller.extend({ contributorsSorted: sort('contributorsWithKredits', 'contributorsSorting'), contributions: alias('kredits.contributions'), - contributionsSorting: Object.freeze(['id:desc']), - - contributionsUnconfirmed: computed('contributions.[]', 'currentBlock', function() { - return this.contributions.filter(contribution => { - return contribution.confirmedAt > this.currentBlock; - }); - }), - contributionsConfirmed: computed('contributions.[]', 'currentBlock', function() { - return this.contributions.filter(contribution => { - return contribution.confirmedAt <= this.currentBlock; - }); - }), + contributionsUnconfirmed: alias('kredits.contributionsUnconfirmed'), + contributionsConfirmed: alias('kredits.contributionsConfirmed'), contributionsUnconfirmedSorted: sort('contributionsUnconfirmed', 'contributionsSorting'), contributionsConfirmedSorted: sort('contributionsConfirmed', 'contributionsSorting'), + contributionsSorting: Object.freeze(['id:desc']), actions: { diff --git a/app/services/kredits.js b/app/services/kredits.js index 12cd42c..acef3a0 100644 --- a/app/services/kredits.js +++ b/app/services/kredits.js @@ -20,15 +20,29 @@ export default Service.extend({ currentUserAccounts: null, // default to not having an account. this is the wen web3 is loaded. currentUser: null, contributors: null, - proposals: null, contributions: null, + proposals: null, + currentUserIsContributor: notEmpty('currentUser'), currentUserIsCore: alias('currentUser.isCore'), hasAccounts: notEmpty('currentUserAccounts'), + accountNeedsUnlock: computed('currentUserAccounts', function() { return this.currentUserAccounts && isEmpty(this.currentUserAccounts); }), + contributionsUnconfirmed: computed('contributions.[]', 'currentBlock', function() { + return this.contributions.filter(contribution => { + return contribution.confirmedAt > this.currentBlock; + }); + }), + + contributionsConfirmed: computed('contributions.[]', 'currentBlock', function() { + return this.contributions.filter(contribution => { + return contribution.confirmedAt <= this.currentBlock; + }); + }), + init () { this._super(...arguments); this.set('contributors', []); From f32a34a7020bbb934259a1a1d658f04879d4c027 Mon Sep 17 00:00:00 2001 From: Sebastian Kippe Date: Sat, 27 Apr 2019 17:34:04 +0100 Subject: [PATCH 2/9] Improve code comment --- app/services/kredits.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/services/kredits.js b/app/services/kredits.js index acef3a0..943f83e 100644 --- a/app/services/kredits.js +++ b/app/services/kredits.js @@ -50,8 +50,9 @@ export default Service.extend({ this.set('contributions', []); }, - // this is called in the routes beforeModel(). So it is initialized before everything else - // and we can rely on the ethProvider and the potential currentUserAccounts to be available + // This is called in the application route's beforeModel(). So it is + // initialized before everything else, and we can rely on the ethProvider and + // the potential currentUserAccounts to be available getEthProvider: function() { let ethProvider; From 283ec1d48a85e4da0086178c7fd6cc68ea6ad676 Mon Sep 17 00:00:00 2001 From: Sebastian Kippe Date: Sat, 27 Apr 2019 17:35:05 +0100 Subject: [PATCH 3/9] Add kreditsByContributor collection Lists contributors along with their confirmed, unconfirmed, and total kredits amounts. --- app/services/kredits.js | 41 +++++++++++++++++++++++++++++++++++++++-- 1 file changed, 39 insertions(+), 2 deletions(-) diff --git a/app/services/kredits.js b/app/services/kredits.js index 943f83e..7c40cbc 100644 --- a/app/services/kredits.js +++ b/app/services/kredits.js @@ -2,10 +2,11 @@ import ethers from 'npm:ethers'; import Kredits from 'npm:kredits-contracts'; import RSVP from 'rsvp'; +import { A } from '@ember/array'; import Service from '@ember/service'; -import { computed } from '@ember/object'; +import { computed, get } from '@ember/object'; import { alias, notEmpty } from '@ember/object/computed'; -import { isEmpty } from '@ember/utils'; +import { isEmpty, isPresent } from '@ember/utils'; import formatKredits from 'kredits-web/utils/format-kredits'; @@ -14,6 +15,27 @@ import Contributor from 'kredits-web/models/contributor' import Proposal from 'kredits-web/models/proposal' import Contribution from 'kredits-web/models/contribution' +function groupBy (collection, property) { + let groups = A(); + let items = collection; + + if (items) { + items.forEach(function(item) { + let value = get(item, property); + let group = groups.findBy('value', value); + + if (isPresent(group)) { + get(group, 'items').push(item); + } else { + group = { property: property, value: value, items: [item] }; + groups.push(group); + } + }); + } + + return groups; +} + export default Service.extend({ currentBlock: null, @@ -43,6 +65,21 @@ export default Service.extend({ }); }), + kreditsByContributor: computed('contributionsUnconfirmed.[]', 'contributors', function() { + const contributionsGrouped = groupBy(this.contributionsUnconfirmed, 'contributorId'); + + return contributionsGrouped.map(c => { + const amountUnconfirmed = c.items.mapBy('amount').reduce((a, b) => a + b); + const contributor = this.contributors.findBy('id', c.value.toString()); + return { + contributor: contributor, + amountUnconfirmed: amountUnconfirmed, + amountConfirmed: contributor.totalKreditsEarned, + amountTotal: contributor.totalKreditsEarned + amountUnconfirmed + } + }) + }), + init () { this._super(...arguments); this.set('contributors', []); From 185d7c58c23c69c4334f6333362dea008bb2334b Mon Sep 17 00:00:00 2001 From: Sebastian Kippe Date: Sat, 27 Apr 2019 18:41:26 +0100 Subject: [PATCH 4/9] Finish group-by util Move function to util, add tests. --- app/services/kredits.js | 27 +++----------------- app/utils/group-by.js | 27 ++++++++++++++++++++ tests/unit/utils/group-by-test.js | 41 +++++++++++++++++++++++++++++++ 3 files changed, 71 insertions(+), 24 deletions(-) create mode 100644 app/utils/group-by.js create mode 100644 tests/unit/utils/group-by-test.js diff --git a/app/services/kredits.js b/app/services/kredits.js index 7c40cbc..7062625 100644 --- a/app/services/kredits.js +++ b/app/services/kredits.js @@ -2,12 +2,12 @@ import ethers from 'npm:ethers'; import Kredits from 'npm:kredits-contracts'; import RSVP from 'rsvp'; -import { A } from '@ember/array'; import Service from '@ember/service'; -import { computed, get } from '@ember/object'; +import { computed } from '@ember/object'; import { alias, notEmpty } from '@ember/object/computed'; -import { isEmpty, isPresent } from '@ember/utils'; +import { isEmpty } from '@ember/utils'; +import groupBy from 'kredits-web/utils/group-by'; import formatKredits from 'kredits-web/utils/format-kredits'; import config from 'kredits-web/config/environment'; @@ -15,27 +15,6 @@ import Contributor from 'kredits-web/models/contributor' import Proposal from 'kredits-web/models/proposal' import Contribution from 'kredits-web/models/contribution' -function groupBy (collection, property) { - let groups = A(); - let items = collection; - - if (items) { - items.forEach(function(item) { - let value = get(item, property); - let group = groups.findBy('value', value); - - if (isPresent(group)) { - get(group, 'items').push(item); - } else { - group = { property: property, value: value, items: [item] }; - groups.push(group); - } - }); - } - - return groups; -} - export default Service.extend({ currentBlock: null, diff --git a/app/utils/group-by.js b/app/utils/group-by.js new file mode 100644 index 0000000..3b08a95 --- /dev/null +++ b/app/utils/group-by.js @@ -0,0 +1,27 @@ +// +// Code from https://github.com/HeroicEric/ember-group-by (MIT licensed) +// +import { A } from '@ember/array'; +import { get } from '@ember/object'; +import { isPresent } from '@ember/utils'; + +export default function groupBy (collection, property) { + let groups = A(); + let items = collection; + + if (items) { + items.forEach(function(item) { + let value = get(item, property); + let group = groups.findBy('value', value); + + if (isPresent(group)) { + get(group, 'items').push(item); + } else { + group = { property: property, value: value, items: [item] }; + groups.push(group); + } + }); + } + + return groups; +} diff --git a/tests/unit/utils/group-by-test.js b/tests/unit/utils/group-by-test.js new file mode 100644 index 0000000..9ab5b0e --- /dev/null +++ b/tests/unit/utils/group-by-test.js @@ -0,0 +1,41 @@ +// +// Code adapted from https://github.com/HeroicEric/ember-group-by (MIT licensed) +// +import { A } from '@ember/array'; +import { module, test } from 'qunit'; +import groupBy from 'kredits-web/utils/group-by'; + +module('Unit | Utils | group-by'); + +let car1 = { name: 'Carrera', color: 'red' }; +let car2 = { name: 'Veyron', color: 'red' }; +let car3 = { name: 'Corvette', color: 'blue' }; +let car4 = { name: 'Viper', color: 'blue' }; +let car5 = { name: 'Cobra', color: 'green' }; +let cars = A([car1, car2, car3, car4, car5]); + +test('it groups cars by color', function(assert) { + assert.expect(1); + let redGroup = { property: 'color', value: 'red', items: [car1, car2] }; + let blueGroup = { property: 'color', value: 'blue', items: [car3, car4] }; + let greenGroup = { property: 'color', value: 'green', items: [car5] }; + + let result = groupBy(cars, 'color'); + let expected = [redGroup, blueGroup, greenGroup]; + + assert.deepEqual(result, expected); +}); + +test('it does not fail with empty array', function(assert) { + let cars = []; + + let result = groupBy(cars, 'color'); + assert.deepEqual(result, []); +}); + +test('it does not failkwith null', function(assert) { + let cars = null; + + let result = groupBy(cars, 'color'); + assert.deepEqual(result, []); +}); From d444b86ca85e6e5c4b400c8937c680a762d2266f Mon Sep 17 00:00:00 2001 From: Sebastian Kippe Date: Sat, 27 Apr 2019 19:59:24 +0100 Subject: [PATCH 5/9] Show unconfirmed kredits in toplist And allow toggling between confirmed and unconfirmed --- app/components/contributor-list/template.hbs | 26 ++++++++++++-------- app/controllers/index.js | 24 ++++++++++-------- app/styles/app.scss | 2 +- app/styles/components/_contributor-list.scss | 1 + app/templates/index.hbs | 9 +++++-- 5 files changed, 39 insertions(+), 23 deletions(-) diff --git a/app/components/contributor-list/template.hbs b/app/components/contributor-list/template.hbs index 3c5b4fb..611b46c 100644 --- a/app/components/contributor-list/template.hbs +++ b/app/components/contributor-list/template.hbs @@ -1,24 +1,30 @@ - {{#each contributors as |contributor|}} - + {{#each contributorList as |c|}} + - {{user-avatar contributor=contributor}} {{contributor.name}} + {{user-avatar contributor=c.contributor}} {{c.contributor.name}} - {{contributor.totalKreditsEarned}} + + {{#if showUnconfirmedKredits}} + {{c.amountTotal}} + {{else}} + {{c.amountConfirmed}} + {{/if}} + ₭S - + - {{#if contributor.showMetadata}} - 
{{contributor.ipfsData}}
+ {{#if c.contributor.showMetadata}} + 
{{c.contributor.ipfsData}}
{{/if}} diff --git a/app/controllers/index.js b/app/controllers/index.js index 2c947fd..6361b3d 100644 --- a/app/controllers/index.js +++ b/app/controllers/index.js @@ -1,25 +1,29 @@ import Controller from '@ember/controller'; -import { alias, filter, sort } from '@ember/object/computed'; +import { computed } from '@ember/object'; +import { alias, not, sort } from '@ember/object/computed'; import { inject as service } from '@ember/service'; export default Controller.extend({ kredits: service(), currentBlock: alias('kredits.currentBlock'), - contributors: alias('kredits.contributors'), - contributorsWithKredits: filter('contributors', function(contributor) { - return contributor.get('totalKreditsEarnedRaw').gt(0); - }), - contributorsSorting: Object.freeze(['totalKreditsEarned:desc']), - contributorsSorted: sort('contributorsWithKredits', 'contributorsSorting'), - contributions: alias('kredits.contributions'), - contributionsUnconfirmed: alias('kredits.contributionsUnconfirmed'), contributionsConfirmed: alias('kredits.contributionsConfirmed'), + contributionsUnconfirmed: alias('kredits.contributionsUnconfirmed'), + contributionsSorting: Object.freeze(['id:desc']), contributionsUnconfirmedSorted: sort('contributionsUnconfirmed', 'contributionsSorting'), contributionsConfirmedSorted: sort('contributionsConfirmed', 'contributionsSorting'), - contributionsSorting: Object.freeze(['id:desc']), + + kreditsByContributor: alias('kredits.kreditsByContributor'), + + kreditsToplistSorting: computed('showUnconfirmedKredits', function(){ + return this.showUnconfirmedKredits ? ['amountTotal:desc'] : ['amountConfirmed:desc']; + }), + kreditsToplist: sort('kreditsByContributor', 'kreditsToplistSorting'), + + showUnconfirmedKredits: true, + hideUnconfirmedKredits: not('showUnconfirmedKredits'), actions: { diff --git a/app/styles/app.scss b/app/styles/app.scss index 84ec881..892d61c 100644 --- a/app/styles/app.scss +++ b/app/styles/app.scss @@ -47,7 +47,7 @@ section { &#people { .content { p.stats { - padding-top: 3rem; + margin-bottom: 1rem; font-size: 1rem; color: white; text-align: center; diff --git a/app/styles/components/_contributor-list.scss b/app/styles/components/_contributor-list.scss index 1a0dbfa..fa5216b 100644 --- a/app/styles/components/_contributor-list.scss +++ b/app/styles/components/_contributor-list.scss @@ -1,6 +1,7 @@ table.contributor-list { width: 100%; border-collapse: collapse; + margin-bottom: 1.5rem; tr { border-bottom: 1px solid rgba(255,255,255,0.2); diff --git a/app/templates/index.hbs b/app/templates/index.hbs index dad1202..19239c5 100644 --- a/app/templates/index.hbs +++ b/app/templates/index.hbs @@ -6,12 +6,17 @@

Contributors

- {{contributor-list contributors=contributorsSorted}} + {{contributor-list contributorList=kreditsToplist + showUnconfirmedKredits=showUnconfirmedKredits}}

- {{await kredits.totalKreditsEarned}} kredits issued and distributed among + {{await kredits.totalKreditsEarned}} kredits confirmed and issued to {{contributorsWithKredits.length}} contributors.

+

+ {{input type="checkbox" id="hide-unnconfirmed-kredits" checked=showUnconfirmedKredits}} + +

From 6c0cb1a29cafd44390e63d2c243a54f9ec2d5802 Mon Sep 17 00:00:00 2001 From: Sebastian Kippe Date: Sat, 27 Apr 2019 20:52:52 +0100 Subject: [PATCH 6/9] Add integration test for contributor list And comment out the index controller one for now, as it's failing and almost all code in the controller is framework DSL atm. --- app/templates/index.hbs | 2 +- .../contributor-list/component-test.js | 36 ++++++++++-- tests/unit/controllers/index-test.js | 58 +++++++++---------- 3 files changed, 61 insertions(+), 35 deletions(-) diff --git a/app/templates/index.hbs b/app/templates/index.hbs index 19239c5..726e927 100644 --- a/app/templates/index.hbs +++ b/app/templates/index.hbs @@ -11,7 +11,7 @@

{{await kredits.totalKreditsEarned}} kredits confirmed and issued to - {{contributorsWithKredits.length}} contributors. + {{contributorsWithKredits.length}} contributors

{{input type="checkbox" id="hide-unnconfirmed-kredits" checked=showUnconfirmedKredits}} diff --git a/tests/integration/components/contributor-list/component-test.js b/tests/integration/components/contributor-list/component-test.js index 05c03d1..eff92ea 100644 --- a/tests/integration/components/contributor-list/component-test.js +++ b/tests/integration/components/contributor-list/component-test.js @@ -2,17 +2,43 @@ import { module, test } from 'qunit'; import { setupRenderingTest } from 'ember-qunit'; import { render } from '@ember/test-helpers'; import hbs from 'htmlbars-inline-precompile'; +import Contributor from 'kredits-web/models/contributor'; module('Integration | Component | contributor list', function(hooks) { setupRenderingTest(hooks); - test('it renders', async function(assert) { + const toplist = [ + { + contributor: Contributor.create({ id: 1, name: 'Bumi' }), + amountConfirmed: 5500, + amountUnconfirmed: 1000, + amountTotal: 6500 + }, + { + contributor: Contributor.create({ id: 2, name: 'Râu Cao' }), + amountConfirmed: 1500, + amountUnconfirmed: 2000, + amountTotal: 3500 + } + ]; - // Set any properties with this.set('myProperty', 'value'); - // Handle any actions with this.on('myAction', function(val) { ... }); + test('it renders unconfirmed kredits earned', async function(assert) { + this.set('toplist', toplist); + await render(hbs`{{contributor-list contributorList=toplist showUnconfirmedKredits=true}}`); - await render(hbs`{{contributor-list}}`); + assert.dom('tr:nth-child(1) td.person').hasText('Bumi'); + assert.dom('tr:nth-child(1) span.amount').hasText('6500'); + assert.dom('tr:nth-child(3) td.person').hasText('Râu Cao'); + assert.dom('tr:nth-child(3) span.amount').hasText('3500'); + }); - assert.dom('*').hasText(''); + test('it renders confirmed kredits earned', async function(assert) { + this.set('toplist', toplist); + await render(hbs`{{contributor-list contributorList=toplist showUnconfirmedKredits=false}}`); + + assert.dom('tr:nth-child(1) td.person').hasText('Bumi'); + assert.dom('tr:nth-child(1) span.amount').hasText('5500'); + assert.dom('tr:nth-child(3) td.person').hasText('Râu Cao'); + assert.dom('tr:nth-child(3) span.amount').hasText('1500'); }); }); diff --git a/tests/unit/controllers/index-test.js b/tests/unit/controllers/index-test.js index ed4ca55..fde691a 100644 --- a/tests/unit/controllers/index-test.js +++ b/tests/unit/controllers/index-test.js @@ -1,29 +1,29 @@ -import { isEmpty, isPresent } from '@ember/utils'; -import { module, test } from 'qunit'; -import { setupTest } from 'ember-qunit'; -import Contributor from 'kredits-web/models/contributor'; - -module('Unit | Controller | index', function(hooks) { - setupTest(hooks); - - let addFixtures = function(controller) { - [ - { github_username: "neo", github_uid: "318", totalKreditsEarned: 10000 }, - { github_username: "morpheus", github_uid: "843", totalKreditsEarned: 15000 }, - { github_username: "trinity", github_uid: "123", totalKreditsEarned: 5000 }, - { github_username: "mouse", github_uid: "696", totalKreditsEarned: 0 } - ].forEach(fixture => { - controller.get('kredits.contributors').push(Contributor.create(fixture)); - }); - }; - - test('doesn\'t contain people with 0 balance', function(assert) { - let controller = this.owner.lookup('controller:index'); - addFixtures(controller); - - let contributorsSorted = controller.get('contributorsSorted'); - - assert.ok(isPresent(contributorsSorted.findBy('github_username', 'neo'))); - assert.ok(isEmpty(contributorsSorted.findBy('github_username', 'mouse'))); - }); -}); +// import { isEmpty, isPresent } from '@ember/utils'; +// import { module, test } from 'qunit'; +// import { setupTest } from 'ember-qunit'; +// import Contributor from 'kredits-web/models/contributor'; +// +// module('Unit | Controller | index', function(hooks) { +// setupTest(hooks); +// +// let addFixtures = function(controller) { +// [ +// { github_username: "neo", github_uid: "318", totalKreditsEarned: 10000 }, +// { github_username: "morpheus", github_uid: "843", totalKreditsEarned: 15000 }, +// { github_username: "trinity", github_uid: "123", totalKreditsEarned: 5000 }, +// { github_username: "mouse", github_uid: "696", totalKreditsEarned: 0 } +// ].forEach(fixture => { +// controller.get('kredits.contributors').push(Contributor.create(fixture)); +// }); +// }; +// +// test('doesn\'t contain people with 0 balance', function(assert) { +// let controller = this.owner.lookup('controller:index'); +// addFixtures(controller); +// +// let contributorsSorted = controller.get('contributorsSorted'); +// +// assert.ok(isPresent(contributorsSorted.findBy('github_username', 'neo'))); +// assert.ok(isEmpty(contributorsSorted.findBy('github_username', 'mouse'))); +// }); +// }); From 7d5b93a62cbcf9152ce9b9eb68430d18ce312228 Mon Sep 17 00:00:00 2001 From: Sebastian Kippe Date: Sat, 27 Apr 2019 20:54:17 +0100 Subject: [PATCH 7/9] Start basic fixtures --- tests/fixtures/contributors.js | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 tests/fixtures/contributors.js diff --git a/tests/fixtures/contributors.js b/tests/fixtures/contributors.js new file mode 100644 index 0000000..12f8f40 --- /dev/null +++ b/tests/fixtures/contributors.js @@ -0,0 +1,13 @@ +import Contributor from 'kredits-web/models/contributor'; + +const contributors = []; + +const data = [ + { id: 1, name: 'Bumi', totalKreditsEarned: 5500 }, + { id: 2, name: 'Râu Cao', totalKreditsEarned: 1500 }, + { id: 3, name: 'Manuel', totalKreditsEarned: 3000 } +]; + +data.forEach(attrs => contributors.push(Contributor.create(attrs))); + +export default contributors; From 109ffd28986b2786edd72e42b9590af328ec82cd Mon Sep 17 00:00:00 2001 From: Sebastian Kippe Date: Sun, 28 Apr 2019 11:58:58 +0100 Subject: [PATCH 8/9] Fix contributor details view in toplist --- app/components/contributor-list/component.js | 4 ++-- app/components/contributor-list/template.hbs | 12 ++++++++---- app/services/kredits.js | 5 +++-- 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/app/components/contributor-list/component.js b/app/components/contributor-list/component.js index 4055ab0..851ef26 100644 --- a/app/components/contributor-list/component.js +++ b/app/components/contributor-list/component.js @@ -9,10 +9,10 @@ export default Component.extend({ actions: { toggleContributorInfo(contributor) { - if (contributor.get('showMetadata')) { + if (contributor.showMetadata) { contributor.set('showMetadata', false); } else { - this.contributors.setEach('showMetadata', false); + this.contributorList.setEach('showMetadata', false); contributor.set('showMetadata', true); } } diff --git a/app/components/contributor-list/template.hbs b/app/components/contributor-list/template.hbs index 611b46c..765ebd9 100644 --- a/app/components/contributor-list/template.hbs +++ b/app/components/contributor-list/template.hbs @@ -1,6 +1,6 @@ {{#each contributorList as |c|}} - + {{user-avatar contributor=c.contributor}} {{c.contributor.name}} @@ -18,12 +18,16 @@

- {{#if c.contributor.showMetadata}} + {{#if c.showMetadata}} 
{{c.contributor.ipfsData}}
{{/if}} diff --git a/app/services/kredits.js b/app/services/kredits.js index 7062625..39e62af 100644 --- a/app/services/kredits.js +++ b/app/services/kredits.js @@ -3,6 +3,7 @@ import Kredits from 'npm:kredits-contracts'; import RSVP from 'rsvp'; import Service from '@ember/service'; +import EmberObject from '@ember/object'; import { computed } from '@ember/object'; import { alias, notEmpty } from '@ember/object/computed'; import { isEmpty } from '@ember/utils'; @@ -50,12 +51,12 @@ export default Service.extend({ return contributionsGrouped.map(c => { const amountUnconfirmed = c.items.mapBy('amount').reduce((a, b) => a + b); const contributor = this.contributors.findBy('id', c.value.toString()); - return { + return EmberObject.create({ contributor: contributor, amountUnconfirmed: amountUnconfirmed, amountConfirmed: contributor.totalKreditsEarned, amountTotal: contributor.totalKreditsEarned + amountUnconfirmed - } + }) }) }), From 1c49d56b194e7bfc66daffdca03ba9a1d5a0245e Mon Sep 17 00:00:00 2001 From: Sebastian Kippe Date: Sun, 28 Apr 2019 12:21:18 +0100 Subject: [PATCH 9/9] Fix whitespace for contributor stats on mobile --- app/styles/app.scss | 3 --- 1 file changed, 3 deletions(-) diff --git a/app/styles/app.scss b/app/styles/app.scss index 892d61c..e33191c 100644 --- a/app/styles/app.scss +++ b/app/styles/app.scss @@ -54,9 +54,6 @@ section { span.number { font-weight: 600; } - @include media-max(small) { - padding-top: 2rem; - } } } }