From 8d303ea5af0455cab188a8289df9d0f000ff7e10 Mon Sep 17 00:00:00 2001 From: Sebastian Kippe Date: Tue, 17 Apr 2018 01:38:21 +0200 Subject: [PATCH] Fix tests, remove obsolete initializers --- app/initializers/defer-loading.js | 20 -------------------- app/initializers/register-models.js | 10 ---------- tests/unit/models/contributor-test.js | 5 ++--- 3 files changed, 2 insertions(+), 33 deletions(-) delete mode 100644 app/initializers/defer-loading.js delete mode 100644 app/initializers/register-models.js diff --git a/app/initializers/defer-loading.js b/app/initializers/defer-loading.js deleted file mode 100644 index 6cd1b14..0000000 --- a/app/initializers/defer-loading.js +++ /dev/null @@ -1,20 +0,0 @@ -/** - * This pauses the app's boot process until the window load event is fired. - * It allows the user provided Web3 instance (e.g. Metamask, Mist Browser) - * to be inserted before we try to use it. - */ -export default { - name: 'defer-loading', - initialize: function(application) { - // Load event already fired, so web3 should be loaded if available - if (window.windowLoadComplete) { return true; } - - // Pause app loading - application.deferReadiness(); - - window.addEventListener('load', function() { - // Continue app loading - application.advanceReadiness(); - }); - } -}; diff --git a/app/initializers/register-models.js b/app/initializers/register-models.js deleted file mode 100644 index afd16dd..0000000 --- a/app/initializers/register-models.js +++ /dev/null @@ -1,10 +0,0 @@ -import Contributor from 'kredits-web/models/contributor'; -import Proposal from 'kredits-web/models/proposal'; - -export default { - name: 'register-models', - initialize: function(app) { - app.register('model:contributor', Contributor, { singleton: false }); - app.register('model:proposal', Proposal, { singleton: false }); - } -}; diff --git a/tests/unit/models/contributor-test.js b/tests/unit/models/contributor-test.js index 6186eb9..ff58ec0 100644 --- a/tests/unit/models/contributor-test.js +++ b/tests/unit/models/contributor-test.js @@ -1,13 +1,12 @@ import { module, test } from 'qunit'; import { setupTest } from 'ember-qunit'; - -import { run } from '@ember/runloop'; +import Contributor from 'kredits-web/models/contributor'; module('Unit | Model | contributor', function(hooks) { setupTest(hooks); test('#avatarURL() returns correct URL', function(assert) { - let model = run(() => this.owner.lookup('service:store').createRecord('contributor')); + let model = Contributor.create(); model.set('github_uid', '318'); assert.equal(model.get('avatarURL'), 'https://avatars2.githubusercontent.com/u/318?v=3&s=128');