From 7236b2d2b3d8c643e91e67c36c9ddda01089108d Mon Sep 17 00:00:00 2001 From: Sebastian Kippe Date: Fri, 12 Jul 2019 20:16:06 +0200 Subject: [PATCH 1/3] Add basics for contribution details Route, controller, links, selected property/styles, etc. --- app/components/contribution-list/component.js | 8 +++++ app/components/contribution-list/template.hbs | 12 +++---- app/components/contributor-list/component.js | 1 + app/components/contributor-list/template.hbs | 5 ++- app/controllers/dashboard.js | 1 + app/router.js | 4 +++ app/routes/dashboard/contributions/show.js | 32 +++++++++++++++++++ app/styles/components/_contribution-list.scss | 5 +++ app/templates/dashboard.hbs | 2 ++ .../dashboard/contributions/show.hbs | 16 ++++++++++ .../dashboard/contributions/show-test.js | 11 +++++++ 11 files changed, 86 insertions(+), 11 deletions(-) create mode 100644 app/routes/dashboard/contributions/show.js create mode 100644 app/templates/dashboard/contributions/show.hbs create mode 100644 tests/unit/routes/dashboard/contributions/show-test.js diff --git a/app/components/contribution-list/component.js b/app/components/contribution-list/component.js index edb7efe..ceebc4a 100644 --- a/app/components/contribution-list/component.js +++ b/app/components/contribution-list/component.js @@ -6,9 +6,13 @@ import { inject as service } from '@ember/service'; export default Component.extend({ + router: service(), + tagName: 'div', classNames: ['contributions'], + selectedContribution: null, + showQuickFilter: false, hideSmallContributions: false, contributorId: null, @@ -57,6 +61,10 @@ export default Component.extend({ } else { window.alert('Only members can veto contributions. Please ask someone to set you up.'); } + }, + + openContributionDetails(contribution) { + this.router.transitionTo('dashboard.contributions.show', contribution); } } diff --git a/app/components/contribution-list/template.hbs b/app/components/contribution-list/template.hbs index 94a32aa..d6495a6 100644 --- a/app/components/contribution-list/template.hbs +++ b/app/components/contribution-list/template.hbs @@ -31,17 +31,13 @@