From bfa0b350aca3151e37731b6d6a8cea5248942c1b Mon Sep 17 00:00:00 2001
From: Garret Alfert <alfert@wevelop.de>
Date: Tue, 26 Mar 2019 23:07:19 +0100
Subject: [PATCH] Fix template linting errors

---
 app/components/add-contributor/template.hbs        | 14 +++++++-------
 app/components/add-proposal/template.hbs           | 10 +++++-----
 .../chart-contributions-by-type/template.hbs       |  2 +-
 app/components/contributor-list/template.hbs       |  6 +++---
 app/templates/index.hbs                            |  4 ++--
 app/templates/proposals/new.hbs                    |  2 +-
 6 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/app/components/add-contributor/template.hbs b/app/components/add-contributor/template.hbs
index c47fd92..235c535 100644
--- a/app/components/add-contributor/template.hbs
+++ b/app/components/add-contributor/template.hbs
@@ -13,7 +13,7 @@
             type="text"
             placeholder="0xF18E631Ea191aE4ebE70046Fcb01a436554421BA4"
             value=account
-            class=(if isValidAccount 'valid' '')}}
+            class=(if isValidAccount "valid" "")}}
   </p>
   <p>
     <select required onchange={{action (mut kind) value="target.value"}}>
@@ -26,39 +26,39 @@
             type="text"
             placeholder="Name"
             value=name
-            class=(if isValidName 'valid' '')}}
+            class=(if isValidName "valid" "")}}
   </p>
   <p>
     {{input name="url"
             type="text"
             placeholder="URL"
             value=url
-            class=(if isValidURL 'valid' '')}}
+            class=(if isValidURL "valid" "")}}
   </p>
   <p>
     {{input name="github_uid"
             type="text"
             placeholder="GitHub UID (123)"
             value=github_uid
-            class=(if isValidGithubUID 'valid' '')}}
+            class=(if isValidGithubUID "valid" "")}}
   </p>
   <p>
     {{input name="github_username"
             type="text"
             placeholder="GitHub username"
             value=github_username
-            class=(if isValidGithubUsername 'valid' '')}}
+            class=(if isValidGithubUsername "valid" "")}}
   </p>
   <p>
     {{input name="wiki_username"
             type="text"
             placeholder="Wiki Username"
             value=wiki_username
-            class=(if isValidWikiUsername 'valid' '')}}
+            class=(if isValidWikiUsername "valid" "")}}
   </p>
   <p class="actions">
     {{input type="submit"
             disabled=(is-pending inProgress)
-            value=(if (is-pending inProgress) 'Processing' 'Save')}}
+            value=(if (is-pending inProgress) "Processing" "Save")}}
   </p>
 </form>
diff --git a/app/components/add-proposal/template.hbs b/app/components/add-proposal/template.hbs
index 4f3cb9f..4cf6f21 100644
--- a/app/components/add-proposal/template.hbs
+++ b/app/components/add-proposal/template.hbs
@@ -20,25 +20,25 @@
     {{input type="text"
             placeholder="100"
             value=amount
-            class=(if isValidAmount 'valid' '')}}
+            class=(if isValidAmount "valid" "")}}
   </p>
   <p>
     {{input type="text"
             placeholder="Description"
             value=description
-            class=(if isValidDescription 'valid' '')}}
+            class=(if isValidDescription "valid" "")}}
   </p>
   <p>
     {{input type="text"
             placeholder="URL (optional)"
             value=url
-            class=(if isValidUrl 'valid' '')}}
+            class=(if isValidUrl "valid" "")}}
   </p>
   <p class="actions">
     {{input type="submit"
             disabled=(is-pending inProgress)
-            value=(if (is-pending inProgress) 'Processing' 'Save')}}
-    {{#link-to 'index'}}Back{{/link-to}}
+            value=(if (is-pending inProgress) "Processing" "Save")}}
+    {{#link-to "index"}}Back{{/link-to}}
   </p>
 </form>
 
diff --git a/app/components/chart-contributions-by-type/template.hbs b/app/components/chart-contributions-by-type/template.hbs
index 9157ff7..56f2b44 100644
--- a/app/components/chart-contributions-by-type/template.hbs
+++ b/app/components/chart-contributions-by-type/template.hbs
@@ -1,5 +1,5 @@
 <div class="chart">
-  {{ember-chart type='doughnut'
+  {{ember-chart type="doughnut"
                 data=chartData
                 options=chartOptions
                 width=200
diff --git a/app/components/contributor-list/template.hbs b/app/components/contributor-list/template.hbs
index c74ddcb..f529eb9 100644
--- a/app/components/contributor-list/template.hbs
+++ b/app/components/contributor-list/template.hbs
@@ -1,8 +1,8 @@
 <tbody>
   {{#each contributors as |contributor|}}
-    <tr class="{{if contributor.isCurrentUser 'current-user'}}" {{action "toggleContributorInfo" contributor}}>
+    <tr role="button" class={{if contributor.isCurrentUser "current-user"}} {{action "toggleContributorInfo" contributor}}>
       <td class="person">
-        <img class="avatar" src={{contributor.avatarURL}}>
+        <img class="avatar" src={{contributor.avatarURL}} alt="">
         {{contributor.name}}
       </td>
       <td class="kredits">
@@ -10,7 +10,7 @@
         <span class="symbol">₭S</span>
       </td>
     </tr>
-    <tr class="metadata {{if contributor.isCurrentUser 'current-user'}} {{if contributor.showMetadata 'visible'}}">
+    <tr class="metadata {{if contributor.isCurrentUser "current-user"}} {{if contributor.showMetadata "visible"}}">
       <td colspan="2">
         <ul>
           <li><a href="https://testnet.etherscan.io/address/{{contributor.account}}">Inspect Ethereum transactions</a></li>
diff --git a/app/templates/index.hbs b/app/templates/index.hbs
index f39e9f2..3278074 100644
--- a/app/templates/index.hbs
+++ b/app/templates/index.hbs
@@ -52,7 +52,7 @@
       {{!-- TODO: We need a better naming --}}
       {{#if kredits.hasAccounts}}
         <p class="actions">
-          {{#link-to 'proposals.new'}}Create new proposal{{/link-to}}
+          {{#link-to "proposals.new"}}Create new proposal{{/link-to}}
         </p>
       {{/if}}
     </section>
@@ -66,7 +66,7 @@
 
       <div class="content">
         {{#if kredits.currentUser.isCore}}
-          {{add-contributor contributors=contributors save=(action 'save')}}
+          {{add-contributor contributors=contributors save=(action "save")}}
         {{else}}
           Only core team members can add new contributors. Please ask someone to set you up.
         {{/if}}
diff --git a/app/templates/proposals/new.hbs b/app/templates/proposals/new.hbs
index 24a9fe9..e6c01da 100644
--- a/app/templates/proposals/new.hbs
+++ b/app/templates/proposals/new.hbs
@@ -4,7 +4,7 @@
   </header>
 
   <div class="content">
-    {{add-proposal contributors=minedContributors save=(action 'save')}}
+    {{add-proposal contributors=minedContributors save=(action "save")}}
   </div>
 </section>